From 8cb702c932d8cae6f2ccbbbd13d37c94bf8ddd68 Mon Sep 17 00:00:00 2001
From: Winni Neessen <winfried.neessen@cleverbridge.com>
Date: Tue, 12 Mar 2024 16:57:48 +0100
Subject: [PATCH] Add password length and coin flip tests in random_test.go

Added detailed test cases for handling password length and coin flip functionality in random_test.go. These additional unit tests cover various conditions for password lengths, and ensure that 'generateCoinFlip' behaves as expected across multiple invocations.
---
 random_test.go | 85 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 85 insertions(+)

diff --git a/random_test.go b/random_test.go
index 15de2a3..9aced01 100644
--- a/random_test.go
+++ b/random_test.go
@@ -2,6 +2,7 @@ package apg
 
 import (
 	"bytes"
+	"errors"
 	"strings"
 	"testing"
 )
@@ -213,6 +214,90 @@ func TestGetCharRangeFromConfig(t *testing.T) {
 	}
 }
 
+func TestGetPasswordLength(t *testing.T) {
+	config := NewConfig()
+	generator := New(config)
+	testCases := []struct {
+		Name              string
+		ConfigFixedLength int64
+		ConfigMinLength   int64
+		ConfigMaxLength   int64
+		ExpectedLength    int64
+		ExpectedError     error
+	}{
+		{
+			Name:              "FixedLength",
+			ConfigFixedLength: 10,
+			ConfigMinLength:   5,
+			ConfigMaxLength:   15,
+			ExpectedLength:    10,
+			ExpectedError:     nil,
+		},
+		{
+			Name:              "MinLengthEqualToMaxLength",
+			ConfigFixedLength: 0,
+			ConfigMinLength:   8,
+			ConfigMaxLength:   8,
+			ExpectedLength:    8,
+			ExpectedError:     nil,
+		},
+		{
+			Name:              "MinLengthGreaterThanMaxLength",
+			ConfigFixedLength: 0,
+			ConfigMinLength:   12,
+			ConfigMaxLength:   5,
+			ExpectedLength:    12,
+			ExpectedError:     nil,
+		},
+	}
+
+	// Act and assert for each test case
+	for _, tc := range testCases {
+		t.Run(tc.Name, func(t *testing.T) {
+			generator.config.FixedLength = tc.ConfigFixedLength
+			generator.config.MinLength = tc.ConfigMinLength
+			generator.config.MaxLength = tc.ConfigMaxLength
+			length, err := generator.GetPasswordLength()
+
+			if err != nil && !errors.Is(err, tc.ExpectedError) {
+				t.Errorf("Unexpected error: %v", err)
+			} else if err == nil && tc.ExpectedError != nil {
+				t.Errorf("Expected error %v, got nil", tc.ExpectedError)
+			} else if err == nil && length != tc.ExpectedLength {
+				t.Errorf("Expected length %d, got %d", tc.ExpectedLength, length)
+			}
+		})
+	}
+}
+
+// TestGenerateCoinFlip tries to test the coinflip. Randomness is hard to
+// test, since it's supposed to be not prodictable. We think that in 100k
+// tries at least one of each two results should be returned, even though
+// it is possible that not. Therefore we only throw a warning
+func TestGenerateCoinFlip(t *testing.T) {
+	config := NewConfig()
+	generator := New(config)
+	foundTails := false
+	foundHeads := false
+	for range 100_000 {
+		res, err := generator.generateCoinFlip()
+		if err != nil {
+			t.Errorf("generateCoinFlip() failed: %s", err)
+			return
+		}
+		switch res {
+		case "Tails":
+			foundTails = true
+		case "Heads":
+			foundHeads = true
+		}
+	}
+	if !foundTails && !foundHeads {
+		t.Logf("WARNING: generateCoinFlip() was supposed to find heads and tails "+
+			"in 100_000 tries but didn't. Heads: %t, Tails: %t", foundHeads, foundTails)
+	}
+}
+
 func BenchmarkGenerator_CoinFlip(b *testing.B) {
 	b.ReportAllocs()
 	g := New(NewConfig())