wneessen/decimal
1
1
Fork 0
mirror of https://github.com/shopspring/decimal.git synced 2024-11-22 20:40:48 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix broken RoundBank func in #75 (#76)

Browse source
This commit is contained in:
Chad Gilbert 2018-01-18 17:52:17 -05:00 committed by Victor Quinn
parent 8dffa2b7c7
commit a76a8bf60b
2 changed files with 23 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
decimal.go
View file

@ -619,7 +619,8 @@ func (d Decimal) RoundBank(places int32) Decimal {
round := d.Round(places) round := d.Round(places)
remainder := d.Sub(round).Abs() remainder := d.Sub(round).Abs()
if remainder.value.Cmp(fiveInt) == 0 && round.value.Bit(0) != 0 { half := New(5, -places-1)
if remainder.Cmp(half) == 0 && round.value.Bit(0) != 0 {
if round.value.Sign() < 0 { if round.value.Sign() < 0 {
round.value.Add(round.value, oneInt) round.value.Add(round.value, oneInt)
} else { } else {

21
decimal_test.go
View file

@ -2108,3 +2108,24 @@ func TestAvg(t *testing.T) {
t.Errorf("Failed to calculate average, expected %s got %s", NewFromFloat(4.5).String(), avg.String()) t.Errorf("Failed to calculate average, expected %s got %s", NewFromFloat(4.5).String(), avg.String())
} }
} }
func TestRoundBankAnomaly(t *testing.T) {
a := New(25, -1)
b := New(250, -2)
if !a.Equal(b) {
t.Errorf("Expected %s to equal %s", a, b)
}
expected := New(2, 0)
aRounded := a.RoundBank(0)
if !aRounded.Equal(expected) {
t.Errorf("Expected bank rounding %s to equal %s, but it was %s", a, expected, aRounded)
}
bRounded := b.RoundBank(0)
if !bRounded.Equal(expected) {
t.Errorf("Expected bank rounding %s to equal %s, but it was %s", b, expected, bRounded)
}
}