wneessen/decimal
1
1
Fork 0
mirror of https://github.com/shopspring/decimal.git synced 2024-11-22 12:30:49 +01:00
Code Issues Projects Releases Packages Wiki Activity

Reduce memory allocation in case of initialization from big.Int (#252)

Browse source 
* reduced allocs in NewFromBigInt(...) from 3 -> 2
* remaining `big.NewInt(0).Set(...)` -> `new(big.Int).Set(...)`
This commit is contained in:
lmittmann 2021-10-20 13:11:07 +02:00 committed by GitHub
parent cd57bf11a4
commit bc96f543c2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
decimal.go
View file

@ -120,7 +120,7 @@ func NewFromInt32(value int32) Decimal {
// NewFromBigInt returns a new Decimal from a big.Int, value * 10 ^ exp // NewFromBigInt returns a new Decimal from a big.Int, value * 10 ^ exp
func NewFromBigInt(value *big.Int, exp int32) Decimal { func NewFromBigInt(value *big.Int, exp int32) Decimal {
return Decimal{ return Decimal{
value: big.NewInt(0).Set(value), value: new(big.Int).Set(value),
exp: exp, exp: exp,
} }
} }
@ -831,7 +831,7 @@ func (d Decimal) IsInteger() bool {
// When the exponent is negative we have to check every number after the decimal place // When the exponent is negative we have to check every number after the decimal place
// If all of them are zeroes, we are sure that given decimal can be represented as an integer // If all of them are zeroes, we are sure that given decimal can be represented as an integer
var r big.Int var r big.Int
q := big.NewInt(0).Set(d.value) q := new(big.Int).Set(d.value)
for z := abs(d.exp); z > 0; z-- { for z := abs(d.exp); z > 0; z-- {
q.QuoRem(q, tenInt, &r) q.QuoRem(q, tenInt, &r)
if r.Cmp(zeroInt) != 0 { if r.Cmp(zeroInt) != 0 {
@ -949,7 +949,7 @@ func (d Decimal) Exponent() int32 {
func (d Decimal) Coefficient() *big.Int { func (d Decimal) Coefficient() *big.Int {
d.ensureInitialized() d.ensureInitialized()
// we copy the coefficient so that mutating the result does not mutate the Decimal. // we copy the coefficient so that mutating the result does not mutate the Decimal.
return big.NewInt(0).Set(d.value) return new(big.Int).Set(d.value)
} }
// CoefficientInt64 returns the coefficient of the decimal as int64. It is scaled by 10^Exponent() // CoefficientInt64 returns the coefficient of the decimal as int64. It is scaled by 10^Exponent()