Support scanning uint64 (#364)

This commit is contained in:
Philip Dubé 2024-04-12 13:35:56 +00:00 committed by GitHub
parent 80ec940054
commit dd603cbbbd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 32 additions and 74 deletions

View file

@ -1847,6 +1847,11 @@ func (d *Decimal) Scan(value interface{}) error {
*d = New(v, 0) *d = New(v, 0)
return nil return nil
case uint64:
// while clickhouse may send 0 in db as uint64
*d = NewFromUint64(v)
return nil
default: default:
// default is trying to interpret value stored as string // default is trying to interpret value stored as string
str, err := unquoteIfQuoted(v) str, err := unquoteIfQuoted(v)

View file

@ -2416,104 +2416,57 @@ func TestDecimal_Max(t *testing.T) {
} }
} }
func TestDecimal_Scan(t *testing.T) { func scanHelper(t *testing.T, dbval interface{}, expected Decimal) {
// test the Scan method that implements the t.Helper()
// sql.Scanner interface
// check for the for different type of values
// that are possible to be received from the database
// drivers
// in normal operations the db driver (sqlite at least)
// will return an int64 if you specified a numeric format
a := Decimal{} a := Decimal{}
if err := a.Scan(dbval); err != nil {
// Scan failed... no need to test result value
t.Errorf("a.Scan(%v) failed with message: %s", dbval, err)
} else if !a.Equal(expected) {
// Scan succeeded... test resulting values
t.Errorf("%s does not equal to %s", a, expected)
}
}
func TestDecimal_Scan(t *testing.T) {
// test the Scan method that implements the sql.Scanner interface
// check different types received from various database drivers
dbvalue := 54.33 dbvalue := 54.33
expected := NewFromFloat(dbvalue) expected := NewFromFloat(dbvalue)
scanHelper(t, dbvalue, expected)
err := a.Scan(dbvalue)
if err != nil {
// Scan failed... no need to test result value
t.Errorf("a.Scan(54.33) failed with message: %s", err)
} else {
// Scan succeeded... test resulting values
if !a.Equal(expected) {
t.Errorf("%s does not equal to %s", a, expected)
}
}
// apparently MySQL 5.7.16 and returns these as float32 so we need // apparently MySQL 5.7.16 and returns these as float32 so we need
// to handle these as well // to handle these as well
dbvalueFloat32 := float32(54.33) dbvalueFloat32 := float32(54.33)
expected = NewFromFloat(float64(dbvalueFloat32)) expected = NewFromFloat(float64(dbvalueFloat32))
scanHelper(t, dbvalueFloat32, expected)
err = a.Scan(dbvalueFloat32)
if err != nil {
// Scan failed... no need to test result value
t.Errorf("a.Scan(54.33) failed with message: %s", err)
} else {
// Scan succeeded... test resulting values
if !a.Equal(expected) {
t.Errorf("%s does not equal to %s", a, expected)
}
}
// at least SQLite returns an int64 when 0 is stored in the db // at least SQLite returns an int64 when 0 is stored in the db
// and you specified a numeric format on the schema // and you specified a numeric format on the schema
dbvalueInt := int64(0) dbvalueInt := int64(0)
expected = New(dbvalueInt, 0) expected = New(dbvalueInt, 0)
scanHelper(t, dbvalueInt, expected)
err = a.Scan(dbvalueInt) // also test uint64
if err != nil { dbvalueUint64 := uint64(2)
// Scan failed... no need to test result value expected = New(2, 0)
t.Errorf("a.Scan(0) failed with message: %s", err) scanHelper(t, dbvalueUint64, expected)
} else {
// Scan succeeded... test resulting values
if !a.Equal(expected) {
t.Errorf("%s does not equal to %s", a, expected)
}
}
// in case you specified a varchar in your SQL schema, // in case you specified a varchar in your SQL schema,
// the database driver will return byte slice []byte // the database driver may return either []byte or string
valueStr := "535.666" valueStr := "535.666"
dbvalueStr := []byte(valueStr) dbvalueStr := []byte(valueStr)
expected, err = NewFromString(valueStr) expected, err := NewFromString(valueStr)
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
} }
scanHelper(t, dbvalueStr, expected)
err = a.Scan(dbvalueStr) scanHelper(t, valueStr, expected)
if err != nil {
// Scan failed... no need to test result value
t.Errorf("a.Scan('535.666') failed with message: %s", err)
} else {
// Scan succeeded... test resulting values
if !a.Equal(expected) {
t.Errorf("%s does not equal to %s", a, expected)
}
}
// lib/pq can also return strings
expected, err = NewFromString(valueStr)
if err != nil {
t.Fatal(err)
}
err = a.Scan(valueStr)
if err != nil {
// Scan failed... no need to test result value
t.Errorf("a.Scan('535.666') failed with message: %s", err)
} else {
// Scan succeeded... test resulting values
if !a.Equal(expected) {
t.Errorf("%s does not equal to %s", a, expected)
}
}
type foo struct{} type foo struct{}
a := Decimal{}
err = a.Scan(foo{}) err = a.Scan(foo{})
if err == nil { if err == nil {
t.Errorf("a.Scan(Foo{}) should have thrown an error but did not") t.Errorf("a.Scan(Foo{}) should have thrown an error but did not")