wneessen/go-hibp
1
1
Fork 0
mirror of https://github.com/wneessen/go-hibp.git synced 2024-11-22 21:00:51 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix code smell in WithUserAgent() option detected by SonarQube

Browse source
This commit is contained in:
Winni Neessen 2022-04-12 22:52:24 +02:00
parent 6a561b0f7a
commit 842cc122a5
Signed by: wneessen
GPG key ID: 5F3AF39B820C119D
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
hibp.go
View file

@ -95,7 +95,7 @@ func WithPwnedPadding() Option {
// WithUserAgent sets a custom user agent string for the HTTP client // WithUserAgent sets a custom user agent string for the HTTP client
func WithUserAgent(a string) Option { func WithUserAgent(a string) Option {
if a == "" { if a == "" {
return func(c *Client) {} return nil
} }
return func(c *Client) { return func(c *Client) {
c.ua = a c.ua = a

6
hibp_test.go
View file

@ -65,4 +65,10 @@ func TestNewWithUserAgent(t *testing.T) {
t.Errorf("hibp client custom user agent was not set properly. Expected %s, got: %s", t.Errorf("hibp client custom user agent was not set properly. Expected %s, got: %s",
custUA, hc.ua) custUA, hc.ua)
} }
hc = New(WithUserAgent(""))
if hc.ua != DefaultUserAgent {
t.Errorf("hibp client custom user agent was not set properly. Expected %s, got: %s",
DefaultUserAgent, hc.ua)
}
} }