wneessen/go-mail
1
1
Fork 0
mirror of https://github.com/wneessen/go-mail.git synced 2024-10-05 17:55:56 +02:00
Code Issues Projects Releases Packages Wiki Activity

Refactor variable names for better clarity

Browse source 
Changed variable names for more clarity in senderror.go. This change has converted abbreviated variable names into meaningful and self-explanatory variables. This effort improves code readability and maintainability following Go's best practices.
This commit is contained in:
Winni Neessen 2024-02-27 11:32:12 +01:00
parent 7de4f5053f
commit 077cf47973
Signed by: wneessen
GPG key ID: 385AC9889632126E
1 changed files with 14 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
senderror.go
View file

@ -71,34 +71,34 @@ func (e *SendError) Error() string {
return "unknown reason" return "unknown reason"
} }
var em strings.Builder var errMessage strings.Builder
em.WriteString(e.Reason.String()) errMessage.WriteString(e.Reason.String())
if len(e.errlist) > 0 { if len(e.errlist) > 0 {
em.WriteRune(':') errMessage.WriteRune(':')
for i := range e.errlist { for i := range e.errlist {
em.WriteRune(' ') errMessage.WriteRune(' ')
em.WriteString(e.errlist[i].Error()) errMessage.WriteString(e.errlist[i].Error())
if i != len(e.errlist)-1 { if i != len(e.errlist)-1 {
em.WriteString(", ") errMessage.WriteString(", ")
} }
} }
} }
if len(e.rcpt) > 0 { if len(e.rcpt) > 0 {
em.WriteString(", affected recipient(s): ") errMessage.WriteString(", affected recipient(s): ")
for i := range e.rcpt { for i := range e.rcpt {
em.WriteString(e.rcpt[i]) errMessage.WriteString(e.rcpt[i])
if i != len(e.rcpt)-1 { if i != len(e.rcpt)-1 {
em.WriteString(", ") errMessage.WriteString(", ")
} }
} }
} }
return em.String() return errMessage.String()
} }
// Is implements the errors.Is functionality and compares the SendErrReason // Is implements the errors.Is functionality and compares the SendErrReason
func (e *SendError) Is(et error) bool { func (e *SendError) Is(errType error) bool {
var t *SendError var t *SendError
if errors.As(et, &t) && t != nil { if errors.As(errType, &t) && t != nil {
return e.Reason == t.Reason && e.isTemp == t.isTemp return e.Reason == t.Reason && e.isTemp == t.isTemp
} }
return false return false
@ -143,6 +143,6 @@ func (r SendErrReason) String() string {
// isTempError checks the given SMTP error and returns true if the given error is of temporary nature // isTempError checks the given SMTP error and returns true if the given error is of temporary nature
// and should be retried // and should be retried
func isTempError(e error) bool { func isTempError(err error) bool {
return e.Error()[0] == '4' return err.Error()[0] == '4'
} }