wneessen/go-mail
1
1
Fork 0
mirror of https://github.com/wneessen/go-mail.git synced 2024-11-27 07:55:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Simplify attachment test setup

Browse source 
Removed temporary file creation and copying in msgwriter_test.go. Directly attach the source file during the test to streamline the setup process. This change reduces complexity and potential points of failure in the test code.
This commit is contained in:
Winni Neessen 2024-11-26 16:26:13 +01:00
parent fe765cd49e
commit 75c0e3319b
Signed by: wneessen
GPG key ID: 385AC9889632126E
1 changed files with 1 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
msgwriter_test.go
View file

@ -10,7 +10,6 @@ import (
"fmt"
"io"
"mime"
"os"
"runtime"
"strings"
"testing"
@ -342,30 +341,7 @@ func TestMsgWriter_addFiles(t *testing.T) {
buffer := bytes.NewBuffer(nil)
msgwriter.writer = buffer
message := testMessage(t)
tmpfile, err := os.CreateTemp("", "attachment.*.tmp")
if err != nil {
t.Fatalf("failed to create tempfile: %s", err)
}
t.Cleanup(func() {
if err = os.Remove(tmpfile.Name()); err != nil {
t.Errorf("failed to remove tempfile: %s", err)
}
})
source, err := os.Open("testdata/attachment.txt")
if err != nil {
t.Fatalf("failed to open source file: %s", err)
}
if _, err = io.Copy(tmpfile, source); err != nil {
t.Fatalf("failed to copy source file: %s", err)
}
if err = tmpfile.Close(); err != nil {
t.Fatalf("failed to close tempfile: %s", err)
}
if err = source.Close(); err != nil {
t.Fatalf("failed to close source file: %s", err)
}
message.AttachFile(tmpfile.Name(), WithFileName(tt.filename))
message.AttachFile("testdata/attachment.txt", WithFileName(tt.filename))
msgwriter.writeMsg(message)
if msgwriter.err != nil {
t.Errorf("msgWriter failed to write: %s", msgwriter.err)