1046 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Winni Neessen	5058fd5222	Add test for SCRAM-SHA authentication failure cases ... Implemented tests for various SCRAM-SHA authentication methods including SCRAM-SHA-1, SCRAM-SHA-1-PLUS, SCRAM-SHA-256, and SCRAM-SHA-256-PLUS with invalid credentials. This ensures that the client correctly handles and reports authentication failures.	2024-10-01 17:01:10 +02:00
Winni Neessen	8838414c38	Fix incorrect error types for unsupported SMTP authentication ... Corrects the error messages returned for unsupported SMTP authentication types from ErrXOauth2AuthNotSupported to specific errors like ErrSCRAMSHA1AuthNotSupported, ErrSCRAMSHA256AuthNotSupported, and so on. This change improves the accuracy of error reporting for various SMTP authentication mechanisms.	2024-10-01 17:00:57 +02:00
Winni Neessen	b69ad27de3	Add comments for SMTP authentication mechanisms ... Enhanced the documentation by adding detailed comments for each SMTP authentication type, specifying their references to RFC documents. Corrected comments for error variables to match the corresponding authentication schemas.	2024-10-01 17:00:43 +02:00
Winni Neessen	7499bae3eb	Add unit tests for SCRAM-SHA authentication methods ... Introduce `TestClient_AuthSCRAMSHAX` to verify SCRAM-SHA-1 and SCRAM-SHA-256 authentication. These tests validate the creation, connection, and closing of clients with the respective authentication methods using environment-configured credentials.	2024-10-01 16:45:02 +02:00
Winni Neessen	324be9d032	Refactor SCRAM tests to include SHA-256-PLUS ... Updated `TestClient_AuthSCRAMSHA1PLUS_tlsexporter` and `TestClient_AuthSCRAMSHA1PLUS_tlsunique` to test both SCRAM-SHA-1-PLUS and SCRAM-SHA-256-PLUS authentication types. Implemented table-driven tests to improve readability and maintainability.	2024-10-01 16:43:36 +02:00
Winni Neessen	bcf7084982	Add detailed documentation comments for SCRAM methods ... Enhanced code readability and maintainability by adding comprehensive documentation comments to all methods and struct definitions in the `smtp/auth_scram.go` file. This improves clarity on the functionality and usage of the SCRAM (Salted Challenge Response Authentication Mechanism) methods and structures.	2024-10-01 16:39:13 +02:00
Winni Neessen	abab0af2a3	Simplify sponsor appreciation message ... Revise the sponsors section in README.md to convey gratitude more concisely. Removed redundant phrasing and made the message more direct while ensuring the intent remains clear.	2024-10-01 16:01:58 +02:00
Winni Neessen	687843ee53	Enhance contributors section and add sponsors acknowledgment ... Updated the Authors/Contributors section to include a graphical representation of contributors and added special thanks to Maria Letta for the logo design. Introduced a new Sponsors section to acknowledge the support from sponsors.	2024-10-01 15:57:01 +02:00
Winni Neessen	cace4890bc	Update README.md wordings for clarity ... Refined the wording in the README.md to enhance readability and clarity. Changed some sentences to past perfect tense and added backticks around `smtp` for consistency with code references.	2024-10-01 15:47:07 +02:00
Winni Neessen	e5b87db448	Update README to clarify library features and dependencies ... Revised the README to provide clearer explanations of the library's origins, dependencies, and features. Added details on the small dependency footprint and enhanced SMTP Auth methods, and emphasized the concurrency-safe reuse of SMTP connections.	2024-10-01 15:41:26 +02:00
Winni Neessen	5b5991f17d	Merge branch 'main' into feature/242_support-scram-sha	2024-10-01 15:30:22 +02:00
Winni Neessen	e8f3c444e6	Add SCRAM-SHA1-PLUS authentication tests ... Introduced two new unit tests for SCRAM-SHA1-PLUS authentication with TLS exporter and TLS unique options. These tests ensure proper client creation, connection, and disconnection processes are functioning as expected in online environments.	2024-10-01 15:28:53 +02:00
Winni Neessen	27838f5b1f	Improve TLS state handling and add SCRAM-SHA-256 auth support ... Replaced direct TLSConnectionState call with error handling for TLS state retrieval. Introduced SCRAM-SHA-256 support in the SMTP authentication process.	2024-10-01 15:28:10 +02:00
Winni Neessen	3013975c6a	Rename and refactor SCRAM authentication methods ... Updated method names to more accurately reflect their authentication mechanisms (SCRAM-SHA-1, SCRAM-SHA-1-PLUS, SCRAM-SHA-256, SCRAM-SHA-256-PLUS). Revised corresponding comments to improve clarity and maintain consistency.	2024-10-01 15:27:31 +02:00
Winni Neessen	c797f0be17	Add REUSE.toml ... Replaced deprecated .reuse/dep5 with REUSE.toml config file	2024-10-01 15:27:05 +02:00
Winni Neessen	b96badbd59	Add license file for go.sum ... Introduce a go.sum.license file to explicitly state the licensing terms for the go.sum file. This ensures proper attribution and compliance with open-source licensing requirements.	2024-10-01 15:25:51 +02:00
Winni Neessen	738f43e289	Add GetTLSConnectionState method to SMTP client ... Introduce a method to retrieve the TLS connection state of the client's current connection. This method checks if the connection uses TLS and is established, returning appropriate errors otherwise.	2024-10-01 11:05:42 +02:00
Winni Neessen	ebd171005d	Update dependencies in go.mod and go.sum ... Added `golang.org/x/crypto v0.27.0` and `golang.org/x/text v0.18.0` to go.mod. Updated go.sum to reflect these changes for proper dependency management.	2024-10-01 11:05:07 +02:00
Winni Neessen	4f1a60760d	Add support for SCRAM-SHA authentication methods ... Extended SMTP authentication to include SCRAM-SHA-1, SCRAM-SHA-1-PLUS, SCRAM-SHA-256, and SCRAM-SHA-256-PLUS methods. This enhancement provides more secure and flexible authentication options for SMTP clients.	2024-10-01 11:04:16 +02:00
Winni Neessen	e8fc6cd78f	Add SCRAM-SHA support to SMTP authentication ... Introduced additional SMTP authentication mechanisms: SCRAM-SHA-1, SCRAM-SHA-1-PLUS, SCRAM-SHA-256, and SCRAM-SHA-256-PLUS. Added corresponding error messages for unsupported authentication types. This enhances security options for SMTP connections.	2024-10-01 11:04:01 +02:00
Winni Neessen	9069c9cdff	Add SCRAM-SHA support to SMTP authentication ... Introduced additional SMTP authentication mechanisms: SCRAM-SHA-1, SCRAM-SHA-1-PLUS, SCRAM-SHA-256, and SCRAM-SHA-256-PLUS. Added corresponding error messages for unsupported authentication types. This enhances security options for SMTP connections.	2024-10-01 11:03:44 +02:00
Winni Neessen	627216425f	Merge pull request #309 from wneessen/dependabot/github_actions/github/codeql-action-3.26.10 ... Bump github/codeql-action from 3.26.9 to 3.26.10	2024-09-30 15:42:23 +02:00
dependabot[bot]	012082978d	Bump github/codeql-action from 3.26.9 to 3.26.10 ... Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.9 to 3.26.10. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](461ef6c76d...e2b3eafc8d) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2024-09-30 13:36:41 +00:00
theexiile1305	46cf2ed498	fix: part boundray and message encoding	2024-09-29 16:46:30 +02:00
Winni Neessen	65a91a2711	Merge pull request #307 from wneessen/feature/269_goroutineconcurrency-safety ... go-mail goroutine-/thread-safety	2024-09-27 17:17:00 +02:00
Winni Neessen	c1f6ef07d4	Skip test cases when client creation fails ... Updated the client creation check to skip test cases if the client cannot be created, instead of marking them as errors. This ensures tests dependent on a successful client creation do not fail unnecessarily but are instead skipped.	2024-09-27 17:09:00 +02:00
Winni Neessen	6e98d7e47d	Reduce message loop iterations and add XOAUTH2 tests ... Loop iterations in `client_test.go` were reduced from 50 to 20 for efficiency. Added new tests to verify XOAUTH2 authentication support and error handling by simulating SMTP server responses.	2024-09-27 17:00:21 +02:00
Winni Neessen	8791ce5a33	Fix deferred mutex unlock in TLSConnectionState ... Correct the sequence of mutex unlocking in TLSConnectionState to ensure the mutex is always released properly. This prevents potential deadlocks and ensures the function behaves as expected in a concurrent context.	2024-09-27 17:00:07 +02:00
Winni Neessen	2d98c40cb6	Add concurrent send tests for Client ... Introduced TestClient_DialSendConcurrent_online and TestClient_DialSendConcurrent_local to validate concurrent sending of messages. These tests ensure that the Client's send functionality works correctly under concurrent conditions, both in an online environment and using a local test server.	2024-09-27 14:04:02 +02:00
Winni Neessen	253d065c83	Move mutex lock to sendSingleMsg method ... Mutex locking was relocated from the Send method in client_120.go and client_119.go to sendSingleMsg in client.go. This ensures thread-safety specifically during the message transmission process.	2024-09-27 14:03:50 +02:00
Winni Neessen	6bd9a9c735	Refactor mutex usage for connection safety ... This commit revises locking mechanism usage around connection operations to avoid potential deadlocks and improve code clarity. Specifically, defer statements were removed and explicit unlocks were added to ensure that mutexes are properly released after critical sections. This change affects several methods, including `Close`, `cmd`, `TLSConnectionState`, `UpdateDeadline`, and newly introduced locking for concurrent data writes and reads in `dataCloser`.	2024-09-27 14:03:26 +02:00
Winni Neessen	f59aa23ed8	Add mutex locking to SetTLSConfig ... This change ensures that the SetTLSConfig method is thread-safe by adding a mutex lock. The lock is acquired before any changes to the TLS configuration and released afterward to prevent concurrent access issues.	2024-09-27 11:58:08 +02:00
Winni Neessen	2234f0c5bc	Remove connection field from Client struct ... This commit removes the 'connection' field from the 'Client' struct and updates the related test logic accordingly. By using 'smtpClient.HasConnection()' to check for connections, code readability and maintainability are improved. All necessary test cases have been adjusted to reflect this change.	2024-09-27 11:43:22 +02:00
Winni Neessen	fdb80ad9dd	Add mutex to Client for thread-safe operations ... This commit introduces a RWMutex to the Client struct in the smtp package to ensure thread-safe access to shared resources. Critical sections in methods like Close, StartTLS, and cmd are now protected with appropriate locking mechanisms. This change helps prevent potential race conditions, ensuring consistent and reliable behavior in concurrent environments.	2024-09-27 11:10:23 +02:00
Winni Neessen	fec2f2075a	Update build tags to support future Go versions ... Modified the build tags to exclude Go 1.20 and above instead of targeting only Go 1.19. This change ensures the code is compatible with future versions of Go by not restricting it to a specific minor version.	2024-09-27 10:52:30 +02:00
Winni Neessen	2084526c77	Refactor Client struct to improve organization and clarity ... Rearranged and grouped struct fields more logically within Client. Introduced the dialContextFunc and fallbackPort fields to enhance connection flexibility. Minor code style adjustments were also made for better readability.	2024-09-27 10:36:09 +02:00
Winni Neessen	23c71d608f	Lock mutex before checking connection in Send method ... Added mutex locking in the `Send` method for both `client_120.go` and `client_119.go`. This ensures thread-safe access to the connection checks and prevents potential race conditions.	2024-09-27 10:33:28 +02:00
Winni Neessen	371b950bc7	Refactor Client struct for better readability and organization ... Reordered and grouped fields in the Client struct for clarity. The reorganization separates logical groups of fields, making it easier to understand and maintain the code. This includes proper grouping of TLS parameters, DSN options, and debug settings.	2024-09-27 10:33:19 +02:00
Winni Neessen	b2c4b533d7	Merge branch 'main' into feature/269_goroutineconcurrency-safety	2024-09-27 10:26:39 +02:00
theexiile1305	79f22fb722	feat: specific error if certificate is invalid	2024-09-26 17:28:24 +02:00
theexiile1305	4b60557518	fix: failing tests	2024-09-26 17:14:42 +02:00
theexiile1305	9bdb741e05	feat: begin implementation of tests	2024-09-26 17:08:38 +02:00
theexiile1305	2368113872	feat: implementation of tests	2024-09-26 16:43:58 +02:00
theexiile1305	12edb2724b	feat: implementation of S/MIME signing without tests	2024-09-26 16:34:55 +02:00
Winni Neessen	3871b2be44	Lock client connections and update deadline handling ... Add mutex locking for client connections to ensure thread safety. Introduce `HasConnection` method to check active connections and `UpdateDeadline` method to handle timeout updates. Refactor connection handling in `checkConn` and `tls` methods accordingly.	2024-09-26 11:51:30 +02:00
Winni Neessen	8683917c3d	Delete connection pool implementation and tests ... Remove `connpool.go` and `connpool_test.go`. This eliminates the connection pool feature from the codebase, including associated functionality and tests. The connection pool feature is much to complex and doesn't provide the benefits expected by the concurrency feature	2024-09-26 11:49:48 +02:00
theexiile1305	3154649420	feat: add flag smime for indicating that the part should be marked for singing with S/MIME	2024-09-26 11:37:53 +02:00
theexiile1305	65b9fd07da	feat: remove unused content disposition	2024-09-26 11:32:27 +02:00
Winni Neessen	077c85bea0	Merge pull request #305 from wneessen/dependabot/github_actions/sonarsource/sonarqube-scan-action-884b79409bbd464b2a59edc326a4b77dc56b2195 ... Bump sonarsource/sonarqube-scan-action from f885e52a7572cf7943f28637e75730227df2dbf2 to 884b79409bbd464b2a59edc326a4b77dc56b2195	2024-09-25 16:00:56 +02:00
Winni Neessen	909e699b99	Merge pull request #306 from wneessen/dependabot/github_actions/github/codeql-action-3.26.9 ... Bump github/codeql-action from 3.26.8 to 3.26.9	2024-09-25 16:00:44 +02:00