124 commits

Author	SHA1	Message	Date
Winni Neessen	7ee4e47c8e	Add EchoBuffer to serverProps for capturing SMTP data ... Introduced a new io.Writer field `EchoBuffer` and its associated `BufferMutex` to `serverProps`. Updated relevant test code to write SMTP transaction data to `EchoBuffer` if it is set, ensuring thread safety with `BufferMutex`.	2024-11-19 17:29:26 +01:00
Winni Neessen	6d3640a166	Fix auth type auto-discovery and add test cases ... Refactor the auth type initialization to prevent incorrect assignments and handle empty supported lists. Added comprehensive test cases to verify auto-discovery selection of the strongest authentication method and ensure robustness against empty or invalid input.	2024-11-16 21:38:29 +01:00
Winni Neessen	ac9117dc50	Add SMTP authentication auto-discovery ... Implemented a mechanism to automatically discover and select the strongest supported SMTP authentication type. This feature simplifies the authentication process for users and enhances security by prioritizing stronger mechanisms based on server capabilities. Corresponding tests and documentation have been updated.	2024-11-16 14:29:34 +01:00
Winni Neessen	ca3f50552e	Allow configuration of test server port via environment variable ... Moved TestServerPortBase initialization to use an environment variable `TEST_BASEPORT` if provided. This adjustment helps in specifying custom base ports for running tests, ensuring better flexibility in different testing environments.	2024-11-14 10:36:24 +01:00
Winni Neessen	b9d9449252	Change test server port base for SMTP client tests ... Updated the TestServerPortBase from 12025 to 30025 to avoid port conflicts with other services running on the common 12025 port. This adjustment aims to ensure that the tests run reliably in diverse environments.	2024-11-13 21:25:39 +01:00
Winni Neessen	6809084e80	Add enhanced status code and error code to SendError ... Enhance error handling by adding error code and enhanced status code to the SendError struct. This allows for better troubleshooting and debugging by providing more detailed SMTP server responses.	2024-11-13 16:11:28 +01:00
Winni Neessen	ad86c7ac4f	Correct typo in test name ... The test name had a typo in the word "recipient." This commit corrects "recepient" to "recipient" to improve code readability and maintain consistency in naming conventions. This change does not modify any functional behavior of the tests.	2024-11-11 20:06:07 +01:00
Winni Neessen	a5fcb3ae8b	Add test for closing a nil smtpclient ... Introduce a unit test to ensure that invoking Close on a nil smtpclient instance returns nil without errors. This enhances the robustness of the client closure functionality. This test accommodates the fix provided with PR #353	2024-11-06 10:47:31 +01:00
Winni Neessen	8e11fabbaf	Remove unused TestRcpt constant from client_test.go ... The TestRcpt constant was defined but never used within the test file, leading to unnecessary clutter. Removing it enhances code readability and maintainability.	2024-10-28 21:14:05 +01:00
Winni Neessen	61244a541e	Refactor msgWriter tests and add new test cases ... Reorganize existing tests for msgWriter and writeMsg, adding subtests for various encoding, charset, and failure scenarios. Enhanced tests to cover multipart/mixed, multipart/related, multipart/alternative, application/pgp-encrypted, application/pgp-signature messages, and handling of preformatted headers.	2024-10-28 20:52:38 +01:00
Winni Neessen	7d670a1f24	Add temporary failure condition in client test ... Introduce a new `FailTemp` property to simulate a temporary failure during the DATA transmission phase in tests. This helps ensure better coverage and handling of specific error conditions.	2024-10-28 17:31:11 +01:00
Winni Neessen	78ee1a2a81	Fix timeout message in client_test.go ... Updated the skip message to accurately reflect the timeout reason when closing the test server connection. This improves the clarity of the error reporting in tests.	2024-10-27 12:11:48 +01:00
Winni Neessen	b510d2654c	Handle timeout errors in test client cleanup ... Added a check in the client cleanup function to skip the test if the client connection fails due to a timeout. This ensures that network-related timeouts do not cause test failures, providing more reliable test outcomes.	2024-10-27 12:10:51 +01:00
Winni Neessen	cf117d320b	Add nil check in testMessage helper function ... Added a conditional check to ensure 'NewMsg()' does not return nil in the 'testMessage' helper function. This update will prevent potential nil pointer dereferences and improve the robustness of the test.	2024-10-26 21:07:04 +02:00
Winni Neessen	d7b32480fd	Handle test server connection timeouts ... Add logic to skip tests if there's a timeout error while connecting to the test server. This ensures that transient network issues do not cause test failures.	2024-10-26 17:33:52 +02:00
Winni Neessen	23399ed84c	Change DefaultHost to loopback address ... Updated DefaultHost from "localhost" to "127.0.0.1" in client_test.go. This change ensures consistent and direct communication with the local machine, avoiding potential issues with DNS resolution of "localhost".	2024-10-26 17:17:58 +02:00
Winni Neessen	273a26ca53	Add tests for Go 1.21+ compatibility ... Moved some tests that use JSONlog (which requires Go 1.21+) to a separate file that is skipped on older Go versions.	2024-10-26 17:10:50 +02:00
Winni Neessen	143e3b5b4f	Fix context in tests and improve error handling ... Updated test cases to use a predefined context instead of creating new backgrounds. Additionally, improved error handling by checking for client creation failures and adding appropriate fatal log messages. These changes enhance test reliability and debugging clarity.	2024-10-25 11:46:48 +02:00
Winni Neessen	64aeb683ba	Format test cases for consistency ... Reformat test cases in `client_test.go` for better readability and consistency by converting single-line struct definitions into multi-line blocks. This change improves code maintainability and aligns the formatting across similar tests.	2024-10-25 11:35:25 +02:00
Winni Neessen	7ed23bf01b	Remove outdated client test cases ... Removed obsolete and redundant client test cases that were no longer relevant. This cleanup improves code maintainability and readability by eliminating excessive, unused test methods.	2024-10-24 12:53:37 +02:00
Winni Neessen	0310527eb5	Completed client.go tests ... We've now covered 96% of all code. Everything else is not testable for us at this point.	2024-10-24 12:25:13 +02:00
Winni Neessen	1399a3331a	Refactor and extend client email tests ... Refactor existing email sending tests by organizing multiple edge cases and adding robust test coverage. This includes adding checks for invalid sender/recipient addresses, handling DSN support, and ensuring proper client server interactions during failures like DATA init, DATA close, and MAIL FROM.	2024-10-24 12:03:56 +02:00
Winni Neessen	1519522e5d	Reduce sleep duration in client tests ... Decreased sleep time from 300ms to 30ms across multiple tests to improve test execution speed. Added a new test `TestClient_sendSingleMsg` to connect and send an email message, ensuring the robustness of the sending functionality.	2024-10-24 10:50:17 +02:00
Winni Neessen	3bf1992cab	Improve test conciseness and concurrency handling ... Simplified repeated message initialization by introducing a helper function `testMessage(t)`. Enhanced existing tests by adding robust concurrency tests and refined the structure of email sending scenarios.	2024-10-24 10:45:05 +02:00
Winni Neessen	040289cea4	Remove hardcoded test credentials and add new auth tests. ... Replaced hardcoded SMTP credentials with generic placeholders for improved security. Added new test cases to handle unsupported authentication methods and connections without TLS.	2024-10-24 10:12:43 +02:00
Winni Neessen	2a2176d700	Add tests for various SMTP authentication methods ... Implemented new test cases for different SMTP authentication methods including PLAIN, LOGIN, XOAUTH2, and various SCRAM mechanisms. These tests ensure that the client can correctly handle both successful and failing authentication scenarios, as well as unsupported authentication types.	2024-10-24 09:59:31 +02:00
Winni Neessen	28dc629674	Refactor and expand client dial-and-send tests ... Renamed TestClient_DialAndSend to TestClient_DialAndSendWithContext and reorganized message setup. Added multiple test cases to cover different failure points in the DialAndSendWithContext method.	2024-10-24 00:50:16 +02:00
Winni Neessen	84ca70083a	Add test for DialAndSend functionality ... Introduce a new test `TestClient_DialAndSend` to validate the process of dialing and sending an email using the SMTP client. This includes setting up a mock SMTP server and verifying the process from message creation to sending.	2024-10-24 00:30:57 +02:00
Winni Neessen	06f6fd3692	Add client reset functionality tests ... Introduce tests for the client reset functionality, including scenarios to test successful reset, reset on a disconnected client, and reset with server failure. This ensures robustness and reliability of the client reset feature under various conditions.	2024-10-24 00:22:33 +02:00
Winni Neessen	2710250baa	Add *testing.T to simpleSMTPServer and logging improvements ... Pass `*testing.T` to `simpleSMTPServer` for enhanced test logging and helper methods. This allows better integration with the testing framework, converting standard log outputs to `t.Logf` for improved test diagnostics and error reporting.	2024-10-24 00:11:58 +02:00
Winni Neessen	cf1246d9ea	Remove redundant DialWithContext test cases ... Deleted two test functions for DialWithContext that tested invalid HELO and authentication scenarios. These tests were deemed redundant as the error handling for these cases is covered elsewhere.	2024-10-23 23:34:13 +02:00
Winni Neessen	c63b8b124e	Add STARTTLS and SSL test cases for SMTP client ... Extended test cases to include scenarios for STARTTLS and SSL connections. This includes handling TLS configurations, testing certificate handling, and tests for various authentication methods under TLS.	2024-10-23 23:33:33 +02:00
Winni Neessen	ea57644a8e	Add debug logging to client creation in tests ... Introduce `WithDebugLog()` in client creation for enhanced logging during tests. Correct handling of certain SMTP command errors by replacing `return` with `break` in switch cases for proper loop continuation.	2024-10-23 22:20:32 +02:00
Winni Neessen	572751ac10	Add test for invalid HELO handling in SMTP client ... Introduce a new test case to ensure the SMTP client fails gracefully when an invalid HELO command is used. This includes validating error handling and maintaining the client connection integrity. Also, optimize EHLO/HELO command handling by enhancing syntax checking and error response generation.	2024-10-23 18:20:52 +02:00
Winni Neessen	d281f838d4	Add integration tests for invalid host and HELO failure ... Add test cases to validate client behavior on connecting with an invalid host and encountering a HELO failure. This helps ensure the client handles these error scenarios correctly, maintaining robustness and reliability.	2024-10-23 18:08:30 +02:00
Winni Neessen	0db1383940	Refactor buffer initialization in client tests ... Replaced &bytes.Buffer{} with bytes.NewBuffer(nil) for buffer initialization in various client tests. This change ensures more idiomatic and consistent creation of byte buffers throughout the test cases.	2024-10-23 17:58:08 +02:00
Winni Neessen	12695385e8	Refactor SMTP server test setup to use serverProps struct ... Consolidate server configuration properties into a new serverProps struct for better code clarity and future extensibility. This change involves updating simpleSMTPServer and test cases to use the new struct, allowing more control over server behavior during tests.	2024-10-23 17:55:31 +02:00
Winni Neessen	8a6cd2b448	Add and update client tests ... Reintroduces and enhances several client tests including `SetLogAuthData`, `Close`, `DialWithContext`, and others. Deprecated and non-functional tests are removed, and a new log parsing method is added for enhanced logging validation.	2024-10-23 17:34:23 +02:00
Winni Neessen	ae7160ddba	Refactor SMTP Auth unit test with table-driven approach ... Replaced the single test case for setting custom SMTP authentication with a table-driven approach. This refactor improves test coverage by including multiple authentication methods such as CRAM-MD5, LOGIN, PLAIN, SCRAM, and XOAUTH2.	2024-10-23 16:46:18 +02:00
Winni Neessen	d4dc212dd3	Refactor client tests and add SetSMTPAuthCustom test ... Removed outdated tests for TLSConfig, Username, Password, and SMTPAuth that were commented out. Added a new test for the SetSMTPAuthCustom method, specifically for PLAIN authentication, ensuring proper behavior and type checks.	2024-10-23 16:14:05 +02:00
Winni Neessen	17cb590a45	Add test for Client.SetSMTPAuth function ... Introduce a new test to validate the functionality of the Client.SetSMTPAuth method. This test covers various SMTP authentication types and ensures that the method correctly sets the expected authentication type while also verifying the override behavior for different custom and default authentications.	2024-10-23 15:44:21 +02:00
Winni Neessen	c946f74ad2	Add unit tests for Client TLS, Username, and Password methods ... Introduced unit tests for Client's SetTLSConfig, SetUsername, and SetPassword methods. The tests cover various scenarios, including setting valid configurations, handling nil inputs, and overriding previous settings. This improves our test coverage and ensures the reliability of these methods.	2024-10-23 15:31:00 +02:00
Winni Neessen	68bc5dde72	Add comprehensive tests for Client TLS and debugging features ... Implemented detailed test cases for various TLS policies and settings, port configurations, and SSL options. Also added tests for debugging functionalities of the Client, enabling robust validation of different scenarios.	2024-10-23 15:15:59 +02:00
Winni Neessen	c5b57543c1	Update client tests to add context support and new checks ... Introduced `context` package for new tests. Added checks for `WithDialContextFunc`, `WithLogAuthData`, and TLS policy assertions. Improved test failure handling and removed obsolete tests.	2024-10-23 14:08:19 +02:00
Winni Neessen	ab8fc3e4fc	Add DSN and dial context func options to client tests ... Expanded the client test cases to include DSN mail return types and multiple DSN recipient notify types. Also added tests for setting dial context functions using both net.Dialer and tls.Dialer, including error handling for invalid options.	2024-10-23 13:51:48 +02:00
Winni Neessen	3251d74c36	Refactor client test to enhance coverage and clarity ... Reorganized and refactored tests for `NewClient` by adding individual test cases for different client creation scenarios, including various options and validation. Improved clarity and coverage by isolating cases, enhancing error messages, and removing redundancy.	2024-10-23 13:23:01 +02:00
Winni Neessen	c7d0a03ddc	Change error log to debug log in client_test.go ... Updated the log level from error to debug for the client.Close() call failure in client_test.go. This change helps reduce noise in test output when the server connection fails.	2024-10-22 16:21:09 +02:00
Winni Neessen	3c29f68cc1	Add support for unsecured SMTP LOGIN auth ... Implemented an option to allow SMTP LOGIN authentication over unencrypted channels by introducing a new `SMTPAuthLoginNoEnc` type. Updated relevant functions and tests to handle the new parameter for unsecured authentication.	2024-10-22 15:38:51 +02:00
Winni Neessen	f5531eae14	Add support for PLAIN authentication without encryption ... Implemented a new SMTPAuthPlainNoEnc option to allow PLAIN authentication over unencrypted connections. Refactored the PlainAuth function to accept an additional allowUnencryptedAuth parameter. Updated relevant tests to cover the new authentication method.	2024-10-22 15:30:15 +02:00
Winni Neessen	e854b2192f	Merge pull request #335 from wneessen/bug/332_server-does-not-support-smtp-auth-error-when-using-localhost-in-v050 ... Add default SMTP authentication type to NewClient	2024-10-16 09:26:51 +02:00