wneessen/go-mail
1
1
Fork 0
mirror of https://github.com/wneessen/go-mail.git synced 2024-11-23 22:20:51 +01:00
Code Issues Projects Releases Packages Wiki Activity
1365 commits 2 branches 39 tags 10 MiB
Commit graph

102 commits

Author SHA1 Message Date
Winni Neessen
2234f0c5bc
Remove connection field from Client struct 
This commit removes the 'connection' field from the 'Client' struct and updates the related test logic accordingly. By using 'smtpClient.HasConnection()' to check for connections, code readability and maintainability are improved. All necessary test cases have been adjusted to reflect this change.
 2024-09-27 11:43:22 +02:00
Winni Neessen
2084526c77
Refactor Client struct to improve organization and clarity 
Rearranged and grouped struct fields more logically within Client. Introduced the dialContextFunc and fallbackPort fields to enhance connection flexibility. Minor code style adjustments were also made for better readability.
 2024-09-27 10:36:09 +02:00
Winni Neessen
3871b2be44
Lock client connections and update deadline handling 
Add mutex locking for client connections to ensure thread safety. Introduce `HasConnection` method to check active connections and `UpdateDeadline` method to handle timeout updates. Refactor connection handling in `checkConn` and `tls` methods accordingly.
 2024-09-26 11:51:30 +02:00
Winni Neessen
d400379e2f
Refactor error handling for SendError struct 
Reformat the construction of SendError objects for better readability. This improves the clarity and maintainability of the error handling code within the client.go file.
 2024-09-20 10:31:19 +02:00
Winni Neessen
0239318d94
Add affectedMsg field to SendError struct 
Included the affected message in the SendError struct for better error tracking and debugging. This enhancement ensures that any errors encountered during the sending process can be directly associated with the specific message that caused them.
 2024-09-19 12:09:23 +02:00
Winni Neessen
277ae9be19
Refactor message sending logic 
Consolidated the message sending logic into a single `sendSingleMsg` function to reduce duplication and improve code maintainability. This change simplifies the `Send` method in multiple Go version files by removing redundant code and calling the new helper function instead.
 2024-09-19 10:56:01 +02:00
Norbert Hauriel
c811ee689f
fix(typo): client.go error message 2024-07-24 13:12:06 +02:00
Winni Neessen
94138b6d23
Refine SMTP port selection and fallback logic 
The update modifies the client's handling of port selection when configuring SSL/TLS connections. The clients' functions `WithSSLPort`, `WithTLSPortPolicy`, `SetTLSPortPolicy`, and `SetSSLPort` are revised to avoid overriding previously set ports. Additionally, the deprecation notes have been removed and replaced with notes on best-practice recommendations, referring the new *Port*() methods. This change revises #105 and takes the comments made in #181 into account.
 2024-04-06 16:49:34 +02:00
Winni Neessen
f18335fa1d
Refactor variable names in SMTP client code 
Improved variable names in the SMTP client code to make them more expressive and descriptive. Also corrected several code comments to enhance clarity. These changes are intended to increase code readability and maintainability and have been implemented throughout the client_119.go and client.go files for consistency in naming conventions.
 2024-02-25 17:48:53 +01:00
Winni Neessen
e1098091c3
Refactor variable names in SMTP client code 
The commit introduces improved variable names in the SMTP client code that are more expressive and better describe the function they perform. This is combined with corrections to some code comments. It's aimed to increase code readability and maintainability. Updates are made across the client_119.go and client.go files to ensure consistent naming conventions.
 2024-02-24 22:06:18 +01:00
Winni Neessen
1efac7fb67
Add new test cases for client functionalities and clean client code 
Test cases have been added for numerous client functionalities including WithTLSPortPolicy option for the NewClient method, Client.SetSSLPort method, and the Client.DialWithContext method with the fallback port functionality. Minor code simplification has also been performed in the 'SetSSLPort' function in client.go file.
 2024-01-31 11:22:01 +01:00
Winni Neessen
7a2d9ff938
#105: Add default ports and fallback behavior for SSL and TLS 
Introduced default ports for SSL/TLS and STARTTLS connections in SMTP client. Also added fallback behavior, allowing the client to attempt connections on port 25 using plaintext if secured connections fail. Deprecated old methods and implemented new ones to enforce these changes effectively.

This is a copy of the PR muhlemmer:enhance-default-tls-port by @muhlemmer. Since they unfortunately didn't reply in the PR anymore I cloned the PR. They will be fully attributed in the PR, though.
 2024-01-25 13:39:02 +01:00
Winni Neessen
bb18ef9e93
"Improve error checking in SMTP client creation" 
A change was made in the SMTP client creation process to add more robust error handling. The new logic checks if the client is null after being created and, if true, returns an error. This update can help prevent potential null pointer exceptions in runtime, ultimately leading to more stable application.
 2023-11-29 16:25:35 +01:00
Nicola Murino
8673addaf0 OAuth2: remove variants 
Microsoft also accept the same protocol used for Google servers
 2023-05-29 18:19:01 +02:00
Nicola Murino
6e4b348ccf add Oauth2 support 
fixes #129
 2023-05-28 14:31:04 +02:00
sters
e757327e1d
Adding WithDialContextFunc client option 2023-04-19 23:20:33 +09:00
Winni Neessen
6633591b51
Implement Logger interface 
As stated in https://github.com/wneessen/go-mail/pull/102#issuecomment-1411956040 it would be beneficial if, instead of forcing the Go stdlib logger on the user to provide a simple interface and use that for logging purposes.

This PR implements this simple log.Logger interface as well as a standard logger that satisfies this interface. If no custom logger is provided, the Stdlog will be used (which makes use of the Go stdlib again).

Accordingly, a `Client.WithLogger` and `Client.SetLogger` have been implemented. Same applies for the smtp counterparts.
 2023-02-03 10:19:26 +01:00
Winni Neessen
63d8cef8ca
Refactor DSN handling from client.go to smtp.go 
This PR refactors the the DSN (RFC 1891) SMTP client handling, that was introduced in f4cdc61dd0.

While most of the Client options stay the same, the whole workaround logic for the SMTP client has been removed and added as part of the SMTP client instead.

This was we got rid of the Client's own `mail()`, `rcpt()`, `dsnRcpt()`, `dsnMail()` methods as well as the copies of the `cmd()` and `validateLine()` methods. The Client is now using the proper `Mail()` and `Rcpt()` methods of the SMTP client instead.
 2023-01-18 10:30:06 +01:00
Winni Neessen
3922d3f195
Switched copyright header from me to "The go-mail Authors" 2023-01-15 16:14:19 +01:00
Winni Neessen
e36511e90e
Fix tests to not log authentication data 
We don't want to expose SMTP authentication details in tests, therefore the tests have been adjusted a bit
 2023-01-14 13:05:04 +01:00
Winni Neessen
34b432a985
Implement debug logging in SMTP client 
Resolves #101.

Since we now have full control over the SMTP client we can also access the message input and output.

This PR introduces a new debug logging feature. Via the `Client.WithDebugLog` the user can enable this feature. It will then make use of the new `smtp/Client.SetDebugLog` method. Once the flag is set to true, the SMTP client will start logging incoming and outgoing messages to os.Stderr.

Log directions will be output accordingly
 2023-01-14 12:47:51 +01:00
Winni Neessen
0d6777ab39
Fork net/smpt into go-mail 
As part of #97 we are going to fork the official `net/smtp` package into go-mail to provide us with more flexibility.

This commit fulfills the first big step of importing the package into smtp/. Also go-mail's own LoginAuth has been moved from auth/ into smtp/ to be consistent with the stdlib.

There are still a couple of open issues (i. e. license adjustments and making golangci-lint happy) but so far all tests already work, which is a good start.
 2023-01-10 00:38:42 +01:00
Winni Neessen
f454ae8c41
Merge pull request #88 from james-d-elliott/feat-without-noop 
feat: without noop option
 2022-12-26 16:49:38 +01:00
James Elliott
567276d75d
feat: without noop option 
This allows disabling the Noop command during the dial. This is useful for servers which delay potentially unwanted clients when they perform commands other than AUTH.
 2022-12-27 00:06:20 +11:00
James Elliott
b8646489ae
fix: tls config unused with dialer 
This ensures the configured tls.Config is used with the tls.Dialer.
 2022-12-26 23:48:52 +11:00
Winni Neessen
48b4dc6b6c
Fix #85: Client.Send() failing for all messages if one is broken 
`Client.Send()` provides the possibility to send multiple `*Msg` in one go. If one of the `*Msg` caused an error with the sending mail server, we were returning completely, while not processing any `*Msg` that came after the failing message.

This PR fixes this behaviour by processing each message first and then return a accumulated error in case any of the `*Msg` processing failed

Additionally, this PR separates the `Client.Send()` method into two different versions. One that makes use of the new `errors.Join()` functionality that is introduced with Go 1.20 and one that handles it the old way for any supported version lower than Go 1.20
 2022-12-10 13:41:00 +01:00
Winni Neessen
d200e982bf
Make golangci-lint errorlint happy 2022-10-17 18:16:00 +02:00
Winni Neessen
5bea905ff9
Make golangci-lint gofumpt happy 2022-10-17 18:12:18 +02:00
Winni Neessen
f53579fcf9
Closes #54 
- Adds `DialAndSendWithContext()` and makes `DialAndSend()` use the new method
 2022-09-26 10:40:57 +02:00
Winni Neessen
885d80aeb7
Let's actually not expose those new methods as they should not be used externally 2022-09-11 21:59:18 +02:00
Winni Neessen
4d8bc7ca28
Implemented DSNs as described in RFC 1891 
- Implemented MAIL FROM RET parameter
- Implemented RCPT TO NOTIFY parameter

Not implemented so far (not sure if we need this at all):
- MAIL FROM ENVID parameter
- RCPT TO ORCPT parameter

TBD:
- Test coverage
 2022-09-11 20:24:28 +02:00
Winni Neessen
31001e87b2
#24: Add SPDX license IDs for REUSE compliance 
# SUMMARY

* Bad licenses:
* Deprecated licenses:
* Licenses without file extension:
* Missing licenses:
* Unused licenses:
* Used licenses: CC0-1.0, MIT
* Read errors: 0
* Files with copyright information: 45 / 45
* Files with license information: 45 / 45

Congratulations! Your project is compliant with version 3.0 of the REUSE Specification :-)
 2022-06-17 15:05:54 +02:00
Winni Neessen
894ff7128c
Rename Write() to WriteTo() so it satisfies the io.WriteTo interface 2022-05-24 15:46:59 +02:00
Winni Neessen
1c699da955
More tests. Also testing GH's behaviour on ENV variables for testing 2022-03-16 21:02:31 +01:00
Winni Neessen
a0ebc5bd78
More and better tests for client.go 2022-03-15 22:37:55 +01:00
Winni Neessen
fe3925c1e6
More tests coverage for client.go 2022-03-15 21:48:36 +01:00
Winni Neessen
4585a53be8
Added error to Options so we can check inputs 2022-03-15 21:10:03 +01:00
Winni Neessen
1157180369
v0.1.1: Added embeds/attachments 2022-03-14 10:29:53 +01:00
Winni Neessen
8c804ec573
Implemented MIME multipart handling for alternative content 2022-03-13 17:15:23 +01:00
Winni Neessen
06e37755f2
Some progress was made: 
- Implemented proper AUTH LOGIN mechanism
- Implemented msgWriter for handling io
- Implemented proper mail header formatting/output
- Minor refactoring
 2022-03-12 15:10:01 +01:00
Winni Neessen
5aebb12241
Calling it a day... 2022-03-11 19:17:43 +01:00
Winni Neessen
98d7982738
Calling it a day... 2022-03-10 16:56:41 +01:00
Winni Neessen
57ebb171c5
Lots of cleanups and refactoring 2022-03-10 16:19:51 +01:00
Winni Neessen
59a1d14ca7
Better context and connection handling 2022-03-10 12:10:27 +01:00
Winni Neessen
4babc309fb
Implemented SMTP AUTH 2022-03-10 10:53:38 +01:00
Winni Neessen
ba5f519d9d
Make GoLint happy 2022-03-09 17:05:38 +01:00
Winni Neessen
4b4c8065f6
Progress 2022-03-09 13:20:01 +01:00
Winni Neessen
82bb87ea4f
Calling it a day... 2022-03-07 18:14:38 +01:00
Winni Neessen
b3554a9578
Slow progress 2022-03-07 16:24:49 +01:00
Winni Neessen
2fcc0f59cd
Adding first tests 2022-03-06 15:15:42 +01:00
Winni Neessen
261481344f
Makeing some progress... 2022-03-05 16:27:09 +01:00
Winni Neessen
4dd9c1bf40
Let's get started... 2022-03-05 12:36:53 +01:00