wneessen/go-mail
1
1
Fork 0
mirror of https://github.com/wneessen/go-mail.git synced 2024-11-15 02:12:55 +01:00
Code Issues Projects Releases Packages Wiki Activity
1244 commits 3 branches 39 tags 9.8 MiB
Commit graph

36 commits

Author SHA1 Message Date
Winni Neessen
410343496c
Refactor and expand TestLoginAuth 
Rename and uncomment TestLoginAuth with more test cases, ensuring coverage for successful and failed authentication scenarios, including checks for unencrypted logins and server response errors. This improves test robustness and coverage.
 2024-11-07 21:14:52 +01:00
Winni Neessen
3cfd20576d
Rename and expand TestPlainAuth_noEnc with additional checks 
Refactor the test function `TestPlainAuth_noEnc` to include subtests for better organization and add more comprehensive error handling. This improves clarity and robustness by verifying various authentication scenarios and expected outcomes.
 2024-11-03 16:13:54 +01:00
Winni Neessen
99c4378107
Refactor and streamline authentication tests 
Improved the structure and readability of the authentication tests by using subtests for each scenario, ensuring better isolation and clearer failure reporting. Removed unnecessary imports and redundant code, reducing complexity and enhancing maintainability.
 2024-11-01 19:22:28 +01:00
Winni Neessen
8353b4b255
Follow upstream for HELO during Quit bug 
I reported the bug I fixed in 74fa3f6f62 to Go upstream. They fixed simpler by just ignoring the error (See: https://go.dev/cl/622476). We follow this patch accordingly. The upstream test has been adopted as well.
 2024-10-25 09:33:45 +02:00
Winni Neessen
df1a141368
Handle client close errors in SMTP tests 
Update defer statements to log errors if client fails to close in smtp_test.go. Additionally, add a return statement to avoid further errors after a failed SendMail operation.
 2024-10-22 16:02:43 +02:00
Winni Neessen
e2ed5b747a
Add tests for PlainAuth and LoginAuth without encryption 
Introduced new test functions TestAuthPlainNoEnc and TestAuthLoginNoEnc in smtp_test.go to verify behaviors of PlainAuth and LoginAuth without TLS encryption. These tests ensure that authentication mechanisms handle non-encrypted and diverse server configurations correctly.
 2024-10-22 15:50:18 +02:00
Winni Neessen
2bd950469a
Add 'skipTLS' parameter to auth functions in tests 
Updated PlainAuth and LoginAuth calls in smtp_test.go and example_test.go to include a 'skipTLS' boolean parameter. This ensures consistent function signatures throughout the test cases and examples.
 2024-10-22 15:44:40 +02:00
Winni Neessen
f120485c98
Correct typo in comment 
Fix a typo in smtp_test.go's comment from "challanges" to "challenges" to improve readability and accuracy of documentation. This change does not affect the code's functionality.
 2024-10-16 10:37:13 +02:00
Winni Neessen
3234c13277
Add tests for SetLogAuthData method 
Introduced TestClient_SetLogAuthData to verify the proper behavior of the SetLogAuthData method in both client and SMTP tests. This ensures that logAuthData is enabled or disabled as expected, increasing code reliability.
 2024-10-15 20:02:24 +02:00
Winni Neessen
476130d6e3
Fumpt files to make golangci-lint happy 2024-10-05 11:43:50 +02:00
Winni Neessen
159c1bf850
Add tests for new tls and connection handling methods 
This commit introduces tests for various TLS-related methods such as GetTLSConnectionState, HasConnection, SetDSNMailReturnOption, SetDSNRcptNotifyOption, and UpdateDeadline. It also modifies the error handling logic in smtp.go to include new error types and improves the mutex handling in UpdateDeadline.
 2024-10-05 10:55:25 +02:00
Winni Neessen
711ce2ac65
Add support for SCRAM-SHA-1-PLUS and SCRAM-SHA-256-PLUS 
Extended SMTP tests to include SCRAM-SHA-1-PLUS and SCRAM-SHA-256-PLUS authentication mechanisms. Adjusted the `startSMTPServer` function to accept a hashing function and modified the server logic to handle TLS channel binding.
 2024-10-04 18:31:58 +02:00
Winni Neessen
4c8c0d855e
Handle read errors in SMTP authentication flow 
Add checks to handle errors when reading client messages. This ensures that an appropriate error message is sent back to the client if reading fails, improving the robustness of the SMTP authentication process.
 2024-10-03 12:38:39 +02:00
Winni Neessen
03062c5183
Add SCRAM-SHA authentication tests for SMTP 
Introduce new unit tests to verify SCRAM-SHA-1 and SCRAM-SHA-256 authentication for the SMTP client. These tests cover both successful and failing authentication cases, and include a mock SMTP server to facilitate testing.
 2024-10-03 12:32:06 +02:00
Winni Neessen
a8e89a1258
Add support for SCRAM-SHA authentication mechanisms 
Introduced new test cases for SCRAM-SHA-1, SCRAM-SHA-256, and their PLUS variants in `smtp_test.go`. Updated the authTest structure to include a `hasNonce` flag and implemented logic to handle nonce validation and success message processing.
 2024-10-02 18:02:46 +02:00
Winni Neessen
93752280aa
Update smtp_test.go to add more authentication test cases 
Enhanced the LoginAuth test coverage by adding new scenarios with different sequences and invalid cases. This ensures more robust validation and better handling of edge cases in authentication testing.
 2024-10-02 12:54:32 +02:00
Winni Neessen
071ad66035
Sync with upstream 
This PR syncs our smtp package with the upstream `net/smtp` changes introduced via bf91eb3a8b
 2024-05-24 18:50:27 +02:00
Winni Neessen
07783d24e5
Update format string in Debugf method calls in tests 
The format string for the Debugf method calls within the smtp_test.go file have been updated. Previously, the format string was empty, but it has now been changed to "%s" to align with the standard formatting expectations, improving the correctness of the tests.
 2024-04-06 17:13:45 +02:00
Winni Neessen
7a549242ae
Update Go version and clean up SMTP test suite 
The Go version has been updated to 1.22 in the .golangci.toml file for compatibility reasons. Additionally, unnecessary white space has been removed from the smtp/smtp_test.go file to maximize code efficiency and readability.
 2024-02-08 16:51:25 +01:00
James Elliott
a73a914fb2
feat(smtp): auth login extension draft support 
This adds support for the auth login extension draft.
 2024-01-07 13:34:33 +11:00
Winni Neessen
1c5c1e318c
#136: Refactor logging for clearer messaging direction 
The logging system in the smtp.go and log package has been refactored. A new custom log type `Log` was introduced, that includes the message direction, format and arguments. The `Logger` interface and the `Stdlog` implementation were modified to accept this new type. This change provides a clearer understanding of message direction inside logs, allowing for easier debugging and reduced complexity. This change does not affect features or disrupt user functionality. Additionally, it allows for custom implementations of the log.Logger interface to without being forced to use the C --> S/C <-- S direction logging.
 2023-08-02 11:43:45 +02:00
Nicola Murino
61b9e59dd2 oauth2: add more test cases 2023-06-04 10:47:19 +02:00
Nicola Murino
8673addaf0 OAuth2: remove variants 
Microsoft also accept the same protocol used for Google servers
 2023-05-29 18:19:01 +02:00
Nicola Murino
6e4b348ccf add Oauth2 support 
fixes #129
 2023-05-28 14:31:04 +02:00
Winni Neessen
912797c782
#126: sync upstream changes to net/smtp 
Related: https://github.com/golang/go/issues/58141
Resolves #126
 2023-04-12 09:54:26 +02:00
Winni Neessen
13d0add21c
#121: Remove defer from for loops 
Fixes #121. `defer` in for loops can possibly lead to leaks.

The whole handling including the defer are now moved into anonymous functions outside the for loop and are called form the loop instead. This way the defer is handle when the inline function finishes
 2023-03-15 18:42:25 +01:00
Winni Neessen
6633591b51
Implement Logger interface 
As stated in https://github.com/wneessen/go-mail/pull/102#issuecomment-1411956040 it would be beneficial if, instead of forcing the Go stdlib logger on the user to provide a simple interface and use that for logging purposes.

This PR implements this simple log.Logger interface as well as a standard logger that satisfies this interface. If no custom logger is provided, the Stdlog will be used (which makes use of the Go stdlib again).

Accordingly, a `Client.WithLogger` and `Client.SetLogger` have been implemented. Same applies for the smtp counterparts.
 2023-02-03 10:19:26 +01:00
Winni Neessen
e36511e90e
Fix tests to not log authentication data 
We don't want to expose SMTP authentication details in tests, therefore the tests have been adjusted a bit
 2023-01-14 13:05:04 +01:00
Winni Neessen
34b432a985
Implement debug logging in SMTP client 
Resolves #101.

Since we now have full control over the SMTP client we can also access the message input and output.

This PR introduces a new debug logging feature. Via the `Client.WithDebugLog` the user can enable this feature. It will then make use of the new `smtp/Client.SetDebugLog` method. Once the flag is set to true, the SMTP client will start logging incoming and outgoing messages to os.Stderr.

Log directions will be output accordingly
 2023-01-14 12:47:51 +01:00
Winni Neessen
7cb34856a3
Adjusting license headers and including original LICENSE file from the Go project into the smtp/ directory as suggested in https://github.com/wneessen/go-mail/issues/97#issuecomment-1381046444 2023-01-13 16:54:55 +01:00
Winni Neessen
820d1c25d8
Fork net/smpt into go-mail 
Implemented negative check for AuthLogin Auth method
 2023-01-11 20:35:22 +01:00
Winni Neessen
df7bb9b742
Fork net/smpt into go-mail 
Fix open TODO in smtp_test.go and fork `testenv.SkipFlaky()` from `internal/testenv` to implement flaky test skipping for FBSD
 2023-01-11 20:07:03 +01:00
Winni Neessen
8e807c2569
Fork net/smpt into go-mail 
Fixed open issues in smtp_test.go
 2023-01-11 15:28:33 +01:00
Winni Neessen
1836f6c49d
Start fixing golangci-lint findings in test suite 2023-01-10 16:55:47 +01:00
Winni Neessen
a804e4a101
Fix license SPDX headers for forked net/smtp code 
- Also import the original BSD-3-Clause.txt license from the Go team into the LICENSES directory
- Further on, license headers should hold "The go-mail Authors" instead of my name. Did this already for the MIT license.
 2023-01-10 10:09:45 +01:00
Winni Neessen
0d6777ab39
Fork net/smpt into go-mail 
As part of #97 we are going to fork the official `net/smtp` package into go-mail to provide us with more flexibility.

This commit fulfills the first big step of importing the package into smtp/. Also go-mail's own LoginAuth has been moved from auth/ into smtp/ to be consistent with the stdlib.

There are still a couple of open issues (i. e. license adjustments and making golangci-lint happy) but so far all tests already work, which is a good start.
 2023-01-10 00:38:42 +01:00