wneessen/go-mail
1
1
Fork 0
mirror of https://github.com/wneessen/go-mail.git synced 2024-11-14 01:42:54 +01:00
Code Issues Projects Releases Packages Wiki Activity
407 commits 4 branches 39 tags 9.7 MiB
Commit graph

19 commits

Author SHA1 Message Date
Nicola Murino
6e4b348ccf add Oauth2 support 
fixes #129
 2023-05-28 14:31:04 +02:00
Winni Neessen
912797c782
#126: sync upstream changes to net/smtp 
Related: https://github.com/golang/go/issues/58141
Resolves #126
 2023-04-12 09:54:26 +02:00
Winni Neessen
13d0add21c
#121: Remove defer from for loops 
Fixes #121. `defer` in for loops can possibly lead to leaks.

The whole handling including the defer are now moved into anonymous functions outside the for loop and are called form the loop instead. This way the defer is handle when the inline function finishes
 2023-03-15 18:42:25 +01:00
Winni Neessen
44dce70c46
#119 make golangci-lint happy again 
Since we are Go <1.20 compatible, we can't easily combine errors here. The suggested golangci-lint fix will not work neither, since the %w verb can't be used twice. Therefore, for now we will ignore the linting error

Closes #119
 2023-03-11 10:48:14 +01:00
Winni Neessen
6633591b51
Implement Logger interface 
As stated in https://github.com/wneessen/go-mail/pull/102#issuecomment-1411956040 it would be beneficial if, instead of forcing the Go stdlib logger on the user to provide a simple interface and use that for logging purposes.

This PR implements this simple log.Logger interface as well as a standard logger that satisfies this interface. If no custom logger is provided, the Stdlog will be used (which makes use of the Go stdlib again).

Accordingly, a `Client.WithLogger` and `Client.SetLogger` have been implemented. Same applies for the smtp counterparts.
 2023-02-03 10:19:26 +01:00
Winni Neessen
63d8cef8ca
Refactor DSN handling from client.go to smtp.go 
This PR refactors the the DSN (RFC 1891) SMTP client handling, that was introduced in f4cdc61dd0.

While most of the Client options stay the same, the whole workaround logic for the SMTP client has been removed and added as part of the SMTP client instead.

This was we got rid of the Client's own `mail()`, `rcpt()`, `dsnRcpt()`, `dsnMail()` methods as well as the copies of the `cmd()` and `validateLine()` methods. The Client is now using the proper `Mail()` and `Rcpt()` methods of the SMTP client instead.
 2023-01-18 10:30:06 +01:00
Winni Neessen
3922d3f195
Switched copyright header from me to "The go-mail Authors" 2023-01-15 16:14:19 +01:00
Winni Neessen
ccbab59207
Fix log direction string 2023-01-14 13:07:42 +01:00
Winni Neessen
e36511e90e
Fix tests to not log authentication data 
We don't want to expose SMTP authentication details in tests, therefore the tests have been adjusted a bit
 2023-01-14 13:05:04 +01:00
Winni Neessen
34b432a985
Implement debug logging in SMTP client 
Resolves #101.

Since we now have full control over the SMTP client we can also access the message input and output.

This PR introduces a new debug logging feature. Via the `Client.WithDebugLog` the user can enable this feature. It will then make use of the new `smtp/Client.SetDebugLog` method. Once the flag is set to true, the SMTP client will start logging incoming and outgoing messages to os.Stderr.

Log directions will be output accordingly
 2023-01-14 12:47:51 +01:00
Winni Neessen
2950f222cf
Added backport comments as reference 2023-01-13 17:42:05 +01:00
Winni Neessen
8559e8c301
Re-introduce backwards compatibility with Go 1.17 and Go 1.18 
The following changes make use of methods that are not available in Go 1.17/Go 1.18. To guarantee at least 4 versions of backwards compatibility, versioned copies of those changes have been back-ported:
- 4d8db00641 (diff-4f6f6bdb9891d4dd271f9f31430420a2e44018fe4ee539576faf458bebb3cee4)
- 58158e990f (diff-772fc9f5d0c86f26e35158fb3e7a71a4967d18b4ec23a5dbb60781ab0babf426)
 2023-01-13 17:34:41 +01:00
Winni Neessen
7cb34856a3
Adjusting license headers and including original LICENSE file from the Go project into the smtp/ directory as suggested in https://github.com/wneessen/go-mail/issues/97#issuecomment-1381046444 2023-01-13 16:54:55 +01:00
Winni Neessen
820d1c25d8
Fork net/smpt into go-mail 
Implemented negative check for AuthLogin Auth method
 2023-01-11 20:35:22 +01:00
Winni Neessen
df7bb9b742
Fork net/smpt into go-mail 
Fix open TODO in smtp_test.go and fork `testenv.SkipFlaky()` from `internal/testenv` to implement flaky test skipping for FBSD
 2023-01-11 20:07:03 +01:00
Winni Neessen
8e807c2569
Fork net/smpt into go-mail 
Fixed open issues in smtp_test.go
 2023-01-11 15:28:33 +01:00
Winni Neessen
1836f6c49d
Start fixing golangci-lint findings in test suite 2023-01-10 16:55:47 +01:00
Winni Neessen
a804e4a101
Fix license SPDX headers for forked net/smtp code 
- Also import the original BSD-3-Clause.txt license from the Go team into the LICENSES directory
- Further on, license headers should hold "The go-mail Authors" instead of my name. Did this already for the MIT license.
 2023-01-10 10:09:45 +01:00
Winni Neessen
0d6777ab39
Fork net/smpt into go-mail 
As part of #97 we are going to fork the official `net/smtp` package into go-mail to provide us with more flexibility.

This commit fulfills the first big step of importing the package into smtp/. Also go-mail's own LoginAuth has been moved from auth/ into smtp/ to be consistent with the stdlib.

There are still a couple of open issues (i. e. license adjustments and making golangci-lint happy) but so far all tests already work, which is a good start.
 2023-01-10 00:38:42 +01:00