Commit graph

1305 commits

Author SHA1 Message Date
sters
e757327e1d
Adding WithDialContextFunc client option 2023-04-19 23:20:33 +09:00
3a528f1d81
Merge pull request #127 from wneessen/126-sync-upstream-changes-to-netsmtp
Sync upstream changes to net/smtp
2023-04-12 10:04:46 +02:00
912797c782
#126: sync upstream changes to net/smtp
Related: https://github.com/golang/go/issues/58141
Resolves #126
2023-04-12 09:54:26 +02:00
89fd5dfa06
Merge pull request #122 from wneessen/121-using-defer-inside-for-loop-could-lead-to-leaks
Remove defer from for loops
2023-03-15 18:51:58 +01:00
13d0add21c
#121: Remove defer from for loops
Fixes #121. `defer` in for loops can possibly lead to leaks.

The whole handling including the defer are now moved into anonymous functions outside the for loop and are called form the loop instead. This way the defer is handle when the inline function finishes
2023-03-15 18:42:25 +01:00
cb9bec4a6f
Merge pull request #120 from wneessen/fix/119_golangci-lint-returns-errors
Make golangci-lint happy again
2023-03-11 11:08:16 +01:00
44dce70c46
#119 make golangci-lint happy again
Since we are Go <1.20 compatible, we can't easily combine errors here. The suggested golangci-lint fix will not work neither, since the %w verb can't be used twice. Therefore, for now we will ignore the linting error

Closes #119
2023-03-11 10:48:14 +01:00
84bc888344
Merge pull request #118 from cvette/main
fix: parsing of ReplyTo with special characters
2023-03-07 11:01:50 +01:00
Christian Vette
20fe4cd751
fix: parsing of ReplyTo with special characters 2023-03-07 10:51:15 +01:00
d052289575
Merge pull request #117 from wneessen/feature/107_provide-more-ways-for-middleware-to-interact-with-mail-parts
Provide more ways for middleware to interact with mail parts
2023-02-13 11:41:57 +01:00
2c3309fce7
More test coverage for the added functionalities 2023-02-13 11:27:25 +01:00
900280a6cd
Test coverage for the added functionalities 2023-02-13 11:09:19 +01:00
f7e1345f3d
Merge branch 'main' into feature/107_provide-more-ways-for-middleware-to-interact-with-mail-parts 2023-02-03 15:18:43 +01:00
a119616357
Merge pull request #115 from wneessen/112-evaluate-using-a-logger-interface-instead-of-golang-stdlib-log-package
Implement Logger interface
2023-02-03 10:50:50 +01:00
14be29818d
Add REUSE header 2023-02-03 10:21:27 +01:00
6633591b51
Implement Logger interface
As stated in https://github.com/wneessen/go-mail/pull/102#issuecomment-1411956040 it would be beneficial if, instead of forcing the Go stdlib logger on the user to provide a simple interface and use that for logging purposes.

This PR implements this simple log.Logger interface as well as a standard logger that satisfies this interface. If no custom logger is provided, the Stdlog will be used (which makes use of the Go stdlib again).

Accordingly, a `Client.WithLogger` and `Client.SetLogger` have been implemented. Same applies for the smtp counterparts.
2023-02-03 10:19:26 +01:00
0a3917f8fe
Merge pull request #114 from wneessen/update-golangci-lint
Update golangci-lint to Go 1.20
2023-02-02 19:22:52 +01:00
169286e109
Update golangci-lint to Go 1.20 2023-02-02 19:10:16 +01:00
5ceede61b6
Merge pull request #113 from wneessen/go1.20-workflow-update
Go1.20 workflow updates
2023-02-02 10:48:21 +01:00
0dca1491db
Looks like golangci-lint does not support 1.20 yet 2023-02-02 10:26:11 +01:00
fa0d51ec80
GH seems to interpret 1.20 as 1.2. Let's try if a string works 2023-02-02 10:23:51 +01:00
f3119cd098
Added version compatibility statement 2023-02-02 10:18:59 +01:00
c5481d9059
Updated workflows to Go 1.20 2023-02-02 10:16:46 +01:00
fa0b9709f6
Correct method names in caveat comment 2023-01-31 21:57:10 +01:00
fe28247f9b
The additional multipart start/stop are not needed here 2023-01-31 21:54:32 +01:00
d33f0e8004
Merge branch 'main' into feature/107_provide-more-ways-for-middleware-to-interact-with-mail-parts 2023-01-31 20:47:36 +01:00
6953977d03
Merge pull request #111 from wneessen/fix/110_attachment-issues
Fix Attach/EmbedReader and implement Attach/EmbedReadSeeker
2023-01-31 20:46:47 +01:00
516b1f8ee2
Added test coverage for the specific bug in #110 and the newly added methods 2023-01-31 20:38:48 +01:00
dab860834a
Adding PGPType to Msg as preparation to support PGP/MIME in go-mail-middleware 2023-01-31 18:35:48 +01:00
c9794069cd
Add Caveat note about the io.Reader methods being memory inefficient 2023-01-31 17:48:19 +01:00
e66ad2be1a
Fix Attach/EmbedReader and implement Attach/EmbedReadSeeker
This PR addresses #110.
`Msg.AttachReader()` would not output the attached file after consecutive writes (e.g. a write to a file and then send via Client).

This PR fixes this behaviour by first reading the io.Reader into memory and then creating a new `bytes.Reader`, which does support seeking. In the writeFunc we then seek to position 0 after a successful `io.Copy`. This is probably not the most memory efficient way of handling this, but otherwise we'll have to break the `io.Reader` interface.

Additionally, a new way of attaching/embedding files has been added: `Msg.AttachReadSeeker()` and `Msg.EmbedReadSeeker()` which take a ´io.ReadSeeker` as argument instead. These two methods will skip the reading into memory and make use of the `Seek` method of the corresponding interface instead.
2023-01-31 17:38:31 +01:00
cfaeb51bef
Update README.md
Replaced discord channel
2023-01-29 14:52:43 +01:00
f2e0a9d63d
Merge pull request #109 from wneessen/feature/107_provide-more-ways-for-middleware-to-interact-with-mail-parts
Introduce GetEmbeds() and SetEmbeds()
2023-01-29 14:01:15 +01:00
25e00c64e2
Introduce GetEmbeds() and SetEmbeds()
These two methods work analogous to the `*Attachments()` methods and provide the user with access to the embedded files.
2023-01-29 13:48:51 +01:00
3c0f5d03d8
Merge pull request #108 from wneessen/feature/107_provide-more-ways-for-middleware-to-interact-with-mail-parts
Introducing Msg part deletion
2023-01-28 14:49:08 +01:00
c602ba103f
Test for message part deletion
Added a test for the `Part.Delete` method
2023-01-28 14:42:29 +01:00
9724a2b523
Introducing Msg part deletion
This PR introduces a new struct field for the message parts: `del`

If the del flag is set to `true`, the msgWriter will ignore this part during the writing process.

Additionally, the `part` has now a `Delete` method that lets the user mark the part as deleted

This allows middleware to take further control of the Msg and is part of #107
2023-01-28 14:39:14 +01:00
91bfed3f3d
Merge pull request #104 from wneessen/refactor_dsn_to_smtp
Refactor DSN handling from client.go to smtp.go
2023-01-18 10:39:21 +01:00
63d8cef8ca
Refactor DSN handling from client.go to smtp.go
This PR refactors the the DSN (RFC 1891) SMTP client handling, that was introduced in f4cdc61dd0.

While most of the Client options stay the same, the whole workaround logic for the SMTP client has been removed and added as part of the SMTP client instead.

This was we got rid of the Client's own `mail()`, `rcpt()`, `dsnRcpt()`, `dsnMail()` methods as well as the copies of the `cmd()` and `validateLine()` methods. The Client is now using the proper `Mail()` and `Rcpt()` methods of the SMTP client instead.
2023-01-18 10:30:06 +01:00
f48c8326ca
Added GPG key to SECURITY.md 2023-01-15 22:40:28 +01:00
e4eb4d63ee
Merge pull request #103 from wneessen/update_docs_headers
Update documentation and copyright headers
2023-01-15 16:22:36 +01:00
3922d3f195
Switched copyright header from me to "The go-mail Authors" 2023-01-15 16:14:19 +01:00
f4b836143c
Updated Security reporting information 2023-01-15 16:13:10 +01:00
23a4261e60
Added note about forked smtp package
Additionally added new feature references and updated contributors section
2023-01-15 16:12:33 +01:00
4c3416d078
Bump version to 0.3.9 2023-01-15 16:11:15 +01:00
f3039cdce9
Merge pull request #102 from wneessen/101-client-debug-logging
Implement SMTP client debug logging
2023-01-14 13:18:45 +01:00
ccbab59207
Fix log direction string 2023-01-14 13:07:42 +01:00
e36511e90e
Fix tests to not log authentication data
We don't want to expose SMTP authentication details in tests, therefore the tests have been adjusted a bit
2023-01-14 13:05:04 +01:00
34b432a985
Implement debug logging in SMTP client
Resolves #101.

Since we now have full control over the SMTP client we can also access the message input and output.

This PR introduces a new debug logging feature. Via the `Client.WithDebugLog` the user can enable this feature. It will then make use of the new `smtp/Client.SetDebugLog` method. Once the flag is set to true, the SMTP client will start logging incoming and outgoing messages to os.Stderr.

Log directions will be output accordingly
2023-01-14 12:47:51 +01:00
813020f02d
Merge pull request #100 from wneessen/feature/97_fork-the-netsmtp-package-from-stdlib-into-go-mail
Fork the net/smtp package from Go's stdlib into go-mail
2023-01-13 17:51:16 +01:00