wneessen/go-mail
1
1
Fork 0
mirror of https://github.com/wneessen/go-mail.git synced 2024-12-23 11:00:39 +01:00
Code Issues Projects Releases Packages Wiki Activity
864 commits 2 branches 39 tags 11 MiB
Commit graph

864 commits

This branch
This branch
All branches
Author SHA1 Message Date
Winni Neessen
3922d3f195
Switched copyright header from me to "The go-mail Authors" 2023-01-15 16:14:19 +01:00
Winni Neessen
f4b836143c
Updated Security reporting information 2023-01-15 16:13:10 +01:00
Winni Neessen
23a4261e60
Added note about forked smtp package 
Additionally added new feature references and updated contributors section
 2023-01-15 16:12:33 +01:00
Winni Neessen
4c3416d078
Bump version to 0.3.9 2023-01-15 16:11:15 +01:00
Winni Neessen
f3039cdce9
Merge pull request #102 from wneessen/101-client-debug-logging 
Implement SMTP client debug logging
 2023-01-14 13:18:45 +01:00
Winni Neessen
ccbab59207
Fix log direction string 2023-01-14 13:07:42 +01:00
Winni Neessen
e36511e90e
Fix tests to not log authentication data 
We don't want to expose SMTP authentication details in tests, therefore the tests have been adjusted a bit
 2023-01-14 13:05:04 +01:00
Winni Neessen
34b432a985
Implement debug logging in SMTP client 
Resolves #101.

Since we now have full control over the SMTP client we can also access the message input and output.

This PR introduces a new debug logging feature. Via the `Client.WithDebugLog` the user can enable this feature. It will then make use of the new `smtp/Client.SetDebugLog` method. Once the flag is set to true, the SMTP client will start logging incoming and outgoing messages to os.Stderr.

Log directions will be output accordingly
 2023-01-14 12:47:51 +01:00
Winni Neessen
813020f02d
Merge pull request #100 from wneessen/feature/97_fork-the-netsmtp-package-from-stdlib-into-go-mail 
Fork the net/smtp package from Go's stdlib into go-mail
 2023-01-13 17:51:16 +01:00
Winni Neessen
2950f222cf
Added backport comments as reference 2023-01-13 17:42:05 +01:00
Winni Neessen
8559e8c301
Re-introduce backwards compatibility with Go 1.17 and Go 1.18 
The following changes make use of methods that are not available in Go 1.17/Go 1.18. To guarantee at least 4 versions of backwards compatibility, versioned copies of those changes have been back-ported:
- 4d8db00641 (diff-4f6f6bdb9891d4dd271f9f31430420a2e44018fe4ee539576faf458bebb3cee4)
- 58158e990f (diff-772fc9f5d0c86f26e35158fb3e7a71a4967d18b4ec23a5dbb60781ab0babf426)
 2023-01-13 17:34:41 +01:00
Winni Neessen
7cb34856a3
Adjusting license headers and including original LICENSE file from the Go project into the smtp/ directory as suggested in https://github.com/wneessen/go-mail/issues/97#issuecomment-1381046444 2023-01-13 16:54:55 +01:00
Winni Neessen
f782f3f4fc
Merge branch 'main' into feature/97_fork-the-netsmtp-package-from-stdlib-into-go-mail 2023-01-12 01:31:36 +01:00
Winni Neessen
a7126b4201
Merge pull request #99 from wneessen/98-set-up-freebsd-tests-via-cirrus-ci 
Set up FreeBSD tests via CirrusCI
 2023-01-12 01:30:17 +01:00
Winni Neessen
09d7f1a4c4
#98 Set up FreeBSD tests via CirrusCI 
Since we skip the sendmail test, we don't need postfix anymore
 2023-01-12 01:22:45 +01:00
Winni Neessen
64dde76a58
#98 Set up FreeBSD tests via CirrusCI 
Cirrus seems to kill the sendmail test, let's make it skip-able
 2023-01-12 01:19:24 +01:00
Winni Neessen
433980a584
#98 Set up FreeBSD tests via CirrusCI 
Apparently we can't provide the secrets environment to CirrusCI, so we cannot perform the send tests
 2023-01-12 01:10:08 +01:00
Winni Neessen
d781217f07
#98 Set up FreeBSD tests via CirrusCI 
Cirrus does not understand the double {{}}
 2023-01-12 01:05:10 +01:00
Winni Neessen
2f053ed8ab
#98 Set up FreeBSD tests via CirrusCI 
Need to debug the test-host for cirrus
 2023-01-12 01:01:33 +01:00
Winni Neessen
4480a2bfa7
#98 Set up FreeBSD tests via CirrusCI 
The .. didn't do anything but fail
 2023-01-12 00:54:26 +01:00
Winni Neessen
4198664737
#98 Set up FreeBSD tests via CirrusCI 
We need the environment also it starts in auth/ which is weird
 2023-01-12 00:52:01 +01:00
Winni Neessen
570ccca98f
#98 Set up FreeBSD tests via CirrusCI 
Since we already used CirrusCI in the beginning, we only need to modify the existing file.
 2023-01-12 00:45:40 +01:00
Winni Neessen
820d1c25d8
Fork net/smpt into go-mail 
Implemented negative check for AuthLogin Auth method
 2023-01-11 20:35:22 +01:00
Winni Neessen
df7bb9b742
Fork net/smpt into go-mail 
Fix open TODO in smtp_test.go and fork `testenv.SkipFlaky()` from `internal/testenv` to implement flaky test skipping for FBSD
 2023-01-11 20:07:03 +01:00
Winni Neessen
8e807c2569
Fork net/smpt into go-mail 
Fixed open issues in smtp_test.go
 2023-01-11 15:28:33 +01:00
Winni Neessen
1836f6c49d
Start fixing golangci-lint findings in test suite 2023-01-10 16:55:47 +01:00
Winni Neessen
a804e4a101
Fix license SPDX headers for forked net/smtp code 
- Also import the original BSD-3-Clause.txt license from the Go team into the LICENSES directory
- Further on, license headers should hold "The go-mail Authors" instead of my name. Did this already for the MIT license.
 2023-01-10 10:09:45 +01:00
Winni Neessen
0d6777ab39
Fork net/smpt into go-mail 
As part of #97 we are going to fork the official `net/smtp` package into go-mail to provide us with more flexibility.

This commit fulfills the first big step of importing the package into smtp/. Also go-mail's own LoginAuth has been moved from auth/ into smtp/ to be consistent with the stdlib.

There are still a couple of open issues (i. e. license adjustments and making golangci-lint happy) but so far all tests already work, which is a good start.
 2023-01-10 00:38:42 +01:00
Winni Neessen
1e959a591d
Update doc.go 
Bump version to 0.3.8
 2023-01-07 11:58:11 +01:00
Winni Neessen
fb1d3197c8
Merge pull request #95 from wneessen/94-login-auth-next-handler-should-unconditionally-succeed-if-more-is-false 
Fix SMTP AUTH LOGIN method for servers with uncommon success messages
 2023-01-07 11:57:46 +01:00
Winni Neessen
39a9949e78
Fix auth_test.go accordingly 
Removed "2.7.0 Authentication successful" challenge since this should never be sent with `more == true`.
 2023-01-07 11:48:59 +01:00
Winni Neessen
862749f863
Fix SMTP AUTH LOGIN method for servers with uncommon success messages 
This fixes #94 and basically reverts d0f0435. As James points out correctly in #94, we should not assume specific responses from the server. As long as the spec is followed and the server returns the correct SMTP code, we should not do our own magic.

I've also extended the `getTestConnection` method in client_test.go, so that we can specify more test environment options like `TEST_PORT` and `TEST_TLS_SKIP_VERIFY`. This was needed for testing with the ProtonMail Bridge which listens on a different port and has non-trusted certificates.
 2023-01-07 11:31:46 +01:00
Winni Neessen
3b3c1e6e8d
Merge pull request #91 from wneessen/feature/90_provide-a-way-of-knowing-which-emails-failedsucceeded-in-sending 
Introduction of new error type for sending errors
 2023-01-03 11:22:32 +01:00
Winni Neessen
3d0939b597
Bump version to 0.3.7 for new release 2023-01-03 11:19:07 +01:00
Winni Neessen
5897bddd11
Update msg.go 
Co-authored-by: iwittkau <iwittkau@users.noreply.github.com>
 2023-01-02 22:29:10 +01:00
Winni Neessen
dbb596893d
Update msg.go 
Co-authored-by: iwittkau <iwittkau@users.noreply.github.com>
 2023-01-02 22:28:39 +01:00
Winni Neessen
b12b0bb363
Update client_test.go 
Co-authored-by: iwittkau <iwittkau@users.noreply.github.com>
 2023-01-02 22:22:31 +01:00
Winni Neessen
e6b73c2397
Update client_119.go 
Co-authored-by: iwittkau <iwittkau@users.noreply.github.com>
 2023-01-02 22:21:23 +01:00
Winni Neessen
8d86c3d8b2
Better test coverage for senderror.go 2023-01-02 21:55:37 +01:00
Winni Neessen
b8ee25f014
Simplify error return to make golangci-lint happy 2023-01-02 20:49:35 +01:00
Winni Neessen
8463f8524a
Fix merge conflict 2023-01-02 12:16:47 +01:00
Winni Neessen
b8af7a6ffc
Merge remote-tracking branch 'origin/feature/90_provide-a-way-of-knowing-which-emails-failedsucceeded-in-sending' into feature/90_provide-a-way-of-knowing-which-emails-failedsucceeded-in-sending 
# Conflicts:
#	senderror.go
 2023-01-02 12:15:39 +01:00
Winni Neessen
2c7ea3e532
More changes in regard to #90 
As proposed by @iwittkau the `SendError` type now has a `IsTemp()` method as well indicating to the user if the delivery error is retryable or not.

Since we want to use it in the error response from the Client functions like `Send` or `DialAndSend` we need to return the SendError type not only as part of the `*Msg` but also as return value for these methods. Hence, the changes made for #85 been overhauled to return the new error type instead. In the pre Go1.20 version of the `Send()` method we need to return an accumulated version of the SendError type, since we don't have `errors.Join()` and therefore, if more than one error occurred during the delivery we return an ambiguous error reason since we can't tell which of the captured errors is main error. For more details the user can always check the `*Msg.SendError`
 2023-01-02 12:14:14 +01:00
Winni Neessen
15b3a0028a
Fix/optimize isTempError method 
Not that this particular part of the code is performance critical, but I figured that the `strconv.Atoi()` is actually useless in here.

Since all we want to know is if the error code from the SMTP server is a 4xx error, we can just check the first rune of the returned error. The `Atoi` provides us with no advantage over the simple rune compare (except of taking about 3ns longer to execute)
 2023-01-01 20:35:21 +01:00
Winni Neessen
43efd6b3a8
Add missing REUSE header in senderror_test.go 2023-01-01 14:25:44 +01:00
Winni Neessen
f6709e90cd
Make golangci-lint happy by using errors.As instead of using type assertion on error (which can fail on wrapped errors) 2023-01-01 14:25:00 +01:00
Winni Neessen
78df991399
Proposal change for #90 
Did a complete overhaul of the senderror.go.

- the list of `errors.New()` has been replaced with constant itoa error reasons as `SendErrReason`. Instead, the `Error()` method now reports the corresponding error message based on the reason.
- The `SendError` received a `Is()` method so that we can use `errors.Is()` for very specific error checking. I.e. we can check for `&SendErrors{Reason: ErrSMTPMailFrom, isTemp: true}`. This provides much more flexibility in the error checking capabilities
- A `isTemp` field has been added to the `SendError` type, indicating whether the received error is temporary and can be retried or not. Accordingly, the `*Msg` now has a `SendErrorIsTemp()` method indicating the same. The decision is based on the first 3 characters returned from the SMTP server. If the error code is within the 4xx range, the error is seen as temporary
- A test for the SendError type has been added
 2023-01-01 14:20:13 +01:00
Winni Neessen
42a1fde51f
Fix missing REUSE license header in senderror.go 2022-12-31 12:47:20 +01:00
Winni Neessen
88eb4c5663
I think it's fair that we reset the Msg.senderror to nil before we Client.Send it. 
Since the send error indicate an error during the mail delivery, in my opinion it should be reset when a re-send is initiated, so that the senderror field always represents the latest delivery error. The send error should be checked after mail delivery and before a retry is started.
 2022-12-31 12:46:11 +01:00
Winni Neessen
47bff15de9
Introduction of a Msg error type as proposal for #90 
This PR introduces the `SendError` type which implements the error interface.

A new `senderror` field has been added to the `Msg` as well, so introduce this type to it.

I've also added different error variables that indicate the different things that can go wrong during mail delivery. These variables can be checked for, for each `Msg` using the `errors.As` method

The `Error()` method of `SendError` will return a detailed error string on why the `Msg` could not be delivered.

Additionally, `HasSendError()` and `SendError()` methods have been added to `Msg`. While `HasSendError()` simply returns a bool in case a `Msg` failed during delivery, the `SendError()` will return the full `SendError` error interface.
 2022-12-31 12:40:42 +01:00