142 commits

Author	SHA1	Message	Date
Winni Neessen	953a4b4df1	Add Bcc-related unit tests to msg_test.go ... Introduce comprehensive unit tests for Bcc functionalities, including validation of single and multiple addresses, various invalid input scenarios, and RFC5322 compliance checks. Additionally, implement tests for AddBcc, AddBccFormat, BccIgnoreInvalid, and BccFromString methods to ensure robust handling of different Bcc cases.	2024-10-26 18:29:51 +02:00
Winni Neessen	03cb09c3bd	Add tests for Cc, AddCc, AddCcFormat, CcIgnoreInvalid, and CcFromString ... This commit introduces comprehensive tests for various "Cc" related methods in the `Msg` struct. It includes test cases for valid and invalid email addresses for methods: `Cc`, `AddCc`, `AddCcFormat`, `CcIgnoreInvalid`, and `CcFromString`, ensuring robust handling of different scenarios and edge cases.	2024-10-26 18:22:01 +02:00
Winni Neessen	960c015a93	Remove IPv6 and IPv4 test cases from msg_test.go ... Removed test cases for IPv6 and IPv4 addresses from `msg_test.go` as they are no longer required. Also made a minor formatting adjustment to the `checkAddrHeader` function signature for better readability.	2024-10-26 15:45:01 +02:00
Winni Neessen	3a3eaed348	Refactor address header tests to use checkAddrHeader ... Consolidate repeated header validation logic into the `checkAddrHeader` helper function. This refactoring improves code readability and maintainability by reducing redundancy and potential for errors.	2024-10-26 02:07:44 +02:00
Winni Neessen	e08d36d0b8	Refactor address header validation in tests ... Replace repeated address header validation code with a helper function `checkAddrHeader` to reduce redundancy and improve readability. Also, add new test cases for `ToFromString` to handle valid addresses with and without empty fields.	2024-10-25 20:21:17 +02:00
Winni Neessen	03da20fc39	Add unit tests for Msg_ToIgnoreInvalid behavior ... Introduces new test cases to verify the Msg_ToIgnoreInvalid function handles various scenarios correctly. These tests check for behavior with valid addresses, invalid addresses, and a mix of both.	2024-10-25 19:43:05 +02:00
Winni Neessen	8b6a7927ef	Add dummy test function in msg_test.go ... Introduce a new, empty test function `TestMsg_ToIgnoreInvalid` in `msg_test.go` to accommodate future test cases. This commit also aligns a comment for better readability.	2024-10-25 17:43:59 +02:00
Winni Neessen	1ea7b173c6	Add tests for Msg.AddToFormat ... Introduced new test cases to validate Msg.AddToFormat functionality with both valid and invalid email addresses. Ensured proper error handling and address formatting in the message headers.	2024-10-25 17:16:46 +02:00
Winni Neessen	a7f81baa4b	Fix address references in tests and add AddTo functionality ... Corrected incorrect address references in the `msg_test.go` file. Added new tests to validate the AddTo functionality, ensuring multiple addresses can be added and validated properly.	2024-10-25 17:13:22 +02:00
Winni Neessen	cb85a136c3	Add Goland noinspection comments to suppress deprecation warnings ... This change adds `//goland:noinspection GoDeprecation` comments in the `msg_test.go` file. These comments suppress deprecation warnings for the `SetHeader` and `SetHeaderPreformatted` methods during test execution.	2024-10-25 17:05:22 +02:00
Winni Neessen	aa46b408ad	Add additional tests for From and To address handling ... Refactor "From" related tests to improve error messages and add tests for the new "FromFormat" function. Introduce new tests to validate the "To" address handling, covering various valid and invalid address scenarios.	2024-10-25 17:03:57 +02:00
Winni Neessen	5d85be068d	Add comprehensive tests for email "From" field validation ... Implemented extensive test cases for the "From" field in email messages, covering various valid and invalid email formats according to RFC5322. Verified correct handling for each scenario to ensure robustness of email address validation.	2024-10-25 16:36:34 +02:00
Winni Neessen	1caa2cfb92	Add tests for EnvelopeFrom and EnvelopeFromFormat methods ... Implemented comprehensive tests for the EnvelopeFrom and EnvelopeFromFormat methods to ensure proper handling of valid and invalid email addresses. This includes validation of both address and format for the "EnvelopeFrom" header.	2024-10-25 15:14:06 +02:00
Winni Neessen	c8dbc9a735	Update tests for SetAddrHeader and add new test cases ... Renamed existing test cases for clarity and added new test cases for SetAddrHeaderIgnoreInvalid function. The new tests cover multiple scenarios including valid/invalid addresses, and edge cases such as nil addrHeader map.	2024-10-25 15:00:53 +02:00
Winni Neessen	7d352bc58e	Add comprehensive tests for header and address methods ... Implemented extensive unit tests for setting various headers and address fields in the `Msg` struct, including setting general headers, preformatted headers, and address headers with various scenarios to ensure correctness and robustness.	2024-10-25 12:18:26 +02:00
Winni Neessen	a2e9dbae11	Add unit tests for charset and header setting in messages ... This commit introduces two new unit tests: `TestMsg_Charset` and `TestMsg_SetHeader`. These tests cover the functionality of setting and retrieving the character set and headers for messages, ensuring correctness and robustness.	2024-10-25 11:36:26 +02:00
Winni Neessen	1dba76948f	Simplify test descriptions in msg_test.go ... Shortened the test case descriptions for better clarity and readability. Added a new test function 'TestMsg_Encoding' to verify encoding outputs.	2024-10-25 11:24:35 +02:00
Winni Neessen	120c2efd08	Refactor test cases with shared test data ... Consolidated repetitive test data into shared variables to improve code maintainability and readability. This modification also helps in reducing redundancy and streamlining future updates to test data.	2024-10-25 11:18:09 +02:00
Winni Neessen	c4946af3ab	Refactor msg_test.go to streamline tests and reduce redundancy ... Reorganized and condensed test cases for the NewMsg method by merging individual tests and removing obsolete functions. This improves maintainability and reduces duplication in the test suite.	2024-10-25 11:08:11 +02:00
Winni Neessen	5874911c91	Simplify Message-ID generation ... Updated the SetMessageID method to generate a "Message-ID" using a single randomly generated string combined with the hostname, replacing the prior complex format that included process ID and multiple random numbers. This change simplifies the code of the generated IDs.	2024-10-07 15:04:04 +02:00
Winni Neessen	f5d4cdafea	Increase test iterations for SetMessageID randomness check ... Updated the TestMsg_SetMessageIDRandomness test to run 50,000 iterations instead of 100, ensuring a more robust evaluation of the Msg.SetMessageID method's randomness. Additionally, streamlined the retrieval of Message ID using GetMessageID.	2024-09-20 20:39:30 +02:00
Winni Neessen	69e211682c	Add GetMessageID method to Msg ... Introduced GetMessageID to retrieve the Message ID from the Msg	2024-09-19 11:46:53 +02:00
Alexander Setzer	7caf0b8e19	Fix typo / inconsistency for (*Msg).SetAttachments	2024-08-14 14:55:08 +02:00
Winni Neessen	b88b67e2c7	Add GetBoundary method and corresponding test ... The GetBoundary method has been added to the Msg struct in msg.go. Alongside this, a corresponding test method, TestMsg_GetBoundary, was introduced in msg_test.go to ensure the proper working of GetBoundary. This new method returns the boundary string of the Msg, which was previously inaccessible.	2024-07-02 10:58:13 +02:00
Winni Neessen	2e548512c6	Merge branch 'refs/heads/main' into feature/145_add-eml-parser-to-generate-msg-from-eml-files	2024-05-16 15:17:47 +02:00
Winni Neessen	dae7d80759	Add fuzzing tests for subject and from fields in msg_test.go ... Included two new fuzzing tests for 'Subject' and 'From' to increase code coverage and reliability. These tests expand our checking strategy by using dynamic inputs and making sure no unexpected errors occur when dealing with a variety of possible input scenarios.	2024-03-23 16:46:21 +01:00
Winni Neessen	19a3cf61ed	Refactor variable names for code readability ... Updated variable names in multiple files to enhance code readability and maintainability by replacing abbreviations with full descriptive names. This ensures adherence to the best practices of naming conventions in Go.	2024-02-27 11:21:28 +01:00
Winni Neessen	21d7b367bd	Update user agent test in msg_test.go ... Updated the test "check default user agent" in `msg_test.go` to reflect dynamic versioning. The wantUserAgent field now uses fmt.Sprintf to combine the go-mail version dynamically, improving the accuracy of testing.	2024-02-26 21:05:52 +01:00
Winni Neessen	180f6f3a63	Add a new test for no default user agent in msg_test.go ... A new test function named "TestNewMsgWithNoDefaultUserAgent" has been added in `msg_test.go` file. This function is meant to test 'NewMsg' function with 'WithNoDefaultUserAgent' parameter. The addition is devised to enhance the test coverage and ensure the noDefaultUserAgent field is functioning correctly.	2024-02-26 21:03:20 +01:00
grigorii	299490f8fa	Add an option to skip adding a User-Agent (tests)	2024-02-26 10:30:33 -08:00
Winni Neessen	f759b1b5fb	Merge branch 'main' into feature/145_add-eml-parser-to-generate-msg-from-eml-files	2024-02-08 17:04:06 +01:00
Winni Neessen	a864be059c	Add "X-Auto-Response-Suppress" header and update SetBulk method ... A new "X-Auto-Response-Suppress" header has been added. The SetBulk method has been updated to include this new header, as it is recommended for automated emails. This functionality is tested in the msg_test.go file.	2024-02-08 16:45:06 +01:00
Winni Neessen	8b19e497a0	Merge branch 'main' into feature/145_add-eml-parser-to-generate-msg-from-eml-files	2024-01-10 11:07:54 +01:00
rami	f445a55f7b	Fixed msg_test.go	2023-12-25 12:17:55 +01:00
Winni Neessen	a12d9c327f	Merge branch 'main' into feature/145_add-eml-parser-to-generate-msg-from-eml-files	2023-12-07 13:21:30 +01:00
Winni Neessen	6268077b99	Make golangci-lint happy ... Omitting nil redundant nil checks, as len() for []string is defined as zero	2023-11-30 09:14:31 +01:00
Winni Neessen	5dcbe712ae	Add null check to prevent empty file handle error in msg_test.go ... Implemented a null check to ensure the 'fi' file handle is not empty. With the absence of this check, the test was continuing even when 'fi' was empty, leading to null pointer exceptions further down in the code.	2023-11-29 17:47:30 +01:00
Winni Neessen	ddcad3710d	Fix potential null pointer exceptions in msg_test.go ... Added robustness and improved error handling in msg_test.go by adding null checks before calling values from the genHeader map in RequestMDNTo and related functions. This enhancement was necessary to avoid the operations on non-existing keys and potential null pointer exceptions.	2023-11-29 17:46:30 +01:00
Winni Neessen	fb17547e69	Improve error handling in msg.go ... Added additional checks when calling values from the genHeader map in msg.go file. This is to prevent trying to operate on non-existing keys, hence avoiding possible null pointer exceptions. The checks ensure the key HeaderMessageID exists in the genHeader map before attempting to operate on it. This is essential for functions like RequestMDNTo, RequestMDNToFormat, and RequestMDNAddToFormat, thereby improving the robustness of the code.	2023-11-29 17:40:31 +01:00
Winni Neessen	5a4f814061	Protect against key not found in genHeader map in msg.go ... Added checks to ensure the key HeaderMessageID exists in the genHeader map before attempting to operate on it in msg.go. This will prevent possible null pointer exceptions when trying to assign the key a value or append it to the mids slice.	2023-11-29 17:34:15 +01:00
Winni Neessen	fd313e23b6	Add checks for nil or empty Subject headers ... Added condition checks in `msg_test.go` for nil or empty Subject headers in the assigned functions. If the Subject is found to be nil or its length is less than 1, an empty string is now appended to prevent issues arising from null pointers or non-existent Subject headers in email messages.	2023-11-29 17:26:47 +01:00
Winni Neessen	1e447b5f2c	Merge branch 'main' into feature/145_add-eml-parser-to-generate-msg-from-eml-files	2023-11-10 18:23:52 +01:00
Winni Neessen	43c26a37e3	Updated mail.Address initialization in tests to make golangci-lint happy ... Tests for new mail address handling methods have been updated to use {Name:"", Address: "email@example.com"} format for initializing the []*mail.Address slices, instead of the previous shorthand {"", "email@example.com"}. This was done to increase code clarity and explicitness.	2023-11-10 18:14:44 +01:00
Winni Neessen	cc14864129	#152: Add new methods and tests for handling email addresses ... Added new methods `ToFromString()`, `CcFromString()` and `BccFromString()` in msg.go file to handle strings of comma-separated email addresses.	2023-11-10 18:07:56 +01:00
Winni Neessen	6bda5d1aaa	Merge branch 'main' into feature/145_add-eml-parser-to-generate-msg-from-eml-files	2023-10-20 14:23:24 +02:00
leahoop	3c2c106cb4	#147 add remove attachments and embeds methods	2023-10-20 10:21:03 +08:00
Winni Neessen	e7c717d0fc	"Rename Mime10 to MIME10 in codebase ... Renamed field 'Mime10' to 'MIME10' across multiple files for canonical representation and consistency with standard MIME naming format in the protocol."	2023-10-13 15:23:28 +02:00
Winni Neessen	438cfd60eb	Preparation for the v0.4.0 release: ... - Bump version in doc.go - Add sonarlint to .gitignore - Update README to reflect the changes and contributors - Fixed typos in auth_cram_md5_118.go, msg.go, msg_test.go, reader.go and smtp_ehlo_117.go	2023-05-31 09:34:45 +02:00
Winni Neessen	900280a6cd	Test coverage for the added functionalities	2023-02-13 11:09:19 +01:00
Winni Neessen	516b1f8ee2	Added test coverage for the specific bug in #110 and the newly added methods	2023-01-31 20:38:48 +01:00
Winni Neessen	25e00c64e2	Introduce GetEmbeds() and SetEmbeds() ... These two methods work analogous to the `*Attachments()` methods and provide the user with access to the embedded files.	2023-01-29 13:48:51 +01:00
Winni Neessen	3922d3f195	Switched copyright header from me to "The go-mail Authors"	2023-01-15 16:14:19 +01:00
Winni Neessen	2a228c5b08	Merge pull request #83 from wneessen/feature/80_add-getaddrheader ... #80: GetAddrHeader and SetGenHeader	2022-11-19 11:31:28 +01:00
Winni Neessen	17b9d2ccf6	#80: GetAddrHeader and SetGenHeader ... This PR introduces two major changes: * SetHeader and SetHeaderPreformatted have been deprecated in favour of SetGenHeader and SetGenHeaderPreformatted As pointed out in #80 the naming was pretty confusing, given that we already have SetAddrHeader. With the new naming convention it should be more clear. For compatibility reasons the old methods have been kept for now but in reality they are just aliases to the new methods * GetAddrHeader and GetAddrHeaderString have been introduced As requested in #80 analogous to GetGenHeader we also need a similar method for the address headers. Since address headers are *mail.Address pointer, we've also added a *String method that will extract the address string and return a string slice instead Additionally we're introducing methods for the actual address headers: GetTo, GetFrom, GetCc and GetBcc (with a *String counterpart as well). This way the user has full flexibility. Either they use the more "low-level" GetAddrHeader method or the higher level methods for the corresponding address type	2022-11-19 11:22:20 +01:00
Winni Neessen	47eb7b582b	#81: Fix error handling in body writer ... The error handling in the msgWriter.writeBody() method was not working properly. We basically overwrote the mw.err with nil if the function that followed after a failed write attempt was successful again This patch fixes #81	2022-11-19 09:55:38 +01:00
Winni Neessen	2e60d070a6	Add SetHeaderPreformatted() method ... With the SetHeaderPreformatted() method we have the ability to set headers that are already preformatted by the user and will not be altered in the mail message output	2022-10-26 15:33:03 +02:00
Winni Neessen	5bf0c10525	Randomness apparently not good enough for windows. Tests were failing. This fix improves it	2022-10-26 13:43:51 +02:00
Winni Neessen	021e003e78	Closes #74 ... This fix makes sure that generated message IDs via SetMessageID() are truly random and unique	2022-10-26 11:59:03 +02:00
Winni Neessen	2bd6851c78	Fix in the storage of the original Middleware	2022-10-25 16:56:40 +02:00
Winni Neessen	6f93e5835e	Introducing MiddlewareType and WriteToSkipMiddleware ... For middlewares to be able to access the fully written mail message, we need a way to execute WriteTo without the calling middleware to be handled, otherwise we end up in an infinite loop Therefore, this PR introduces the MiddlewareType and the corresponding change of the Middleware interface. We now require to return the MiddlewareType when the Type() method on the interface is called This way we can also introduce the WriteToSkipMiddleware method which takes a MiddlewareType as argument. This will allow us to use a WriteTo call with the initiating Middleware to be skipped	2022-10-25 16:42:18 +02:00
Winni Neessen	b6beeb5cae	Finalized the Reader type and removed the broken Read() method	2022-10-20 18:26:51 +02:00
Winni Neessen	5faa6dfbd6	We now return a Reader instead of the io.Reader interface	2022-10-20 18:03:57 +02:00
Dhia Gharsallaoui	b94a42ebe8	Expose Msg attachments fields	2022-10-12 13:36:52 +02:00
Winni Neessen	da130c0222	Added test for Msg.GetGenHeader	2022-10-02 12:30:08 +02:00
dhia gharsallaoui	a4733f0618	Implement middleware concept and their test	2022-09-22 18:05:47 +02:00
Winni Neessen	46001dc691	Added support for requesting MDNs as described in RFC 8098	2022-09-09 11:35:45 +02:00
Winni Neessen	333c3970e7	#42: Add test for Msg.EnvelopeFromFormat	2022-09-08 15:08:03 +02:00
Winni Neessen	192627f6a5	Closes #29: Allow attaching/embedding from embed.FS ... - Added `EmbedFromEmbedFS()` to allow embedding from embed.FS - Added `AttachFromEmbedFS()` to allow attaching from embed.FS - Added `fileFromEmbedFS()` as internal method for both other m methods to attach/embed the embed.FS file	2022-07-07 10:46:57 +02:00
Winni Neessen	31001e87b2	#24: Add SPDX license IDs for REUSE compliance ... # SUMMARY * Bad licenses: * Deprecated licenses: * Licenses without file extension: * Missing licenses: * Unused licenses: * Used licenses: CC0-1.0, MIT * Read errors: 0 * Files with copyright information: 45 / 45 * Files with license information: 45 / 45 Congratulations! Your project is compliant with version 3.0 of the REUSE Specification :-)	2022-06-17 15:05:54 +02:00
Winni Neessen	e5abcb082d	#21: Fix ineffassign for GoLinter	2022-06-13 10:33:50 +02:00
Winni Neessen	d0292e863f	#21: Added tests for Msg.EnvelopeFrom and Msg.GetSender changes	2022-06-13 10:27:54 +02:00
Winni Neessen	85bbf744fa	#18: Method renaming and tests ... - Renamed `Msg.WriteToTempfile` to `Msg.WriteToTempFile` - Added test coverage for `Msg.WriteToFile` and `Msg.WriteToTempFile`	2022-06-09 10:11:37 +02:00
Winni Neessen	7050414529	Added test coverage for #13	2022-06-03 12:03:20 +02:00
Winni Neessen	dd02ac229b	Closes #11 ... This PR adds a `Msg.Read()` method which satisfies the `io.Reader` interface	2022-05-28 10:58:19 +02:00
Winni Neessen	ebef1fe476	Fixes #8 ... We were using `io.Copy` to write to the body string/alternative string to the io.Writer. This placed the byte position of the buffer to be at the EOF after the first `WriteTo()` call leaving the output of a 2nd call to `WriteTo()` empty.	2022-05-27 12:47:33 +02:00
Winni Neessen	894ff7128c	Rename Write() to WriteTo() so it satisfies the io.WriteTo interface	2022-05-24 15:46:59 +02:00
Winni Neessen	663954f370	Fix typos in msg_test.go	2022-03-20 18:30:29 +01:00
Winni Neessen	d6dffc3071	More test coverage	2022-03-19 20:50:05 +01:00
Winni Neessen	a47f372a1a	More tests for all types of parts	2022-03-19 18:33:04 +01:00
Winni Neessen	429c9a1883	More tests for msg.go	2022-03-19 16:56:38 +01:00
Winni Neessen	7b5b4fa52b	Windows has no sendmail, so let's exclude those tests for Windows	2022-03-18 23:10:53 +01:00
Winni Neessen	d653cdc782	GH tests failed due to /usr/bin/true... probably /bin/echo will behave better	2022-03-18 23:01:29 +01:00
Winni Neessen	0e00b165f9	WriteToSendmailWithContext tests revealed a race condition which has been fixed	2022-03-18 22:23:03 +01:00
Winni Neessen	709b4e6b91	Switched write functions to return the number of bytes. Due to failing tests in Msg.Write()	2022-03-18 17:08:05 +01:00
Winni Neessen	e909bd5499	More tests. 50% overall coverage now	2022-03-18 15:05:33 +01:00
Winni Neessen	c698312133	More tests for msg.go. 69% coverage - nice!	2022-03-18 14:36:44 +01:00
Winni Neessen	106e9c4f28	More tests for msg.go. Finally over 50% coverage there	2022-03-18 12:12:40 +01:00
Winni Neessen	f8a9512462	More tests for msg.go	2022-03-18 11:47:50 +01:00
Winni Neessen	96dab9103c	Make Linter happy	2022-03-13 17:58:47 +01:00
Winni Neessen	a85b761f43	msg.go has almost full test coverage now	2022-03-13 11:31:33 +01:00
Winni Neessen	012303e5ac	Lots of tests and helpers added	2022-03-13 10:49:07 +01:00
Winni Neessen	7266155cf4	Added AddTo() and FromFormat()	2022-03-12 20:05:43 +01:00