105 commits

Author	SHA1	Message	Date
Winni Neessen	6ebc60d1df	Remove redundant nil check for SMTP client ... The removed check for a nil SMTP client was redundant because the previous error handling already covers this case. Streamlining this part of the code improves readability and reduces unnecessary checks.	2024-11-22 16:22:53 +01:00
Winni Neessen	7aba5212c4	Rename method and improve context handling ... Renamed `SMTPClientFromDialWithContext` to `DialToSMTPClientWithContext` for clarity and consistency. Updated method parameters and documentation to standardize context usage across the codebase.	2024-11-22 16:06:28 +01:00
Winni Neessen	4c107f4645	Refactor Client methods to handle smtp.Client parameter ... Updated several Client methods to accept a smtp.Client pointer, allowing for more flexible and explicit SMTP client management. Added detailed parameter descriptions and extended error handling documentation.	2024-11-22 15:55:45 +01:00
Winni Neessen	3553b65769	Add new Send function to client.go and remove duplicates ... The new Send function in client.go adds thread safety by using a mutex. This change also removes duplicate Send functions from client_119.go and client_120.go, consolidating the logic in one place for easier maintenance.	2024-11-22 15:38:04 +01:00
Winni Neessen	be4201b05a	Refactor debug logging and logger settings in Client ... Separated debug logging and logger setting methods to include SMTP client parameter for better encapsulation. Removed commented-out code for cleaner and more manageable codebase.	2024-11-22 15:29:22 +01:00
Winni Neessen	55884786be	Refactor SMTP client functions to improve modularity ... Refactor `DialWithContext` to delegate client creation to `SMTPClientFromDialWithContext`. Add new methods `SendWithSMTPClient`, `CloseWithSMTPClient`, and `ResetWithSMTPClient` to handle specific actions on `smtp.Client`. Simplify `auth`, `sendSingleMsg`, and `tls` methods by passing client as parameters.	2024-11-22 14:59:19 +01:00
Winni Neessen	1a579c2149	Add mutex for concurrent send protection ... Introduced a sendMutex to synchronize access to shared resources in the DialAndSendWithContext method. This ensures thread safety when sending multiple messages concurrently. Added a corresponding test to verify the concurrent sending functionality.	2024-11-21 10:26:48 +01:00
Winni Neessen	d8df26bbc8	Fix regression	2024-11-16 21:46:46 +01:00
Winni Neessen	427e8fd1ed	Format code block consistently ... Refactor the `preferList` definition in `client.go` for improved readability and consistency. This change ensures the code aligns with standard formatting practices.	2024-11-16 21:41:32 +01:00
Winni Neessen	6d3640a166	Fix auth type auto-discovery and add test cases ... Refactor the auth type initialization to prevent incorrect assignments and handle empty supported lists. Added comprehensive test cases to verify auto-discovery selection of the strongest authentication method and ensure robustness against empty or invalid input.	2024-11-16 21:38:29 +01:00
Winni Neessen	ac9117dc50	Add SMTP authentication auto-discovery ... Implemented a mechanism to automatically discover and select the strongest supported SMTP authentication type. This feature simplifies the authentication process for users and enhances security by prioritizing stronger mechanisms based on server capabilities. Corresponding tests and documentation have been updated.	2024-11-16 14:29:34 +01:00
Winni Neessen	6268acac44	Refactor error handling by renaming functions. ... Renamed `getErrorCode` to `errorCode` and `getEnhancedStatusCode` to `enhancedStatusCode` for consistency. Updated all references in `client.go` and `senderror.go` accordingly, improving readability and maintaining uniformity across the codebase.	2024-11-13 22:47:53 +01:00
Winni Neessen	6809084e80	Add enhanced status code and error code to SendError ... Enhance error handling by adding error code and enhanced status code to the SendError struct. This allows for better troubleshooting and debugging by providing more detailed SMTP server responses.	2024-11-13 16:11:28 +01:00
Alysson Ribeiro	8c4eb62360	Fix(close): Access to nil variable causes panic	2024-11-06 10:20:59 +01:00
Winni Neessen	42c63791ef	Move delivery status update after writer close check ... Relocated the `isDelivered` flag update to occur after the writer's close method validation. This ensures that the message delivery status is only marked as true if no errors arise during the writer close process. This showed up in the new test cases that covered errors on closing the DATA channel. This can already happen before the first byte is sent to the server. Therefore isDelivered should be set after a successful close.	2024-10-26 21:06:21 +02:00
Winni Neessen	45ebcb95b3	Remove redundant connection check in send function. ... The connection check is performed in the c.Reset call just before the c.checkconn call, making this redundant. Removing it simplifies the code and eliminates unnecessary error handling for connection status. This change helps improve code maintainability.	2024-10-24 12:02:57 +02:00
Winni Neessen	4a8ac76636	Add nil check for smtpClient in checkConn function ... Previously, if smtpClient was nil, the checkConn function would not handle that case. This update ensures that an appropriate error is returned when smtpClient is nil, enhancing the robustness of the client connection checks.	2024-10-24 10:44:40 +02:00
Winni Neessen	5e3ebcc1a6	Remove redundant connection check in auth function ... The checkConn call in the auth function was redundant because the connection is already managed appropriately elsewhere. Removing this unnecessary check simplifies the code and avoids potential duplication of error handling.	2024-10-24 10:12:57 +02:00
Winni Neessen	e442419c18	Remove redundant connection check in tls function ... The `tls` function in `client.go` no longer checks for an active connection before executing. This simplifies the code since the connection check is either redundant or already handled elsewhere in the flow.	2024-10-24 09:19:08 +02:00
Winni Neessen	3efd2b529f	Set fallbackPort to 0 in SetTLSPortPolicy ... The default fallback port should be reset to 0 when setting the TLS port policy. This ensures the fallbackPort does not retain an incorrect value when switching policies.	2024-10-23 14:39:28 +02:00
Winni Neessen	35f92f2ddc	Add error handling for nil DialContextFunc ... Introduce ErrDialContextFuncIsNil to handle cases where the dial context function is not provided. Update WithDialContextFunc to return this error when a nil function is passed.	2024-10-23 13:51:31 +02:00
Winni Neessen	1c8b2904f5	Add error check for nil SMTP authentication method ... Ensure that the SMTP authentication method is not nil by adding a corresponding error check in the WithSMTPAuthCustom function. Introduced a new error, ErrSMTPAuthMethodIsNil, to handle this validation.	2024-10-23 13:10:13 +02:00
Winni Neessen	3c29f68cc1	Add support for unsecured SMTP LOGIN auth ... Implemented an option to allow SMTP LOGIN authentication over unencrypted channels by introducing a new `SMTPAuthLoginNoEnc` type. Updated relevant functions and tests to handle the new parameter for unsecured authentication.	2024-10-22 15:38:51 +02:00
Winni Neessen	f5531eae14	Add support for PLAIN authentication without encryption ... Implemented a new SMTPAuthPlainNoEnc option to allow PLAIN authentication over unencrypted connections. Refactored the PlainAuth function to accept an additional allowUnencryptedAuth parameter. Updated relevant tests to cover the new authentication method.	2024-10-22 15:30:15 +02:00
Winni Neessen	e854b2192f	Merge pull request #335 from wneessen/bug/332_server-does-not-support-smtp-auth-error-when-using-localhost-in-v050 ... Add default SMTP authentication type to NewClient	2024-10-16 09:26:51 +02:00
Winni Neessen	0944296cff	Enable logging of SMTP authentication data ... Added a new option and methods to enable logging of SMTP authentication data. Updated documentation to indicate caution when using this feature due to potential data protection risks.	2024-10-15 19:52:59 +02:00
Winni Neessen	021666d6ad	#332: Add default SMTP authentication type to NewClient ... This commit fixes a regression introduced in v0.5.0. We now set the default SMTPAuthType to NOAUTH in NewClient. Enhanced documentation and added test cases for different SMTP authentication scenarios.	2024-10-11 11:21:56 +02:00
Winni Neessen	756269644e	Update SMTP client documentation with detailed descriptions ... Enhance the SMTP client method documentation by adding detailed explanations of the methods' purposes, parameters, return values, and operational flow. This improves clarity, making it easier for developers to understand the functionality and usage of each method.	2024-10-06 13:39:40 +02:00
Winni Neessen	d6426063ba	Refactor comments and docstrings for clarity and detail ... Enhanced comments and docstrings for better readability and detail in client.go and b64linebreaker.go. Updated descriptions, added parameter and return details, and included RFC references where applicable for improved documentation quality.	2024-10-06 12:39:02 +02:00
Winni Neessen	78e2857782	Update method comments to include additional context and RFC references ... Enhanced the comments for various methods in `msg.go`, `client.go`, `auth.go`, and `encoding.go` to provide more detailed explanations, context, and relevant RFC references. This improves the clarity and maintainability of the code by providing developers with a deeper understanding of each method's purpose and usage.	2024-10-05 13:39:21 +02:00
Winni Neessen	fbbf17acd0	Refactor comments for clarity in client.go ... Simplify comments in `client.go` to improve code documentation. Ensure comments are more descriptive and provide context for the functions they describe, enhancing code readability and maintainability.	2024-10-04 23:25:43 +02:00
Winni Neessen	48b469faf7	Refactor SMTP client comment and function documentation ... Updated function comments across client.go to improve clarity and consistency. Added missing details on error handling and context usage for `DialAndSendWithContext` and ensured all functions contain relevant, detailed descriptions.	2024-10-04 23:23:16 +02:00
Winni Neessen	adcb8ac41d	Fix connection handling and improve thread-safety in SMTP client ... Reset connections to nil after Close, add RLock in HasConnection, and refine Close logic to handle already closed connections gracefully. Enhanced DialWithContext documentation and added tests for double-close scenarios to ensure robustness.	2024-10-04 23:15:01 +02:00
Winni Neessen	dfdadc5da2	Refactor client.go: Move functions to new locations ... Reordered several functions within client.go for better code organization and readability. This change involves moving `setDefaultHelo`, `checkConn`, `serverFallbackAddr`, and `tls` functions to new locations without altering their implementations.	2024-10-04 22:38:18 +02:00
Winni Neessen	972a3c51c7	Add custom SMTP authentication type support ... Introduce the SMTPAuthCustom type to represent user-defined SMTP authentication mechanisms. Updated relevant functions in client.go to handle the new type appropriately and made sure the client distinguishes between built-in and custom authentication methods.	2024-10-04 22:33:42 +02:00
Winni Neessen	d900f5403e	Refine method documentation in client.go ... Correct typos and enhance clarity in method descriptions. Provide additional context for default values and behavior, and specify consequences for security settings in client configurations.	2024-10-04 22:23:18 +02:00
Winni Neessen	eeaee3f60a	Update and expand documentation for client configuration options ... Revised comments provide clearer guidance on the usage of various client configuration functions. Additional details and external references are included for better understanding and error handling.	2024-10-04 21:57:38 +02:00
Winni Neessen	bae0ac6cde	Refactor TLS policy comments for clarity ... Updated comments for WithTLSPolicy and WithTLSPortPolicy to provide clearer explanations. Improved readability and emphasized recommended best practices for SMTP TLS connections.	2024-10-04 21:45:12 +02:00
Winni Neessen	3e5c93a418	Refine and clarify SSL and debug logging comments ... Revised the comments for `WithSSLPort`, `WithDebugLog`, `WithLogger`, and `WithHELO` options to improve readability and provide clearer explanations. Added caution about potential data protection issues when using debug logging and specified defaults where applicable.	2024-10-04 21:38:39 +02:00
Winni Neessen	a34f400a05	Improve client option documentation for clarity and validation ... Enhanced the documentation for NewClient and related option functions to provide clearer descriptions. Added validation details for WithPort and WithTimeout, and improved explanations for SSL/TLS settings.	2024-10-04 21:26:29 +02:00
Winni Neessen	779a3f3942	Refactor error comments for clarity ... Updated error comments to provide clearer and more descriptive explanations. Enhanced readability by elaborating on the conditions that result in each error, giving developers better context. No functional changes to the code were made.	2024-10-04 21:12:05 +02:00
Winni Neessen	6cd3cfd2f7	Refactor comments for clarity and consistency ... Rephrase comments to enhance clarity and maintain consistent style. Improved explanations for fields such as `smtpAuth`, `helo`, and `noNoop`, and standardize grammar and format across all comments. This helps in better understanding the code and its functionality.	2024-10-04 20:57:51 +02:00
Winni Neessen	aab04672f8	Rename DSN type variable for clarity ... Renamed the variable from `dsnrntype` to `dsnRcptNotifyType` to improve code readability and ensure clarity regarding its purpose. Also updated corresponding comments and test cases to reflect this change.	2024-10-04 20:39:14 +02:00
Winni Neessen	f7c12d412b	Rename dsnmrtype to dsnReturnType in client.go ... Refactor variable names for consistency. The `dsnmrtype` variable has been renamed to `dsnReturnType` across the client and test files to improve code readability and maintain uniformity.	2024-10-04 20:30:43 +02:00
Winni Neessen	ef3da39840	Refactor DSN field in Client structure ... Renamed `dsn` field to `requestDSN` in Client structure for clarity and consistency. Adjusted associated methods and tests to reflect this change, improving code readability and maintainability.	2024-10-04 20:29:14 +02:00
Winni Neessen	92c411454b	Enhance comments with detailed explanations and links ... Improved comments for better clarity by detailing the purpose of each constant and type, and included relevant RFC links for deeper context. These changes aim to help developers quickly understand the code without needing to cross-reference external documents.	2024-10-04 20:13:13 +02:00
Winni Neessen	986a988c5d	Reset SMTP auth when setting SMTP auth type ... This change ensures that the smtpAuth field is reset to nil whenever the SMTP auth type is updated. This prevents potential issues with mismatched authentication settings.	2024-10-01 20:44:50 +02:00
Winni Neessen	15b9ddf067	Refactor error handling for non-TLS SMTP connections ... Introduce a global error variable for non-TLS connections and update corresponding error handling across the codebase. This enhances readability and maintainability of the error management logic.	2024-10-01 17:23:29 +02:00
Winni Neessen	8838414c38	Fix incorrect error types for unsupported SMTP authentication ... Corrects the error messages returned for unsupported SMTP authentication types from ErrXOauth2AuthNotSupported to specific errors like ErrSCRAMSHA1AuthNotSupported, ErrSCRAMSHA256AuthNotSupported, and so on. This change improves the accuracy of error reporting for various SMTP authentication mechanisms.	2024-10-01 17:00:57 +02:00
Winni Neessen	27838f5b1f	Improve TLS state handling and add SCRAM-SHA-256 auth support ... Replaced direct TLSConnectionState call with error handling for TLS state retrieval. Introduced SCRAM-SHA-256 support in the SMTP authentication process.	2024-10-01 15:28:10 +02:00