1342 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Winni Neessen	4fe9022815	Refactor RequestMDNAddTo ... Simplify the address handling for the "Disposition-Notification-To" header in msg.go. The code now directly reassigns the previously fetched addresses and ensures appending the new address effectively. This improves code readability and correctness in updating the header.	2024-10-26 22:13:37 +02:00
Winni Neessen	4f97cd8261	Initialize genHeader in RequestMDNTo method ... Add checks to initialize `genHeader` if it is nil in the RequestMDNTo method to prevent potential nil map assignment errors. The newly implemented tests showed that this method was never actually working and the old test was inefficient to identify this.	2024-10-26 21:33:43 +02:00
Winni Neessen	9e51dba82a	Add new tests for Msg methods ... Introduce tests for SetImportance, SetOrganization, SetUserAgent, and IsDelivered methods in the Msg type. These additions ensure the correct behavior and robustness of the email handling functionality.	2024-10-26 21:07:48 +02:00
Winni Neessen	cf117d320b	Add nil check in testMessage helper function ... Added a conditional check to ensure 'NewMsg()' does not return nil in the 'testMessage' helper function. This update will prevent potential nil pointer dereferences and improve the robustness of the test.	2024-10-26 21:07:04 +02:00
Winni Neessen	42c63791ef	Move delivery status update after writer close check ... Relocated the `isDelivered` flag update to occur after the writer's close method validation. This ensures that the message delivery status is only marked as true if no errors arise during the writer close process. This showed up in the new test cases that covered errors on closing the DATA channel. This can already happen before the first byte is sent to the server. Therefore isDelivered should be set after a successful close.	2024-10-26 21:06:21 +02:00
Winni Neessen	f5279cd584	Refactor character encoding test cases formatting ... Reformatted the test cases for European umlaut characters for consistency and readability. This change does not affect the execution or output of the tests.	2024-10-26 20:22:04 +02:00
Winni Neessen	ef3f103c30	Add additional tests for setting message headers ... Introduce tests for SetMessageIDWithValue, SetDate, and SetDateWithValue functions. Enhance coverage and validation for these methods by comparing generated headers and parsed dates.	2024-10-26 20:08:16 +02:00
Winni Neessen	ae15a12ce5	Refactor SetDate to use SetDateWithValue ... Replaces direct time formatting in SetDate with a call to SetDateWithValue, improving code reusability and readability. The new approach centralizes date formatting logic in one method.	2024-10-26 19:57:02 +02:00
Winni Neessen	ea5b02bfdd	Add tests for SetMessageID and GetMessageID methods ... Introduce unit tests to ensure SetMessageID generates unique IDs and GetMessageID correctly formats various input IDs. Additionally, verify GetMessageID returns an empty string when no ID is set.	2024-10-26 19:30:48 +02:00
Winni Neessen	591425bb99	Add test for European umlaut characters and remove others ... Added a test case for European umlaut characters in msg_test.go. Removed redundant test cases related to address handlers (To, Cc, Bcc) and other helper methods to streamline the code.	2024-10-26 19:10:25 +02:00
Winni Neessen	007286fc5e	Add unit tests for Msg.Subject() method ... Introduced unit tests to verify the encoding of different character sets in the Msg.Subject() method. Tests include cases for Latin characters, Japanese, Simplified Chinese, Cyrillic, and Emoji to ensure proper encoding handling.	2024-10-26 19:03:31 +02:00
Winni Neessen	5b602be818	Add tests for ReplyToFormat method ... Implement new tests for the Msg.ReplyToFormat method to ensure it correctly handles both valid and invalid email addresses. These tests validate the ReplyTo header formatting and error handling.	2024-10-26 18:46:46 +02:00
Winni Neessen	96d45c26bc	Add tests for Msg.ReplyTo function ... Introduce unit tests for the `ReplyTo` method in the `Msg` struct to validate both correct handling of valid email addresses and proper failure responses for invalid ones. Further, refactor and add helper functions to check generated headers in messages.	2024-10-26 18:40:53 +02:00
Winni Neessen	953a4b4df1	Add Bcc-related unit tests to msg_test.go ... Introduce comprehensive unit tests for Bcc functionalities, including validation of single and multiple addresses, various invalid input scenarios, and RFC5322 compliance checks. Additionally, implement tests for AddBcc, AddBccFormat, BccIgnoreInvalid, and BccFromString methods to ensure robust handling of different Bcc cases.	2024-10-26 18:29:51 +02:00
Winni Neessen	f079ea09eb	Improve BccFromString to handle spaces and empty addresses ... Trim spaces from email addresses and skip empty addresses in BccFromString method. This ensures that the BCC list only includes valid, non-empty email addresses, enhancing email sending reliability.	2024-10-26 18:29:26 +02:00
Winni Neessen	03cb09c3bd	Add tests for Cc, AddCc, AddCcFormat, CcIgnoreInvalid, and CcFromString ... This commit introduces comprehensive tests for various "Cc" related methods in the `Msg` struct. It includes test cases for valid and invalid email addresses for methods: `Cc`, `AddCc`, `AddCcFormat`, `CcIgnoreInvalid`, and `CcFromString`, ensuring robust handling of different scenarios and edge cases.	2024-10-26 18:22:01 +02:00
Winni Neessen	855d7f0867	Refine CcFromString to handle spaces and empty addresses. ... This change ensures that email addresses with leading or trailing spaces are trimmed, and empty addresses resulting from multiple commas are ignored. This helps prevent potential errors with malformed email addresses in the "Cc" field.	2024-10-26 18:21:50 +02:00
Winni Neessen	d7b32480fd	Handle test server connection timeouts ... Add logic to skip tests if there's a timeout error while connecting to the test server. This ensures that transient network issues do not cause test failures.	2024-10-26 17:33:52 +02:00
Winni Neessen	23399ed84c	Change DefaultHost to loopback address ... Updated DefaultHost from "localhost" to "127.0.0.1" in client_test.go. This change ensures consistent and direct communication with the local machine, avoiding potential issues with DNS resolution of "localhost".	2024-10-26 17:17:58 +02:00
Winni Neessen	90e3162a22	Update CI to support older Go versions ... Added Go 1.19 and 1.20 to the CI matrix to extend compatibility testing. This ensures that our project continues to work with these older versions of Go.	2024-10-26 17:11:21 +02:00
Winni Neessen	273a26ca53	Add tests for Go 1.21+ compatibility ... Moved some tests that use JSONlog (which requires Go 1.21+) to a separate file that is skipped on older Go versions.	2024-10-26 17:10:50 +02:00
Winni Neessen	a815c58571	Update CI workflow to install nullmailer instead of ssmtp ... Replacing ssmtp with nullmailer ensures better compatibility with the updated email delivery requirements. The DEBIAN_FRONTEND=noninteractive parameter was also added to avoid interactive prompts during installation.	2024-10-26 16:45:07 +02:00
Winni Neessen	c33900ca29	Add sudo to apt-get commands in CI workflow ... Previously, the apt-get commands lacked the necessary sudo prefix, which could lead to permission issues during the CI process. This change ensures that updates, upgrades, and installations are executed with the appropriate permissions.	2024-10-26 16:26:49 +02:00
Winni Neessen	4b8bf0507d	Update CI workflow and sendmail test condition ... Add the TEST_SENDMAIL environment variable for better control over sendmail tests. Optimize sendmail installation in CI by updating and installing ssmtp. Modify tests to check if TEST_SENDMAIL is set to "true" before running.	2024-10-26 16:25:42 +02:00
Winni Neessen	9072aef355	Remove support for Go 1.19 and 1.20 in CI workflow ... This commit updates the CI configuration to no longer test against Go versions 1.19 and 1.20. The supported Go versions are now 1.21, 1.22, and 1.23, ensuring the CI pipeline aligns with our current support policy.	2024-10-26 15:58:13 +02:00
Winni Neessen	3aef85e324	Add SPDX license headers to CI workflow file ... This change adds SPDX license headers to the .github/workflows/ci.yml file to ensure proper attribution and compliance with the MIT license. The added headers include copyright information and the applicable license type.	2024-10-26 15:57:27 +02:00
Winni Neessen	f82ac0c5ae	Update concurrency group names in GitHub Actions ... This change modifies the concurrency group names to include OS and Go version for better differentiation. This prevents conflicts and ensures that concurrent jobs are properly managed based on their specific matrices.	2024-10-26 15:52:27 +02:00
Winni Neessen	eeccee0d94	Add checkout step to CI workflow ... Ensure CI workflow has access to the latest code by adding a checkout step. This change is necessary for the golangci-lint action to function correctly with the most recent codebase.	2024-10-26 15:50:14 +02:00
Winni Neessen	9c57ba56cf	Add 'runs-on' directive to lint and govulncheck steps ... This ensures the lint and vulnerability check steps run on the 'ubuntu-latest' environment. Establishing a clear execution environment helps maintain consistency across CI runs.	2024-10-26 15:48:10 +02:00
Winni Neessen	4d4aa1e1df	Add runs-on parameter to dependency review job ... This change specifies that the dependency review job should run on the latest version of Ubuntu. It ensures consistency and clarity in the workflow configuration. This modification helps avoid potential issues related to unspecified runner environments.	2024-10-26 15:47:04 +02:00
Winni Neessen	960c015a93	Remove IPv6 and IPv4 test cases from msg_test.go ... Removed test cases for IPv6 and IPv4 addresses from `msg_test.go` as they are no longer required. Also made a minor formatting adjustment to the `checkAddrHeader` function signature for better readability.	2024-10-26 15:45:01 +02:00
Winni Neessen	12e9a0cb5d	Simplify CI workflow branch checks ... Removed file path filters on branch triggers in the CI workflow configuration. This allows the CI to run for any changes made in the main branch, ensuring broader test coverage and catching issues early.	2024-10-26 15:37:07 +02:00
Winni Neessen	9e6c1f0417	Consolidate CI workflows into a single file ... Merged separate workflows for Codecov, dependency-review, golangci-lint, govulncheck, offline-tests, reuse compliance, and SonarQube into a unified CI workflow file in `.github/workflows/ci.yml`. This restructuring simplifies our CI setup and ensures more consistent and efficient pipeline management.	2024-10-26 15:33:05 +02:00
Winni Neessen	0e9646e0e4	Merge branch 'main' into feature/overhaul-tests	2024-10-26 14:58:41 +02:00
Winni Neessen	3a3eaed348	Refactor address header tests to use checkAddrHeader ... Consolidate repeated header validation logic into the `checkAddrHeader` helper function. This refactoring improves code readability and maintainability by reducing redundancy and potential for errors.	2024-10-26 02:07:44 +02:00
Winni Neessen	e08d36d0b8	Refactor address header validation in tests ... Replace repeated address header validation code with a helper function `checkAddrHeader` to reduce redundancy and improve readability. Also, add new test cases for `ToFromString` to handle valid addresses with and without empty fields.	2024-10-25 20:21:17 +02:00
Winni Neessen	c99b6c3f14	Fix ToFromString to handle and trim empty addresses ... Previously, the ToFromString function split email addresses by commas but did not handle empty addresses or trim whitespace. Now, it trims each address and ignores any empty entries to ensure only valid addresses are processed. This prevents potential errors stemming from malformed input.	2024-10-25 19:54:41 +02:00
Winni Neessen	03da20fc39	Add unit tests for Msg_ToIgnoreInvalid behavior ... Introduces new test cases to verify the Msg_ToIgnoreInvalid function handles various scenarios correctly. These tests check for behavior with valid addresses, invalid addresses, and a mix of both.	2024-10-25 19:43:05 +02:00
Winni Neessen	8b6a7927ef	Add dummy test function in msg_test.go ... Introduce a new, empty test function `TestMsg_ToIgnoreInvalid` in `msg_test.go` to accommodate future test cases. This commit also aligns a comment for better readability.	2024-10-25 17:43:59 +02:00
Winni Neessen	1ea7b173c6	Add tests for Msg.AddToFormat ... Introduced new test cases to validate Msg.AddToFormat functionality with both valid and invalid email addresses. Ensured proper error handling and address formatting in the message headers.	2024-10-25 17:16:46 +02:00
Winni Neessen	a7f81baa4b	Fix address references in tests and add AddTo functionality ... Corrected incorrect address references in the `msg_test.go` file. Added new tests to validate the AddTo functionality, ensuring multiple addresses can be added and validated properly.	2024-10-25 17:13:22 +02:00
Winni Neessen	cb85a136c3	Add Goland noinspection comments to suppress deprecation warnings ... This change adds `//goland:noinspection GoDeprecation` comments in the `msg_test.go` file. These comments suppress deprecation warnings for the `SetHeader` and `SetHeaderPreformatted` methods during test execution.	2024-10-25 17:05:22 +02:00
Winni Neessen	aa46b408ad	Add additional tests for From and To address handling ... Refactor "From" related tests to improve error messages and add tests for the new "FromFormat" function. Introduce new tests to validate the "To" address handling, covering various valid and invalid address scenarios.	2024-10-25 17:03:57 +02:00
Winni Neessen	5d85be068d	Add comprehensive tests for email "From" field validation ... Implemented extensive test cases for the "From" field in email messages, covering various valid and invalid email formats according to RFC5322. Verified correct handling for each scenario to ensure robustness of email address validation.	2024-10-25 16:36:34 +02:00
Winni Neessen	c47f08dc7f	Merge pull request #346 from wneessen/dependabot/github_actions/actions/setup-go-5.1.0 ... Bump actions/setup-go from 5.0.2 to 5.1.0	2024-10-25 16:32:48 +02:00
dependabot[bot]	87c0575dd4	Bump actions/setup-go from 5.0.2 to 5.1.0 ... Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.0.2 to 5.1.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](0a12ed9d6a...41dfa10bad) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2024-10-25 13:39:33 +00:00
Winni Neessen	1caa2cfb92	Add tests for EnvelopeFrom and EnvelopeFromFormat methods ... Implemented comprehensive tests for the EnvelopeFrom and EnvelopeFromFormat methods to ensure proper handling of valid and invalid email addresses. This includes validation of both address and format for the "EnvelopeFrom" header.	2024-10-25 15:14:06 +02:00
Winni Neessen	c8dbc9a735	Update tests for SetAddrHeader and add new test cases ... Renamed existing test cases for clarity and added new test cases for SetAddrHeaderIgnoreInvalid function. The new tests cover multiple scenarios including valid/invalid addresses, and edge cases such as nil addrHeader map.	2024-10-25 15:00:53 +02:00
Winni Neessen	08fe44c051	Initialize address header map and enforce single 'From' address. ... This commit ensures that the address header map is properly initialized before assigning addresses to it. Additionally, it enforces the rule that only a single 'From' address is allowed, preventing multiple addresses from being set for the 'From' header. These misses were found while working on the enhanced testing suite	2024-10-25 14:57:36 +02:00
Winni Neessen	7d352bc58e	Add comprehensive tests for header and address methods ... Implemented extensive unit tests for setting various headers and address fields in the `Msg` struct, including setting general headers, preformatted headers, and address headers with various scenarios to ensure correctness and robustness.	2024-10-25 12:18:26 +02:00