wneessen/go-mail
1
1
Fork 0
mirror of https://github.com/wneessen/go-mail.git synced 2024-11-22 22:00:49 +01:00
Code Issues Projects Releases Packages Wiki Activity
735 commits 2 branches 39 tags 10 MiB
Commit graph

735 commits

This branch
This branch
All branches
Author SHA1 Message Date
Winni Neessen
d85c12220a
Refactor variable names in client_119.go 
Updated variable names in the client_119.go file to enhance readability and clarity. This observes best practices for naming conventions in Go, producing cleaner code that's easier to maintain and troubleshoot. Changes primarily consist of replacing abbreviations with full descriptive names.
 2024-02-27 11:10:49 +01:00
Winni Neessen
21d7b367bd
Update user agent test in msg_test.go 
Updated the test "check default user agent" in `msg_test.go` to reflect dynamic versioning. The wantUserAgent field now uses fmt.Sprintf to combine the go-mail version dynamically, improving the accuracy of testing.
 2024-02-26 21:05:52 +01:00
Winni Neessen
180f6f3a63
Add a new test for no default user agent in msg_test.go 
A new test function named "TestNewMsgWithNoDefaultUserAgent" has been added in `msg_test.go` file. This function is meant to test 'NewMsg' function with 'WithNoDefaultUserAgent' parameter. The addition is devised to enhance the test coverage and ensure the noDefaultUserAgent field is functioning correctly.
 2024-02-26 21:03:20 +01:00
Winni Neessen
c0cf31b6c4
Merge branch 'main' into feature/179_refactor-variable-names-for-readability 2024-02-26 20:57:37 +01:00
Winni Neessen
5c143cb74c
Merge pull request #178 from gegorov2030/no-default-user-agent 
Add an option to skip adding a User-Agent
 2024-02-26 20:56:50 +01:00
grigorii
299490f8fa Add an option to skip adding a User-Agent (tests) 2024-02-26 10:30:33 -08:00
Winni Neessen
b2f735854d
Refactor variable names for readability in reader.go 
Variable names in reader.go have been changed to be more expressive for improved readability. 'buf' and 'off' were renamed to 'buffer' and 'offset' respectively throughout the file. The changes also include corresponding adjustments in code comments and related test cases, contributing to consistent and understandable code.
 2024-02-26 00:56:29 +01:00
Winni Neessen
f18335fa1d
Refactor variable names in SMTP client code 
Improved variable names in the SMTP client code to make them more expressive and descriptive. Also corrected several code comments to enhance clarity. These changes are intended to increase code readability and maintainability and have been implemented throughout the client_119.go and client.go files for consistency in naming conventions.
 2024-02-25 17:48:53 +01:00
Winni Neessen
e1098091c3
Refactor variable names in SMTP client code 
The commit introduces improved variable names in the SMTP client code that are more expressive and better describe the function they perform. This is combined with corrections to some code comments. It's aimed to increase code readability and maintainability. Updates are made across the client_119.go and client.go files to ensure consistent naming conventions.
 2024-02-24 22:06:18 +01:00
Winni Neessen
12a145f612
Fix typos in comments in tls.go 
The comments within the tls.go file had multiple typographical errors which could have caused misunderstandings. These typos have been corrected to improve the clarity of the comments and maintain code understanding.
 2024-02-24 21:46:48 +01:00
Winni Neessen
d81dee95a8
Refactor variable and function names for improved clarity in b64linebreaker.go 
The existing variable and function names in the file have been updated for better readability. This change aids in code comprehension without affecting its functionality or logic. With accurately depicted names, the maintainability of the code is enhanced.
 2024-02-24 21:38:20 +01:00
Winni Neessen
c455b45a3e
Refactor variable and function names for improved clarity in msg.go 
The change updates various variable and function names in msg.go to make the code more intuitive. Updated names better capture what they represent or do, improving code readability and maintainability. This refactor does not impact functionality or logic of the code.
 2024-02-24 21:26:55 +01:00
Winni Neessen
4e880ab31c
Refactor variable and function names for improved clarity in msg.go 
The change updates various variable and function names in msg.go to make the code more intuitive. Updated names better capture what they represent or do, improving code readability and maintainability. This refactor does not impact functionality or logic of the code.
 2024-02-24 18:26:30 +01:00
Winni Neessen
c126670f70
Refactor variable and function names in msgWriter 
The commit includes changes such as renaming the variables `wbuf` to `buffer`, `cl` to `charLength` and functions `f` to `writeFunc` in msgWriter. This refactoring makes the code easier to read and understand. All the changes are aimed at enhancing code clarity without altering underlying logic or functionality.
 2024-02-24 17:38:42 +01:00
Winni Neessen
263f6bb3de
Refactor SMTP client code for better readability 
The variable names in the code related to the I/O of the SMTP client have been clarified for improved readability and comprehension. For example, unclear variable names like `d` and `w` have been replaced with more meaningful names like `depth` and `writer`. The same naming improvements have also been applied to function parameters. This update aims to enhance code maintenance and simplify future development processes.
 2024-02-24 12:43:01 +01:00
grigorii
a24906d185 Add an option to skip adding a User-Agent 2024-02-23 14:41:58 -08:00
Winni Neessen
4ec95adb30
Merge branch 'main' into feature/145_add-eml-parser-to-generate-msg-from-eml-files 2024-02-22 17:48:54 +01:00
Winni Neessen
68e6284e4e
Merge pull request #177 from wneessen/feature/176_noauth-smtpauth-type 
Update SMTP authentication mechanisms and related tests
 2024-02-22 15:49:16 +01:00
Winni Neessen
0cf9efcc69
Update SMTP authentication mechanisms and related tests 
Introduced the SMTPAuthNoAuth mechanism in the auth.go file meant for instances where authentication is not required or supported. Adjusted tests in client_test.go to account for this new mechanism. Minor order modifications were also made to the list of supported SMTP AUTH types and respective tests for better consistency.

Closes #176
 2024-02-22 15:24:19 +01:00
Winni Neessen
b957445489
Merge branch 'main' into feature/145_add-eml-parser-to-generate-msg-from-eml-files 2024-02-15 12:14:45 +01:00
Winni Neessen
56512b5bd9
Update doc.go 
Bump version to 0.4.1
 2024-02-14 16:12:13 +01:00
Winni Neessen
f5bbc558b2
Merge branch 'main' into feature/145_add-eml-parser-to-generate-msg-from-eml-files 2024-02-10 15:12:25 +01:00
Winni Neessen
93611e47a5
Merge pull request #174 from wneessen/go_122 
Update Go version in GitHub workflow files
 2024-02-10 15:09:20 +01:00
Winni Neessen
f01047855f
Update Go version in GitHub workflow files 
The Go version has been updated to '1.22' in the 'sonarqube.yml', 'golangci-lint.yml', and 'codecov.yml' GitHub action workflow files. This includes an additional modification for the Go versions matrix and condition statements in the 'codecov.yml' workflow.
 2024-02-10 14:14:34 +01:00
Winni Neessen
3facbde703
Add new content types and refactor message writer 
Introduced "multipart/mixed" and "multipart/related" content types in encoding.go and updated msgwriter.go to accommodate these. Adjustments made in related tests for these new types. Additionally, removed unnecessary print statements and improved multipart alternative parsing in eml.go.
 2024-02-10 13:36:42 +01:00
Winni Neessen
59e85809f7
Refactor multipart encoding handling and improve content parsing 
Refactored the processing of multipart encoding to be robust and easily maintainable. The changes include setting 'QP' encoding as default when the Content-Transfer-Encoding header is empty, accounting for the removal of this header by the standard Go multipart package. Also, parser functions for content type and charset are now independently handling the headers, replacing the split-string approach, thus improving efficiency and code readability.
 2024-02-10 13:22:38 +01:00
Winni Neessen
53566a93cd
Add content type, charset processing and refactor encoding process 
Extended the settings for content type and charset from headers. Also, refactored the handling of encoding types - 'QP' and 'B64' - within the mail header and body parsing sections. The process of handling encoding for plain type mail specifically is now encapsulated in a new function, parseEMLBodyPlain. These changes enhance code readability, maintainability, and error handling efficiency.
 2024-02-09 15:56:39 +01:00
Winni Neessen
4202f705a0
Refactor variable naming and multipart parse function in eml.go 
The variable names "mbbuf", "mt", and "par" have been renamed to "bodybuf", "mediatype", and "params" respectively, for clarification. Moreover, the multipart parsing block within the parseEMLBodyParts function was extracted into its own function, parseEMLMultipartAlternative, for improved code structure and readability.
 2024-02-09 12:34:11 +01:00
Winni Neessen
f759b1b5fb
Merge branch 'main' into feature/145_add-eml-parser-to-generate-msg-from-eml-files 2024-02-08 17:04:06 +01:00
Winni Neessen
94f53fe040
Merge pull request #173 from wneessen/ms-autoresponse-suppres 
Add "X-Auto-Response-Suppress" header and update SetBulk method
 2024-02-08 16:59:15 +01:00
Winni Neessen
7a549242ae
Update Go version and clean up SMTP test suite 
The Go version has been updated to 1.22 in the .golangci.toml file for compatibility reasons. Additionally, unnecessary white space has been removed from the smtp/smtp_test.go file to maximize code efficiency and readability.
 2024-02-08 16:51:25 +01:00
Winni Neessen
a864be059c
Add "X-Auto-Response-Suppress" header and update SetBulk method 
A new "X-Auto-Response-Suppress" header has been added. The SetBulk method has been updated to include this new header, as it is recommended for automated emails. This functionality is tested in the msg_test.go file.
 2024-02-08 16:45:06 +01:00
Winni Neessen
bda6b8c899
Merge branch 'main' into feature/145_add-eml-parser-to-generate-msg-from-eml-files 2024-02-05 13:00:21 +01:00
Winni Neessen
64a07399c4
Merge pull request #172 from wneessen/feature/171_implement-per-part-charsets 
Add Charset support for message parts
 2024-02-05 12:59:43 +01:00
Winni Neessen
2f60d9c5df
Add support for HTML alternative message body 
The code has been updated to allow for an HTML alternative to the plain text body in messages. This includes adding a new function to add this alternative body along with additional unit tests to ensure the multipart messages are properly constructed. The tests also check the correct usage of different charsets.
 2024-02-05 11:46:06 +01:00
Winni Neessen
68088577ba
Add charset related tests and functionality 
New unit tests have been introduced for WithPartCharset and SetCharset methods in part_test.go. Also, a GetCharset method has been implemented in part.go. These modifications ensure the robustness of charset handling within the application.
 2024-02-05 11:41:10 +01:00
Winni Neessen
ef86a1a1fb
Add Charset support for message parts 
Charset support has been added in the 'Part' struct. A 'SetCharset' method and a 'WithPartCharset' option have been added to override the default Part charset. The 'writePart' function in msgWriter now accommodates the charset defined at the Part level, defaulting to the previous functionality if not set.
 2024-01-31 16:28:41 +01:00
Winni Neessen
8da2abcf01
Merge branch 'main' into feature/145_add-eml-parser-to-generate-msg-from-eml-files 2024-01-31 11:35:32 +01:00
Winni Neessen
7dced4b056
Merge pull request #170 from wneessen/feature/105_enhance-default-tls-port 
Add default ports and fallback behavior for SSL and TLS
 2024-01-31 11:32:06 +01:00
Winni Neessen
1efac7fb67
Add new test cases for client functionalities and clean client code 
Test cases have been added for numerous client functionalities including WithTLSPortPolicy option for the NewClient method, Client.SetSSLPort method, and the Client.DialWithContext method with the fallback port functionality. Minor code simplification has also been performed in the 'SetSSLPort' function in client.go file.
 2024-01-31 11:22:01 +01:00
Winni Neessen
4a90c2de62
Add additional SSL and TLS tests in client_test.go 
Enhanced the unit tests in client_test.go by adding more test cases for SSL Port and TLS Port Policy. These additions contribute to more effective coverage of edge cases and increase the robustness of the test suite.
 2024-01-25 16:56:15 +01:00
Winni Neessen
80893bd27a
Merge branch 'main' into feature/105_enhance-default-tls-port 2024-01-25 14:03:43 +01:00
Winni Neessen
1c39dc8cf8
Upgrade codecov-action to v3 in GitHub workflow 
The codecov-action version used in the GitHub workflow file has been upgraded from v2 to v3. This enhances the reliability and performance by leveraging the new features and improvements available in version 3. This commit doesn't affect the functionality of the project but is more of a dependency update.
 2024-01-25 14:03:19 +01:00
Winni Neessen
7a2d9ff938
#105: Add default ports and fallback behavior for SSL and TLS 
Introduced default ports for SSL/TLS and STARTTLS connections in SMTP client. Also added fallback behavior, allowing the client to attempt connections on port 25 using plaintext if secured connections fail. Deprecated old methods and implemented new ones to enforce these changes effectively.

This is a copy of the PR muhlemmer:enhance-default-tls-port by @muhlemmer. Since they unfortunately didn't reply in the PR anymore I cloned the PR. They will be fully attributed in the PR, though.
 2024-01-25 13:39:02 +01:00
Winni Neessen
f7ba3a1d02
Merge branch 'main' into feature/145_add-eml-parser-to-generate-msg-from-eml-files 2024-01-25 11:21:38 +01:00
Winni Neessen
161381d880
Merge pull request #169 from wneessen/update_cirrusci 
Update FreeBSD version in .cirrus.yml
 2024-01-23 12:37:13 +01:00
Winni Neessen
697584b311
Update FreeBSD version in .cirrus.yml 
The FreeBSD version used for testing in .cirrus.yml has been updated from 12.4 to 14.0. This change ensures that the tests run on the latest stable version of the operating system, providing more reliable and up-to-date test results.
 2024-01-23 12:31:30 +01:00
Winni Neessen
99dd296486
Merge pull request #167 from wneessen/feature/166_no-easy-way-to-determine-if-e-mail-was-send 
Add delivery status indication for messages
 2024-01-23 11:44:45 +01:00
Winni Neessen
6746af4605
Update client tests for message delivery indication 
This commit adds checks in the testing functions to verify the successful implementation of message delivery status. A new attribute `isDelivered` is now being validated in our tests, reinforcing the message tracking system and enhancing the overall reliability of our application.
 2024-01-23 11:21:56 +01:00
Winni Neessen
0b622368ba
#166: Add delivery status indication for messages 
This update introduces a new property, `isDelivered`, in the message struct to track if a message has been successfully sent or not. Additionally, this also includes a new helper function `IsDelivered` to easily retrieve the status. This feature enhances the tracking capabilities of outgoing messages across different client files.
 2024-01-23 11:01:08 +01:00