700 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Winni Neessen	68088577ba	Add charset related tests and functionality ... New unit tests have been introduced for WithPartCharset and SetCharset methods in part_test.go. Also, a GetCharset method has been implemented in part.go. These modifications ensure the robustness of charset handling within the application.	2024-02-05 11:41:10 +01:00
Winni Neessen	ef86a1a1fb	Add Charset support for message parts ... Charset support has been added in the 'Part' struct. A 'SetCharset' method and a 'WithPartCharset' option have been added to override the default Part charset. The 'writePart' function in msgWriter now accommodates the charset defined at the Part level, defaulting to the previous functionality if not set.	2024-01-31 16:28:41 +01:00
Winni Neessen	8da2abcf01	Merge branch 'main' into feature/145_add-eml-parser-to-generate-msg-from-eml-files	2024-01-31 11:35:32 +01:00
Winni Neessen	7dced4b056	Merge pull request #170 from wneessen/feature/105_enhance-default-tls-port ... Add default ports and fallback behavior for SSL and TLS	2024-01-31 11:32:06 +01:00
Winni Neessen	1efac7fb67	Add new test cases for client functionalities and clean client code ... Test cases have been added for numerous client functionalities including WithTLSPortPolicy option for the NewClient method, Client.SetSSLPort method, and the Client.DialWithContext method with the fallback port functionality. Minor code simplification has also been performed in the 'SetSSLPort' function in client.go file.	2024-01-31 11:22:01 +01:00
Winni Neessen	4a90c2de62	Add additional SSL and TLS tests in client_test.go ... Enhanced the unit tests in client_test.go by adding more test cases for SSL Port and TLS Port Policy. These additions contribute to more effective coverage of edge cases and increase the robustness of the test suite.	2024-01-25 16:56:15 +01:00
Winni Neessen	80893bd27a	Merge branch 'main' into feature/105_enhance-default-tls-port	2024-01-25 14:03:43 +01:00
Winni Neessen	1c39dc8cf8	Upgrade codecov-action to v3 in GitHub workflow ... The codecov-action version used in the GitHub workflow file has been upgraded from v2 to v3. This enhances the reliability and performance by leveraging the new features and improvements available in version 3. This commit doesn't affect the functionality of the project but is more of a dependency update.	2024-01-25 14:03:19 +01:00
Winni Neessen	7a2d9ff938	#105: Add default ports and fallback behavior for SSL and TLS ... Introduced default ports for SSL/TLS and STARTTLS connections in SMTP client. Also added fallback behavior, allowing the client to attempt connections on port 25 using plaintext if secured connections fail. Deprecated old methods and implemented new ones to enforce these changes effectively. This is a copy of the PR muhlemmer:enhance-default-tls-port by @muhlemmer. Since they unfortunately didn't reply in the PR anymore I cloned the PR. They will be fully attributed in the PR, though.	2024-01-25 13:39:02 +01:00
Winni Neessen	f7ba3a1d02	Merge branch 'main' into feature/145_add-eml-parser-to-generate-msg-from-eml-files	2024-01-25 11:21:38 +01:00
Winni Neessen	161381d880	Merge pull request #169 from wneessen/update_cirrusci ... Update FreeBSD version in .cirrus.yml	2024-01-23 12:37:13 +01:00
Winni Neessen	697584b311	Update FreeBSD version in .cirrus.yml ... The FreeBSD version used for testing in .cirrus.yml has been updated from 12.4 to 14.0. This change ensures that the tests run on the latest stable version of the operating system, providing more reliable and up-to-date test results.	2024-01-23 12:31:30 +01:00
Winni Neessen	99dd296486	Merge pull request #167 from wneessen/feature/166_no-easy-way-to-determine-if-e-mail-was-send ... Add delivery status indication for messages	2024-01-23 11:44:45 +01:00
Winni Neessen	6746af4605	Update client tests for message delivery indication ... This commit adds checks in the testing functions to verify the successful implementation of message delivery status. A new attribute `isDelivered` is now being validated in our tests, reinforcing the message tracking system and enhancing the overall reliability of our application.	2024-01-23 11:21:56 +01:00
Winni Neessen	0b622368ba	#166: Add delivery status indication for messages ... This update introduces a new property, `isDelivered`, in the message struct to track if a message has been successfully sent or not. Additionally, this also includes a new helper function `IsDelivered` to easily retrieve the status. This feature enhances the tracking capabilities of outgoing messages across different client files.	2024-01-23 11:01:08 +01:00
Winni Neessen	60222c95e7	Add multipart message parsing in eml.go ... This commit introduces the ability to handle multipart messages within the eml.go file. It reads individual parts of multipart messages, sets the encoding and content for each part, and implements error handling for potential issues like a missing boundary tag or difficulties acquiring the next part of a multipart message.	2024-01-22 17:49:58 +01:00
Winni Neessen	0d9ba278fe	Update common content types in encoding.go ... The list of common content types in encoding.go has been revised. The type "multipart/alternative" has been added and the order of types has been adjusted for consistency with net/smtp upstream.	2024-01-22 17:48:49 +01:00
Winni Neessen	8b19e497a0	Merge branch 'main' into feature/145_add-eml-parser-to-generate-msg-from-eml-files	2024-01-10 11:07:54 +01:00
Winni Neessen	e4927fde82	Merge pull request #165 from wneessen/sync-net-smtp-upstream ... Upstream sync / refine function comments to include return type GoDoc links	2024-01-10 11:06:57 +01:00
Winni Neessen	5dbb1e6dde	Refine function comments to include return type details ... This is a sync with the net/smtp upstream as committed here: 1d45a7ef56 (diff-4f6f6bdb9891d4dd271f9f31430420a2e44018fe4ee539576faf458bebb3cee4).	2024-01-10 11:05:34 +01:00
Winni Neessen	01e5deb357	Merge pull request #163 from james-d-elliott/feat-auth-login-x-draft ... feat(smtp): auth login extension draft support	2024-01-07 11:30:09 +01:00
James Elliott	a73a914fb2	feat(smtp): auth login extension draft support ... This adds support for the auth login extension draft.	2024-01-07 13:34:33 +11:00
Winni Neessen	6cb8290e13	Merge pull request #161 from rami-dabain/main ... Added return error to `fileFromReader`	2023-12-25 14:23:29 +01:00
rami	f445a55f7b	Fixed msg_test.go	2023-12-25 12:17:55 +01:00
rami	bd6250a8c2	Added return error to fileFromReader	2023-12-24 17:04:55 +01:00
Winni Neessen	a12d9c327f	Merge branch 'main' into feature/145_add-eml-parser-to-generate-msg-from-eml-files	2023-12-07 13:21:30 +01:00
Winni Neessen	d5b410dca4	Merge pull request #157 from wneessen/nil_checks ... Eleminate potential null pointer exceptions	2023-11-30 10:02:13 +01:00
Winni Neessen	6268077b99	Make golangci-lint happy ... Omitting nil redundant nil checks, as len() for []string is defined as zero	2023-11-30 09:14:31 +01:00
Winni Neessen	5dcbe712ae	Add null check to prevent empty file handle error in msg_test.go ... Implemented a null check to ensure the 'fi' file handle is not empty. With the absence of this check, the test was continuing even when 'fi' was empty, leading to null pointer exceptions further down in the code.	2023-11-29 17:47:30 +01:00
Winni Neessen	ddcad3710d	Fix potential null pointer exceptions in msg_test.go ... Added robustness and improved error handling in msg_test.go by adding null checks before calling values from the genHeader map in RequestMDNTo and related functions. This enhancement was necessary to avoid the operations on non-existing keys and potential null pointer exceptions.	2023-11-29 17:46:30 +01:00
Winni Neessen	fb17547e69	Improve error handling in msg.go ... Added additional checks when calling values from the genHeader map in msg.go file. This is to prevent trying to operate on non-existing keys, hence avoiding possible null pointer exceptions. The checks ensure the key HeaderMessageID exists in the genHeader map before attempting to operate on it. This is essential for functions like RequestMDNTo, RequestMDNToFormat, and RequestMDNAddToFormat, thereby improving the robustness of the code.	2023-11-29 17:40:31 +01:00
Winni Neessen	5a4f814061	Protect against key not found in genHeader map in msg.go ... Added checks to ensure the key HeaderMessageID exists in the genHeader map before attempting to operate on it in msg.go. This will prevent possible null pointer exceptions when trying to assign the key a value or append it to the mids slice.	2023-11-29 17:34:15 +01:00
Winni Neessen	da21550dc9	Fix potential null pointer exceptions in msg.go ... This commit adds conditions in msg.go file to check if the header 'HeaderDispositionNotificationTo' key exists in the map 'm.genHeader' before trying to associate it with a value. This prevents potential null pointer exceptions.	2023-11-29 17:26:58 +01:00
Winni Neessen	fd313e23b6	Add checks for nil or empty Subject headers ... Added condition checks in `msg_test.go` for nil or empty Subject headers in the assigned functions. If the Subject is found to be nil or its length is less than 1, an empty string is now appended to prevent issues arising from null pointers or non-existent Subject headers in email messages.	2023-11-29 17:26:47 +01:00
Winni Neessen	81306e4dd3	Fix null pointer exception in Is function ... Updated the Is function in senderror.go to handle null values for SendError. This was done by adding a nil-check for surfaced pointer errors in the errors.As call. This prevents the function from attempting to derive values from a null pointer and consequently prevents null pointer exceptions from being thrown.	2023-11-29 17:20:09 +01:00
Winni Neessen	b79374224c	Handle nil buffer in Reader and update tests ... Updated the Reader struct in reader.go to properly handle nil buffers. This prevents potential errors from nil pointer dereference. Also added the fmt package for debugging purposes. Correspondingly, additional tests in reader_test.go were also added to cover these edge cases and ensure the Reader struct correctly handles them.	2023-11-29 17:18:55 +01:00
Winni Neessen	b63d4803f1	Refactored null checks in msgwriter.go ... Extended null check conditions in msgwriter.go to prevent potential nil pointer dereference. This change ensures robustness in error handling in scenarios where FROM header or envelope FROM is either not existent or nil.	2023-11-29 16:56:32 +01:00
Winni Neessen	ca896bd641	Refactor error checking in msg.SendErrorIsTemp() ... Added an additional condition in the SendErrorIsTemp function within msg.go to ensure that the error e is not nil before referencing it. This guards against potential runtime panics from dereferencing a nil pointer, enhancing robustness of error handling.	2023-11-29 16:45:25 +01:00
Winni Neessen	a50a3ceb18	Add validation for nil STDERR or STDIN pipe ... Introduced a new condition that checks and returns an error if either STDERR or STDIN pipe is nil in the msg function of msg.go. This improves error handling by preventing potential panic due to referencing a nil pipe.	2023-11-29 16:43:50 +01:00
Winni Neessen	1a166770b7	Update range loop to improve msg function readability ... Converted the range loop in the GetAddrHeaderString function in msg.go to use value semantics rather than index notation. This improves code clarity by not unnecessarily referring to m.addrHeader[h] in the loop and instead referencing the value directly (using variable mh), making it easier to understand and maintain.	2023-11-29 16:42:07 +01:00
Winni Neessen	bb18ef9e93	"Improve error checking in SMTP client creation" ... A change was made in the SMTP client creation process to add more robust error handling. The new logic checks if the client is null after being created and, if true, returns an error. This update can help prevent potential null pointer exceptions in runtime, ultimately leading to more stable application.	2023-11-29 16:25:35 +01:00
Winni Neessen	cf678be9dd	Handle nil pointer in IsTemp method in senderror.go ... Added a nil check in the IsTemp method in senderror.go to prevent runtime errors when method is called on a nil object. The method now immediately returns false if it is invoked on a nil *SendError, ensuring the program's robustness against potential misuse. This increases the robustness and readability of the	2023-11-20 18:45:35 +01:00
Winni Neessen	468e1e2b2c	Protect against empty address list, refactor error handling ... Added a condition to prevent assignment of an empty address list to the 'HeaderFrom' scenario. This eliminates potential runtime errors when trying to access an nonexistent element of a slice. Adjusted error handling in the sendmail execution part by reusing the 'err' variable, promoting cleaner, more readable code.	2023-11-20 18:36:19 +01:00
Winni Neessen	1e447b5f2c	Merge branch 'main' into feature/145_add-eml-parser-to-generate-msg-from-eml-files	2023-11-10 18:23:52 +01:00
Winni Neessen	cdc8c37309	Merge pull request #155 from wneessen/feature/152_recipients_from_single_string ... Add new methods and tests for handling email addresses	2023-11-10 18:22:45 +01:00
Winni Neessen	43c26a37e3	Updated mail.Address initialization in tests to make golangci-lint happy ... Tests for new mail address handling methods have been updated to use {Name:"", Address: "email@example.com"} format for initializing the []*mail.Address slices, instead of the previous shorthand {"", "email@example.com"}. This was done to increase code clarity and explicitness.	2023-11-10 18:14:44 +01:00
Winni Neessen	cc14864129	#152: Add new methods and tests for handling email addresses ... Added new methods `ToFromString()`, `CcFromString()` and `BccFromString()` in msg.go file to handle strings of comma-separated email addresses.	2023-11-10 18:07:56 +01:00
Winni Neessen	e9331e0b7c	Add time import and tests for invalid date in email ... Added `time` import in the eml_test.go and added two new test use-cases: `exampleMailPlainNoEncInvalidDate` and `exampleMailPlainNoEncNoDate`. The `exampleMailPlainNoEncInvalidDate` is used to check if the parser can correctly handle email with invalid date. Meanwhile, `exampleMailPlainNoEncNoDate` checks if the parser can correctly add the current date to an email that didn't specify a date. This will improve the parser's resilience and flexibility in handling various email scenarios.	2023-11-05 19:48:43 +01:00
Winni Neessen	8a1391b9df	Update test emails and enhance parser tests ... The test emails in the eml_test.go file have been updated with more diverse fields, including variations of encoding types. These changes help improve the robustness of our parser tests by evaluating its function with a wider range of email structures. Tests including quoted-printable and base64 encoded emails have been added.	2023-11-02 16:06:27 +01:00
Winni Neessen	9607d08469	Add EML parsing from string to tests ... A new test `TestEMLToMsgFromString` was added to "eml_test.go". This test asserts the proper functionality of `EMLToMsgFromString` method that allows us to parse EMLs directly from a string input. This test is a necessary part of ensuring the functionality and reliability of our EML parsing process.	2023-10-31 11:45:37 +01:00