Merge e7e0fe03bb into c47f08dc7f

This commit eliminates the duplication of the '14.1' OS version in the CI workflow matrix configuration. Simplifying the matrix helps in avoiding redundant test runs and ensures a clearer CI process.

.github/workflows/ci.yml

@@ -31,6 +31,7 @@ jobs:
                 go: ['1.23']
         env:
             PERFORM_ONLINE_TEST: ${{ vars.PERFORM_ONLINE_TEST }}
+            PERFORM_UNIX_OPEN_WRITE_TESTS: "true"
             TEST_SENDMAIL: ${{ vars.TEST_SENDMAIL }}
             TEST_HOST: ${{ secrets.TEST_HOST }}
             TEST_USER: ${{ secrets.TEST_USER }}
@@ -144,7 +145,7 @@ jobs:
             cancel-in-progress: true
         strategy:
             matrix:
-                osver: ['13.4', '14.0', '14.1']
+                osver: ['14.1', '14.0', 13.4']
         steps:
             - name: Checkout Code
               uses: actions/checkout@61b9e3751b92087fd0b06925ba6dd6314e06f089 # master
@@ -152,9 +153,11 @@ jobs:
               uses: vmactions/freebsd-vm@v1
               with:
                   usesh: true
+                  copyback: false
                   prepare: |
                     pkg install -y go
                   run: |
+                    cd $GITHUB_WORKSPACE;
                     go test -race -shuffle=on ./...
     reuse:
         name: REUSE Compliance Check

msg_unix_test.go

@@ -2,8 +2,8 @@
 //
 // SPDX-License-Identifier: MIT
 
-//go:build !windows
+//go:build linux || freebsd
-// +build !windows
+// +build linux freebsd
 
 package mail
 
@@ -18,23 +18,28 @@ import (
 
 func TestMsg_AttachFile_unixOnly(t *testing.T) {
 	t.Run("AttachFile with fileFromFS fails on open", func(t *testing.T) {
-		tempfile, err := os.CreateTemp("testdata/tmp", "attachfile-unable-to-open.*.txt")
+		if os.Getenv("PERFORM_UNIX_OPEN_WRITE_TESTS") != "true" {
+			t.Skipf("PERFORM_UNIX_OPEN_WRITE_TESTS variable is not set. Skipping unix open/write tests")
+		}
+
+		tempFile, err := os.CreateTemp("testdata/tmp", "attachfile-open-write-test.*.txt")
 		if err != nil {
 			t.Fatalf("failed to create temp file: %s", err)
 		}
 		t.Cleanup(func() {
-			if err := os.Remove(tempfile.Name()); err != nil {
+			if err := os.Remove(tempFile.Name()); err != nil {
 				t.Errorf("failed to remove temp file: %s", err)
 			}
 		})
-		if err = os.Chmod(tempfile.Name(), 0o000); err != nil {
+		if err = os.Chmod(tempFile.Name(), 0o000); err != nil {
-			t.Fatalf("failed to chmod temp file to 0000: %s", err)
+			t.Fatalf("failed to chmod temp file: %s", err)
 		}
+
 		message := NewMsg()
 		if message == nil {
 			t.Fatal("message is nil")
 		}
-		message.AttachFile(tempfile.Name())
+		message.AttachFile(tempFile.Name())
 		attachments := message.GetAttachments()
 		if len(attachments) != 1 {
 			t.Fatalf("failed to get attachments, expected 1, got: %d", len(attachments))