wneessen/go-meteologix
1
1
Fork 0
Code Issues Pull requests Actions Packages Projects Releases 7 Wiki Activity

Fix typo and improve direction calculations

Browse source 
Correct typos related to Angle naming and update calculations for start and end ranges in direction mapping. This ensures accurate and valid directional values are used in the application.
This commit is contained in:
Winni Neessen 2023-06-27 16:49:22 +02:00
parent 28479be939
commit d0905266e1
Signed by: wneessen
GPG key ID: 5F3AF39B820C119D
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
direction.go
View file

@ -12,10 +12,10 @@ import (
) )
const ( const (
// DirectionMinAngel is the minimum angel for a direction // DirectionMinAngle is the minimum angel for a direction
DirectionMinAngel = 0 DirectionMinAngle = 0
// DirectionMaxAngel is the maximum angel for a direction // DirectionMaxAngle is the maximum angel for a direction
DirectionMaxAngel = 360 DirectionMaxAngle = 360
) )
// WindDirAbbrMap is a map to associate a wind direction degree value with // WindDirAbbrMap is a map to associate a wind direction degree value with
@ -84,7 +84,7 @@ func (d Direction) Source() Source {
// Direction returns the abbreviation string for a given Direction type // Direction returns the abbreviation string for a given Direction type
func (d Direction) Direction() string { func (d Direction) Direction() string {
if d.fv < DirectionMinAngel || d.fv > DirectionMaxAngel { if d.fv < DirectionMinAngle || d.fv > DirectionMaxAngle {
return ErrUnsupportedDirection return ErrUnsupportedDirection
} }
if ds, ok := WindDirAbbrMap[d.fv]; ok { if ds, ok := WindDirAbbrMap[d.fv]; ok {
@ -95,7 +95,7 @@ func (d Direction) Direction() string {
// DirectionFull returns the full string for a given Direction type // DirectionFull returns the full string for a given Direction type
func (d Direction) DirectionFull() string { func (d Direction) DirectionFull() string {
if d.fv < DirectionMinAngel || d.fv > DirectionMaxAngel { if d.fv < DirectionMinAngle || d.fv > DirectionMaxAngle {
return ErrUnsupportedDirection return ErrUnsupportedDirection
} }
if ds, ok := WindDirFullMap[d.fv]; ok { if ds, ok := WindDirFullMap[d.fv]; ok {
@ -125,8 +125,8 @@ func findDirection(v float64, m map[float64]string) string {
break break
} }
} }
sr := math.Mod(v, sv) sr := v - sv
er := math.Mod(ev, v) er := ev - v
if er > sr { if er > sr {
return m[sv] return m[sv]
} }