wneessen/niljson
1
0
Fork 0
mirror of https://github.com/wneessen/niljson.git synced 2024-11-25 15:00:49 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactor error messages in niljson_test.go

Browse source 
Replaced hardcoded error strings with `ErrExpectedJSONInt` constant for consistency. This improves maintainability and readability of the test code by centralizing error message definitions.
This commit is contained in:
Winni Neessen 2024-09-11 10:31:42 +02:00
parent 98bcb37c50
commit 9584d3ec3c
Signed by: wneessen
GPG key ID: 385AC9889632126E
1 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
niljson_test.go
View file

@ -16,6 +16,7 @@ const (
ErrUnmarshalFailed = "failed to unmarshal json with nil types: %s" ErrUnmarshalFailed = "failed to unmarshal json with nil types: %s"
ErrMarshalFailed = "failed to marshal json with nil types: %s" ErrMarshalFailed = "failed to marshal json with nil types: %s"
ErrExpectedJSONString = "expected json to be %q, got %q" ErrExpectedJSONString = "expected json to be %q, got %q"
ErrExpectedJSONInt = "expected json to be %d, got %d"
) )
var jsonBytes = []byte( var jsonBytes = []byte(
@ -240,7 +241,7 @@ func TestVariable_UnmarshalJSON_Int(t *testing.T) {
t.Errorf("expected nil, but got value") t.Errorf("expected nil, but got value")
} }
if jt.Value.Value() != expected { if jt.Value.Value() != expected {
t.Errorf("expected value to be %d, got %d", expected, jt.Value.Value()) t.Errorf(ErrExpectedJSONInt, expected, jt.Value.Value())
} }
jt.Value.Reset() jt.Value.Reset()
@ -287,7 +288,7 @@ func TestVariable_UnmarshalJSON_Int64(t *testing.T) {
t.Errorf("expected nil, but got value") t.Errorf("expected nil, but got value")
} }
if jt.Value.Value() != expected { if jt.Value.Value() != expected {
t.Errorf("expected value to be %d, got %d", expected, jt.Value.Value()) t.Errorf(ErrExpectedJSONInt, expected, jt.Value.Value())
} }
jt.Value.Reset() jt.Value.Reset()
@ -381,7 +382,7 @@ func TestVariable_UnmarshalJSON_UInt(t *testing.T) {
t.Errorf("expected nil, but got value") t.Errorf("expected nil, but got value")
} }
if jt.Value.Value() != expected { if jt.Value.Value() != expected {
t.Errorf("expected value to be %d, got %d", expected, jt.Value.Value()) t.Errorf(ErrExpectedJSONInt, expected, jt.Value.Value())
} }
jt.Value.Reset() jt.Value.Reset()
@ -428,7 +429,7 @@ func TestVariable_UnmarshalJSON_UInt8(t *testing.T) {
t.Errorf("expected nil, but got value") t.Errorf("expected nil, but got value")
} }
if jt.Value.Value() != expected { if jt.Value.Value() != expected {
t.Errorf("expected value to be %d, got %d", expected, jt.Value.Value()) t.Errorf(ErrExpectedJSONInt, expected, jt.Value.Value())
} }
jt.Value.Reset() jt.Value.Reset()
@ -475,7 +476,7 @@ func TestVariable_UnmarshalJSON_UInt16(t *testing.T) {
t.Errorf("expected nil, but got value") t.Errorf("expected nil, but got value")
} }
if jt.Value.Value() != expected { if jt.Value.Value() != expected {
t.Errorf("expected value to be %d, got %d", expected, jt.Value.Value()) t.Errorf(ErrExpectedJSONInt, expected, jt.Value.Value())
} }
jt.Value.Reset() jt.Value.Reset()
@ -522,7 +523,7 @@ func TestVariable_UnmarshalJSON_UInt32(t *testing.T) {
t.Errorf("expected nil, but got value") t.Errorf("expected nil, but got value")
} }
if jt.Value.Value() != expected { if jt.Value.Value() != expected {
t.Errorf("expected value to be %d, got %d", expected, jt.Value.Value()) t.Errorf(ErrExpectedJSONInt, expected, jt.Value.Value())
} }
jt.Value.Reset() jt.Value.Reset()
@ -569,7 +570,7 @@ func TestVariable_UnmarshalJSON_UInt64(t *testing.T) {
t.Errorf("expected nil, but got value") t.Errorf("expected nil, but got value")
} }
if jt.Value.Value() != expected { if jt.Value.Value() != expected {
t.Errorf("expected value to be %d, got %d", expected, jt.Value.Value()) t.Errorf(ErrExpectedJSONInt, expected, jt.Value.Value())
} }
jt.Value.Reset() jt.Value.Reset()