1204 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Winni Neessen	ea57644a8e	Add debug logging to client creation in tests ... Introduce `WithDebugLog()` in client creation for enhanced logging during tests. Correct handling of certain SMTP command errors by replacing `return` with `break` in switch cases for proper loop continuation.	2024-10-23 22:20:32 +02:00
Winni Neessen	74fa3f6f62	Fix Quit handling when initial HELO fails ... Ensure QUIT command can be sent even if initial HELO fails. Added a check to skip retrying HELO if it already failed, allowing for proper closing of the connection. This prevents potential hangs or errors during connection termination.	2024-10-23 21:54:06 +02:00
Winni Neessen	572751ac10	Add test for invalid HELO handling in SMTP client ... Introduce a new test case to ensure the SMTP client fails gracefully when an invalid HELO command is used. This includes validating error handling and maintaining the client connection integrity. Also, optimize EHLO/HELO command handling by enhancing syntax checking and error response generation.	2024-10-23 18:20:52 +02:00
Winni Neessen	d281f838d4	Add integration tests for invalid host and HELO failure ... Add test cases to validate client behavior on connecting with an invalid host and encountering a HELO failure. This helps ensure the client handles these error scenarios correctly, maintaining robustness and reliability.	2024-10-23 18:08:30 +02:00
Winni Neessen	0db1383940	Refactor buffer initialization in client tests ... Replaced &bytes.Buffer{} with bytes.NewBuffer(nil) for buffer initialization in various client tests. This change ensures more idiomatic and consistent creation of byte buffers throughout the test cases.	2024-10-23 17:58:08 +02:00
Winni Neessen	21184e60b9	Switch to using bytes.NewBuffer(nil) in tests ... Refactored the test code to initialize buffers using bytes.NewBuffer(nil) instead of &bytes.Buffer{}. This change ensures a consistent and idiomatic initialization of byte buffers throughout the test cases.	2024-10-23 17:57:09 +02:00
Winni Neessen	12695385e8	Refactor SMTP server test setup to use serverProps struct ... Consolidate server configuration properties into a new serverProps struct for better code clarity and future extensibility. This change involves updating simpleSMTPServer and test cases to use the new struct, allowing more control over server behavior during tests.	2024-10-23 17:55:31 +02:00
Winni Neessen	8a6cd2b448	Add and update client tests ... Reintroduces and enhances several client tests including `SetLogAuthData`, `Close`, `DialWithContext`, and others. Deprecated and non-functional tests are removed, and a new log parsing method is added for enhanced logging validation.	2024-10-23 17:34:23 +02:00
Winni Neessen	ae7160ddba	Refactor SMTP Auth unit test with table-driven approach ... Replaced the single test case for setting custom SMTP authentication with a table-driven approach. This refactor improves test coverage by including multiple authentication methods such as CRAM-MD5, LOGIN, PLAIN, SCRAM, and XOAUTH2.	2024-10-23 16:46:18 +02:00
Winni Neessen	d4dc212dd3	Refactor client tests and add SetSMTPAuthCustom test ... Removed outdated tests for TLSConfig, Username, Password, and SMTPAuth that were commented out. Added a new test for the SetSMTPAuthCustom method, specifically for PLAIN authentication, ensuring proper behavior and type checks.	2024-10-23 16:14:05 +02:00
Winni Neessen	17cb590a45	Add test for Client.SetSMTPAuth function ... Introduce a new test to validate the functionality of the Client.SetSMTPAuth method. This test covers various SMTP authentication types and ensures that the method correctly sets the expected authentication type while also verifying the override behavior for different custom and default authentications.	2024-10-23 15:44:21 +02:00
Winni Neessen	cec7e38332	Merge pull request #345 from wneessen/dependabot/github_actions/github/codeql-action-3.27.0 ... Bump github/codeql-action from 3.26.13 to 3.27.0	2024-10-23 15:32:09 +02:00
Winni Neessen	c946f74ad2	Add unit tests for Client TLS, Username, and Password methods ... Introduced unit tests for Client's SetTLSConfig, SetUsername, and SetPassword methods. The tests cover various scenarios, including setting valid configurations, handling nil inputs, and overriding previous settings. This improves our test coverage and ensures the reliability of these methods.	2024-10-23 15:31:00 +02:00
dependabot[bot]	9ad77012e3	Bump github/codeql-action from 3.26.13 to 3.27.0 ... Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.13 to 3.27.0. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](f779452ac5...662472033e) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2024-10-23 13:16:56 +00:00
Winni Neessen	68bc5dde72	Add comprehensive tests for Client TLS and debugging features ... Implemented detailed test cases for various TLS policies and settings, port configurations, and SSL options. Also added tests for debugging functionalities of the Client, enabling robust validation of different scenarios.	2024-10-23 15:15:59 +02:00
Winni Neessen	3efd2b529f	Set fallbackPort to 0 in SetTLSPortPolicy ... The default fallback port should be reset to 0 when setting the TLS port policy. This ensures the fallbackPort does not retain an incorrect value when switching policies.	2024-10-23 14:39:28 +02:00
Winni Neessen	c5b57543c1	Update client tests to add context support and new checks ... Introduced `context` package for new tests. Added checks for `WithDialContextFunc`, `WithLogAuthData`, and TLS policy assertions. Improved test failure handling and removed obsolete tests.	2024-10-23 14:08:19 +02:00
Winni Neessen	ab8fc3e4fc	Add DSN and dial context func options to client tests ... Expanded the client test cases to include DSN mail return types and multiple DSN recipient notify types. Also added tests for setting dial context functions using both net.Dialer and tls.Dialer, including error handling for invalid options.	2024-10-23 13:51:48 +02:00
Winni Neessen	35f92f2ddc	Add error handling for nil DialContextFunc ... Introduce ErrDialContextFuncIsNil to handle cases where the dial context function is not provided. Update WithDialContextFunc to return this error when a nil function is passed.	2024-10-23 13:51:31 +02:00
Winni Neessen	3251d74c36	Refactor client test to enhance coverage and clarity ... Reorganized and refactored tests for `NewClient` by adding individual test cases for different client creation scenarios, including various options and validation. Improved clarity and coverage by isolating cases, enhancing error messages, and removing redundancy.	2024-10-23 13:23:01 +02:00
Winni Neessen	1c8b2904f5	Add error check for nil SMTP authentication method ... Ensure that the SMTP authentication method is not nil by adding a corresponding error check in the WithSMTPAuthCustom function. Introduced a new error, ErrSMTPAuthMethodIsNil, to handle this validation.	2024-10-23 13:10:13 +02:00
Winni Neessen	ab835b7870	Uncomment seed data in FuzzBase64LineBreaker ... The previously commented-out empty byte array is now uncommented to include an empty string as part of the test cases. This change ensures that the FuzzBase64LineBreaker function properly handles an empty input scenario.	2024-10-23 11:36:06 +02:00
Winni Neessen	0bac51746d	Add error handling for base64 decoding in test ... This commit adds a check for errors when decoding base64 strings in the b64linebreaker_test.go file. If an error occurs, it logs a meaningful error message, improving the test's robustness and clarity.	2024-10-23 11:29:04 +02:00
Winni Neessen	b31c7cf3a7	Add licenses for logo SVG files ... These files specify the copyright and licensing information for the logo assets. They ensure that our usage of these images complies with the CC-BY-ND-4.0 license.	2024-10-23 11:26:42 +02:00
Winni Neessen	854361090a	Add coverage files to .gitignore ... This change ensures that coverage data files are not tracked by Git. The addition helps keep the repository clean from auto-generated coverage reports.	2024-10-23 11:21:03 +02:00
Winni Neessen	421451f179	Add base64-encoded logo.svg to testdata ... This commit introduces a new file, logo.svg.base64, into the testdata directory. This encoded SVG logo will be useful for testing purposes.	2024-10-23 11:20:24 +02:00
Winni Neessen	bdfe13dc93	Overhauled Base64LineBreaker test suite ... Improved the test suite for the Base64LineBreaker. Tests are now written more consistently. Maintainability and readability have been improved as well.	2024-10-23 11:19:58 +02:00
Winni Neessen	946d9888d6	Refactor error handling in Base64LineBreaker ... Switched ErrNoOutWriter from a string constant to an error object for improved error handling consistency. This change enhances clarity and reduces the risk of error handling inconsistencies in the future.	2024-10-23 11:16:09 +02:00
Winni Neessen	2088796049	Remove testdata directory and extra newline from .gitignore ... The testdata directory entry was incorrect and has been removed. Additionally, an extra newline at the end of the file was removed for consistency.	2024-10-23 11:15:32 +02:00
Winni Neessen	55e5a1536e	Merge pull request #344 from wneessen/feature/342_allow-bypass-plain-auth-tls-check ... Allow unencrypted PLAIN and LOGIN smtp authentication	2024-10-22 17:39:04 +02:00
Winni Neessen	c7d0a03ddc	Change error log to debug log in client_test.go ... Updated the log level from error to debug for the client.Close() call failure in client_test.go. This change helps reduce noise in test output when the server connection fails.	2024-10-22 16:21:09 +02:00
Winni Neessen	f79c1b8ebe	Add fig.StringUnmarshaler support for LOGIN-NOENC and PLAIN-NOENC authentication methods	2024-10-22 16:09:12 +02:00
Winni Neessen	df1a141368	Handle client close errors in SMTP tests ... Update defer statements to log errors if client fails to close in smtp_test.go. Additionally, add a return statement to avoid further errors after a failed SendMail operation.	2024-10-22 16:02:43 +02:00
Winni Neessen	e2ed5b747a	Add tests for PlainAuth and LoginAuth without encryption ... Introduced new test functions TestAuthPlainNoEnc and TestAuthLoginNoEnc in smtp_test.go to verify behaviors of PlainAuth and LoginAuth without TLS encryption. These tests ensure that authentication mechanisms handle non-encrypted and diverse server configurations correctly.	2024-10-22 15:50:18 +02:00
Winni Neessen	2bd950469a	Add 'skipTLS' parameter to auth functions in tests ... Updated PlainAuth and LoginAuth calls in smtp_test.go and example_test.go to include a 'skipTLS' boolean parameter. This ensures consistent function signatures throughout the test cases and examples.	2024-10-22 15:44:40 +02:00
Winni Neessen	3c29f68cc1	Add support for unsecured SMTP LOGIN auth ... Implemented an option to allow SMTP LOGIN authentication over unencrypted channels by introducing a new `SMTPAuthLoginNoEnc` type. Updated relevant functions and tests to handle the new parameter for unsecured authentication.	2024-10-22 15:38:51 +02:00
Winni Neessen	f5531eae14	Add support for PLAIN authentication without encryption ... Implemented a new SMTPAuthPlainNoEnc option to allow PLAIN authentication over unencrypted connections. Refactored the PlainAuth function to accept an additional allowUnencryptedAuth parameter. Updated relevant tests to cover the new authentication method.	2024-10-22 15:30:15 +02:00
Winni Neessen	91caf200ec	Merge pull request #343 from wneessen/dependabot/github_actions/actions/dependency-review-action-4.3.5 ... Bump actions/dependency-review-action from 4.3.4 to 4.3.5	2024-10-22 15:13:07 +02:00
dependabot[bot]	63e6fc882d	Bump actions/dependency-review-action from 4.3.4 to 4.3.5 ... Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 4.3.4 to 4.3.5. - [Release notes](https://github.com/actions/dependency-review-action/releases) - [Commits](5a2ce3f5b9...a6993e2c61) --- updated-dependencies: - dependency-name: actions/dependency-review-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2024-10-22 13:10:46 +00:00
Winni Neessen	957cd8e0ca	Merge pull request #341 from wneessen/fig-support ... Add fig.StringUnmarshaler support for SMTPAuthType	2024-10-21 22:51:46 +02:00
Winni Neessen	09133ef2a4	Add test for invalid SMTPAuthType ... Introduce a new test case to verify that `UnmarshalString` fails when given an invalid string. This ensures the robustness of the error handling in the `SMTPAuthType` unmarshalling process.	2024-10-21 22:34:47 +02:00
Winni Neessen	bf44fd2ad1	Add SPDX license headers to auth_test.go ... Included the SPDX license identifiers for copyright and license type at the beginning of the auth_test.go file. This ensures clear licensing information is provided and helps with automated license compliance.	2024-10-21 22:26:30 +02:00
Winni Neessen	7bebdda27c	Add fig.StringUnmarshaler support for SMTPAuthType ... Implement the fig.StringUnmarshaler interface for SMTPAuthType to map strings to corresponding authentication types. Added comprehensive unit tests to ensure correct functionality for all supported auth type strings.	2024-10-21 22:24:21 +02:00
Winni Neessen	c903f6e1b4	Merge pull request #340 from wneessen/bug/339_fix-spelling-errors ... Fix spelling errors	2024-10-16 10:41:41 +02:00
Winni Neessen	a638090d0e	Fix typo in multipart comment ... Corrected the spelling of "seperately" to "separately" in a comment explaining the parsing of multipart/related and multipart/alternative parts.	2024-10-16 10:38:40 +02:00
Winni Neessen	fb14e1e7dd	Fix typos in auth mechanism comments ... Corrected multiple instances of "mechansim" to "mechanism" in the comments describing SASL authentication methods to improve readability and maintain code quality.	2024-10-16 10:38:13 +02:00
Winni Neessen	f120485c98	Correct typo in comment ... Fix a typo in smtp_test.go's comment from "challanges" to "challenges" to improve readability and accuracy of documentation. This change does not affect the code's functionality.	2024-10-16 10:37:13 +02:00
Winni Neessen	569e8fbc70	Fix typos in comments for better readability ... Corrected spelling errors in comments for "challenge" and "compatibility" to improve clarity. This ensures better understanding and adherence to the documented IETF draft standard.	2024-10-16 10:35:29 +02:00
Winni Neessen	8ea80c0739	Update doc.go ... Bump version to v0.5.1 for release	2024-10-16 09:50:22 +02:00
Winni Neessen	9ae7681651	Merge pull request #336 from sarff/log-opt ... code duplication reduction for jsonlog.go and stdlog.go	2024-10-16 09:49:53 +02:00