935 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Winni Neessen	fd115d5173	Remove typo from comment in smtp_ehlo_117.go ... Fixed a typo in the backward compatibility comment for Go 1.16/1.17 in smtp_ehlo_117.go. This ensures clarity and correctness in documentation.	2024-09-23 14:15:43 +02:00
Winni Neessen	4f6224131e	Rename test for accurate context cancellation ... Updated the test name from `TestConnPool_GetContextTimeout` to `TestConnPool_GetContextCancel` to better reflect its functionality. This change improves test readability and maintains consistency with the context usage in the test.	2024-09-23 13:46:41 +02:00
Winni Neessen	c8684886ed	Refactor Get method to include context argument ... Updated the Get method in connpool.go and its usage in tests to include a context argument for better cancellation and timeout handling. Removed the redundant dialContext field from the connection pool struct and added a new test to validate context timeout behavior.	2024-09-23 13:44:03 +02:00
Winni Neessen	07e7b17ae8	Add tests for ConnPool close and concurrency issues ... This commit introduces two new tests: `TestConnPool_Close` and `TestConnPool_Concurrency`. The former ensures the proper closing of connection pool resources, while the latter checks for concurrency issues by creating and closing multiple connections in parallel.	2024-09-23 11:45:22 +02:00
Winni Neessen	2abdee743d	Add unit test for marking connection as unusable ... Introduces `TestPoolConn_MarkUnusable` to ensure the pool maintains its integrity when a connection is marked unusable. This test validates that the connection pool size adjusts correctly after marking a connection as unusable and closing it.	2024-09-23 11:27:05 +02:00
Winni Neessen	5503be8451	Remove redundant error print statements ... Removed redundant fmt.Printf error print statements for connection read and write errors. This cleans up the test output and makes error handling more streamlined.	2024-09-23 11:26:54 +02:00
Winni Neessen	774925078a	Improve error handling in connection pool tests ... Add error checks to Close() calls in connpool_test.go to ensure connection closures are handled properly, with descriptive error messages. Update comment in connpool.go to improve clarity on the source of code inspiration.	2024-09-23 11:17:58 +02:00
Winni Neessen	f1188bdad7	Add test for PoolConn Close method ... This commit introduces a new test, `TestPoolConn_Close`, to verify that connections are correctly closed and returned to the pool. It sets up a simple SMTP server, creates a connection pool, tests writing to and closing connections, and checks the pool size to ensure proper behavior.	2024-09-23 11:15:56 +02:00
Winni Neessen	2cbd0c4aef	Add test cases for connection pool functionality ... Added new test cases `TestConnPool_Get_Type` and `TestConnPool_Get` to verify connection pool operations. These tests ensure proper connection type and handling of pool size after connection retrieval and usage.	2024-09-23 11:09:11 +02:00
Winni Neessen	9a9e0c936d	Remove redundant error handling in test code ... The check for io.EOF and the associated print statement were unnecessary because the loop breaks on any error. This change simplifies the error handling logic in the `client_test.go` file and avoids redundant code.	2024-09-23 11:09:03 +02:00
Winni Neessen	33d4eb5b21	Add unit tests for connection pool and rename Len to Size ... Introduced unit tests for the connection pool to ensure robust functionality. Also, renamed the Len method to Size in the Pool interface and its implementation for better clarity and consistency.	2024-09-23 10:33:06 +02:00
Winni Neessen	d6e5034bba	Add new error handling and connection management in connpool ... Introduce ErrClosed and ErrNilConn errors for better error handling. Implement Close and MarkUnusable methods for improved connection lifecycle management. Add put method to return connections to the pool or close them if necessary.	2024-09-23 10:09:38 +02:00
Winni Neessen	1394f1fc20	Add context management and error handling to connection pool ... Introduced context support and enhanced error handling in connpool.go. Added detailed comments for better maintainability and introduced a wrapper for net.Conn to manage connection close behavior. The changes improve the robustness and clarity of the connection pool's operation.	2024-09-23 09:56:23 +02:00
Winni Neessen	26ff177fb0	Add connPool implementation and connection pool errors ... Introduce connPool struct and implement the Pool interface. Add error handling for invalid pool capacity settings and provide a constructor for creating new connection pools with specified capacities.	2024-09-22 21:12:59 +02:00
Winni Neessen	5ec8a5a5fe	Add initial connection pool interface ... Introduces a new `connpool.go` file implementing a connection pool interface for managing network connections. This interface includes methods to get and close connections, as well as to retrieve the current pool size. The implementation is initially based on a fork of code from the Fatih Arslan GitHub repository.	2024-09-22 20:48:09 +02:00
Winni Neessen	580d0b0e4e	Merge pull request #303 from wneessen/more-test-coverage ... More test coverage	2024-09-20 22:21:49 +02:00
Winni Neessen	3f0ac027e2	Add test for zero input in randNum ... This commit introduces a new test case in random_test.go to ensure that the randNum function returns zero when given an input of zero. This helps validate the correctness of edge case handling in the random number generation logic.	2024-09-20 22:06:11 +02:00
Winni Neessen	0b9a215e7d	Add deferred TMPDIR restoration in test setup ... Store and restore the original TMPDIR value using a deferred function in `msg_nowin_test.go`. This ensures the TMPDIR environment variable is restored after the test runs, preventing potential side effects on other tests or processes.	2024-09-20 21:42:10 +02:00
Winni Neessen	4053457020	Refactor TestSendError_ErrorMulti formatting ... Reformatted the instantiation of the SendError struct to improve readability. This helps maintain consistency and clarity in the code base for better collaboration and future maintenance.	2024-09-20 21:15:13 +02:00
Winni Neessen	f3633e1913	Add tests for SendError functionalities ... Introduce tests for `SendError` to verify behavior of `errors.Is` and string representation. `TestSendError_IsFail` checks for error mismatch, and `TestSendError_ErrorMulti` verifies the formatted error message.	2024-09-20 21:11:19 +02:00
Winni Neessen	52061f97c6	Add tests for nil SendError MessageID and Msg ... These tests ensure that accessing MessageID and Msg methods on a nil SendError pointer returns the expected values (empty string and nil respectively). This helps in validating the error handling logic and avoiding potential nil pointer dereference issues.	2024-09-20 20:58:29 +02:00
Winni Neessen	77920be1a1	Remove unnecessary error handling ... Eliminated redundant error handling for random number generation as errors from these functions do not require special attention. This reduces code complexity and improves readability.	2024-09-20 20:39:50 +02:00
Winni Neessen	f5d4cdafea	Increase test iterations for SetMessageID randomness check ... Updated the TestMsg_SetMessageIDRandomness test to run 50,000 iterations instead of 100, ensuring a more robust evaluation of the Msg.SetMessageID method's randomness. Additionally, streamlined the retrieval of Message ID using GetMessageID.	2024-09-20 20:39:30 +02:00
Winni Neessen	19330fc108	Refactor random number generation and add version-specific implementations ... Removed error handling from `randNum` in `random_test.go` and introduced new `randNum` implementations for different Go versions (1.19, 1.20-1.21, 1.22+). This ensures compatibility with different versions of Go and utilizes the appropriate version-specific random number generation methods. We are using math/rand instead crypto/rand. For our needs this should be sufficient.	2024-09-20 20:30:23 +02:00
Winni Neessen	af9915e4e7	Add test for WriteToTempFile failure scenario ... This new test verifies error handling for WriteToTempFile when the TMPDIR environment variable is set to an invalid directory. It ensures that the method fails as expected under these conditions, improving code robustness.	2024-09-20 19:45:49 +02:00
Winni Neessen	6f869e4efd	Merge pull request #302 from wneessen/feature/improve-client-tests ... Improved client error testing	2024-09-20 17:51:19 +02:00
Winni Neessen	44df830348	Add tests for SendError MessageID and Msg methods ... Introduce two new tests in senderror_test.go: TestSendError_MessageID and TestSendError_Msg. These tests validate the behavior of the MessageID and Msg methods of the SendError type, ensuring correct handling of message ID and sender information.	2024-09-20 17:00:08 +02:00
Winni Neessen	4ee11e8406	Refactor SMTP server port handling in tests ... Modified tests to dynamically compute server ports from a base value, enhancing flexibility and preventing potential conflicts. Updated `simpleSMTPServer` function to accept a port parameter.	2024-09-20 16:44:15 +02:00
Winni Neessen	bd5a8a40b9	Fix error handling in Send method in client_119.go ... Refine Send method to correctly typecast and accumulate SendError instances. Introduce "errors" package import to utilize errors.As for precise error type checking, ensuring accurate error lists. This regression was introduced with PR #301	2024-09-20 16:40:12 +02:00
Winni Neessen	8dfb121aec	Update Go versions in GitHub Actions workflow ... Removed Go 1.21 and added Go 1.19 in the codecov.yml file to ensure compatibility with older projects and streamline the CI process. This helps in maintaining backward compatibility and avoids potential issues with unsupported Go versions.	2024-09-20 16:24:59 +02:00
Winni Neessen	d5437f6b7a	Remove redundant comments from sleep statements ... Removed unnecessary comments that were clarifying the purpose of sleep statements in the test cases. This makes the code cleaner and easier to maintain by reducing clutter.	2024-09-20 16:23:31 +02:00
Winni Neessen	157c138142	Fix linter errors ... Replaced `err == io.EOF` with `errors.Is(err, io.EOF)` for better error comparison. Removed redundant `break` statements to streamline case logic and improve code readability.	2024-09-20 15:58:51 +02:00
Winni Neessen	482194b4b3	Add TestClient_SendErrorReset to validate SMTP error handling ... This test checks the client's ability to handle SMTP reset errors when sending an email. It verifies the correct error type, ensures it is recognized as a permanent error, and confirms the correct message ID handling.	2024-09-20 15:52:05 +02:00
Winni Neessen	b8f0462ce3	Add error handling tests for SMTP client ... Implemented multiple tests to cover various error scenarios in the SMTP client, including invalid email addresses and data transmission failures. Introduced `failReset` flag in `simpleSMTPServer` to simulate server reset failures.	2024-09-20 15:49:03 +02:00
Winni Neessen	6af6a28f78	Add test for SendError with no encoding ... Introduced `TestClient_SendErrorNoEncoding` to verify client behavior when sending a message without encoding. Adjusted server connection handling for better error reporting and connection closure, replacing abrupt exits with returns where appropriate.	2024-09-20 15:05:43 +02:00
Winni Neessen	0aa24c6f3a	Add methods to retrieve message ID and message from SendError ... Implement MessageID and Msg methods in SendError to allow retrieval of the message ID and the affected message, respectively. These methods handle cases where the error or the message is nil, returning an empty string or nil as appropriate.	2024-09-20 15:05:26 +02:00
Winni Neessen	fbebcf96d8	Add simple SMTP test server for unit testing ... Implemented a simple SMTP test server to facilitate unit testing. This server listens on a specified address and port, accepts connections, and processes common SMTP commands like HELO, MAIL FROM, RCPT TO, DATA, and QUIT. Several constants related to the server configuration were also added to the test file.	2024-09-20 14:48:24 +02:00
Winni Neessen	619318ba0d	Merge pull request #301 from wneessen/feature/168_improve-error-handling ... Improved error handling	2024-09-20 11:02:49 +02:00
Winni Neessen	d400379e2f	Refactor error handling for SendError struct ... Reformat the construction of SendError objects for better readability. This improves the clarity and maintainability of the error handling code within the client.go file.	2024-09-20 10:31:19 +02:00
Winni Neessen	fcbd202595	Add test for IsTemp method on nil SendError ... This commit introduces a new test case to verify the behavior of the IsTemp method when called on a nil SendError instance. It ensures that the method returns false as expected, improving test coverage for edge cases.	2024-09-20 10:30:30 +02:00
Winni Neessen	db2ec99cd6	Merge pull request #300 from wneessen/dependabot/github_actions/github/codeql-action-3.26.8 ... Bump github/codeql-action from 3.26.7 to 3.26.8	2024-09-19 15:45:49 +02:00
dependabot[bot]	664b7299e6	Bump github/codeql-action from 3.26.7 to 3.26.8 ... Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.7 to 3.26.8. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](8214744c54...294a9d9291) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2024-09-19 13:44:59 +00:00
Winni Neessen	508a2f2a6c	Refactor connection handling in tests ... Replaced `getTestConnection` with `getTestConnectionNoTestPort` for tests that skip port configuration, improving connection setup flexibility. Added environment variable support for setting ports in `getTestClient` to streamline port configuration in tests.	2024-09-19 15:21:17 +02:00
Winni Neessen	f469ba977d	Add affected message ID to error log ... Include the affected message ID in the error message to provide more context for debugging. This change ensures that each error log contains essential information about the specific message associated with the error.	2024-09-19 12:12:48 +02:00
Winni Neessen	0239318d94	Add affectedMsg field to SendError struct ... Included the affected message in the SendError struct for better error tracking and debugging. This enhancement ensures that any errors encountered during the sending process can be directly associated with the specific message that caused them.	2024-09-19 12:09:23 +02:00
Winni Neessen	69e211682c	Add GetMessageID method to Msg ... Introduced GetMessageID to retrieve the Message ID from the Msg	2024-09-19 11:46:53 +02:00
Winni Neessen	3bdb6f7cca	Refactor variable naming in Send method ... Renamed variable `cerr` to `err` for consistency. This improves readability and standardizes error variable naming within the method.	2024-09-19 10:59:22 +02:00
Winni Neessen	277ae9be19	Refactor message sending logic ... Consolidated the message sending logic into a single `sendSingleMsg` function to reduce duplication and improve code maintainability. This change simplifies the `Send` method in multiple Go version files by removing redundant code and calling the new helper function instead.	2024-09-19 10:56:01 +02:00
Winni Neessen	2e7156182a	Rename variable 'failed' to 'hasError' for clarity ... Renamed the variable 'failed' to 'hasError' to better reflect its purpose and improve code readability. This change helps in understanding that the variable indicates the presence of an error rather than a generic failure.	2024-09-19 10:35:32 +02:00
Winni Neessen	8ee37abca2	Refactor error handling in message sending loop ... Changed from range over messages to range with index to correctly update sendError field in the original messages slice. This prevents shadowing issues and ensures proper error logging for each message.	2024-09-18 12:29:42 +02:00